Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default-instance-warmup support to aws_autoscaling_group resource #25709

Closed
gudlyf opened this issue Jul 6, 2022 · 3 comments · Fixed by #25722
Closed

Add default-instance-warmup support to aws_autoscaling_group resource #25709

gudlyf opened this issue Jul 6, 2022 · 3 comments · Fixed by #25722
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/autoscaling Issues and PRs that pertain to the autoscaling service.
Milestone

Comments

@gudlyf
Copy link

gudlyf commented Jul 6, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The aws_autoscaling_group resource does not currently (or is not clearly defined) to include a configuration item for default-instance-warmup, which will pause the collection of CloudWatch data on newly-launched instances after a set amount of time, to more accurately measure actual resource use (e.g., will not measure the bootstrapping actions on the instance that may spike CPU before serving requests)

If default_instance_warmup is not defined, it should be considered not enabled/false.

New or Affected Resource(s)

  • aws_autoscaling_group

Potential Terraform Configuration

resource "aws_autoscaling_group" "bar" {
  ...
  default_instance_warmup = 300
  ...
}

References

@gudlyf gudlyf added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 6, 2022
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/autoscaling Issues and PRs that pertain to the autoscaling service. labels Jul 6, 2022
@justinretzolk justinretzolk added good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 6, 2022
@bschaatsbergen
Copy link
Member

Picking this up together with a peer (@tiborhercz) - as he would like to start contributing to the project.

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This functionality has been released in v4.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/autoscaling Issues and PRs that pertain to the autoscaling service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants