Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Github webhooks in aws_codebuild_project #2571

Closed
jurajseffer opened this issue Dec 6, 2017 · 4 comments
Closed

Add support for Github webhooks in aws_codebuild_project #2571

jurajseffer opened this issue Dec 6, 2017 · 4 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/codebuild Issues and PRs that pertain to the codebuild service.
Milestone

Comments

@jurajseffer
Copy link
Contributor

AWS CodeBuild allows triggering via Github webhooks for pushes, PRs etc.

http://docs.aws.amazon.com/cli/latest/reference/codebuild/create-webhook.html
http://docs.aws.amazon.com/codebuild/latest/userguide/sample-github-pull-request.html

@apparentlymart apparentlymart added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 19, 2017
@apparentlymart
Copy link
Contributor

Hi @jurajseffer! Thanks for this feature request.

Supporting this feature via a new Terraform resource type (aws_codebuild_webhook, for example) in this provider seems like a reasonable idea to me.

The Terraform team at HashiCorp won't be able to work on this in the near future due to our focus being elsewhere, but we'd be happy to review a pull request if you or someone else has the time and motivation to implement it. Alternatively, if others would also like to see this implemented I'd encourage adding a 👍 upvote reaction to the original issue comment (not to this comment), which we use as one of the inputs to prioritize work for the Terraform team.

@radeksimko radeksimko added the service/codebuild Issues and PRs that pertain to the codebuild service. label Jan 28, 2018
@bflad bflad added this to the v1.21.0 milestone May 25, 2018
@bflad
Copy link
Contributor

bflad commented May 25, 2018

The new aws_codebuild_webhook resource will be available in version 1.21.0 of the AWS provider, likely releasing middle of next week. 🎉

@bflad bflad closed this as completed May 25, 2018
@bflad
Copy link
Contributor

bflad commented May 31, 2018

This has been released in version 1.21.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/codebuild Issues and PRs that pertain to the codebuild service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants