Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/aws_networkmanager_core_network_policy_document allow segments block bools to set specified values #25789

Merged
merged 3 commits into from
Jul 13, 2022
Merged

d/aws_networkmanager_core_network_policy_document allow segments block bools to set specified values #25789

merged 3 commits into from
Jul 13, 2022

Conversation

drewmullen
Copy link
Collaborator

@drewmullen drewmullen commented Jul 12, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25787

Output from acceptance testing:

$ make testacc PKG=networkmanager TESTS="TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 20 -run='TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic'  -timeout 180m
=== RUN   TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== CONT  TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
--- PASS: TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic (21.32s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager     25.812s

@github-actions github-actions bot added service/networkmanager Issues and PRs that pertain to the networkmanager service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Jul 12, 2022
@drewmullen drewmullen changed the title allow segments block bools to set specified values d/aws_networkmanager_core_network_policy_document allow segments block bools to set specified values Jul 12, 2022
@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Jul 12, 2022
@GlennChia
Copy link
Collaborator

GlennChia commented Jul 12, 2022 •
edited
Loading

Looks like all the bool values have omitempty removed. Test cases are also validating a value of false is reflected in the Target state. Minor change requested for the PR description to change Relates OR Closes to just Closes since this closes the tagged issue. Besides that, LGTM.

@GlennChia GlennChia self-requested a review July 12, 2022 15:04
@drewmullen drewmullen removed the needs-triage Waiting for first response or review from a maintainer. label Jul 12, 2022
ewbankkit
ewbankkit approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc PKG=networkmanager TESTS="TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 20 -run='TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_'  -timeout 180m
=== RUN   TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== PAUSE TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
=== CONT  TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic
--- PASS: TestAccNetworkManagerCoreNetworkPolicyDocumentDataSource_basic (8.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	12.719s

@ewbankkit
Copy link
Contributor

@drewmullen Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 6da7c14 into hashicorp:main Jul 13, 2022
@github-actions github-actions bot added this to the v4.23.0 milestone Jul 13, 2022
@github-actions
Copy link

This functionality has been released in v4.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GlennChia GlennChia GlennChia approved these changes

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
partner Contribution from a partner. service/networkmanager Issues and PRs that pertain to the networkmanager service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.23.0
4 participants
@drewmullen @GlennChia @ewbankkit @justinretzolk