Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dynamodb/table: Add replica propagate_tags #25866

Merged
merged 8 commits into from
Jul 19, 2022
Merged

dynamodb/table: Add replica propagate_tags #25866

merged 8 commits into from
Jul 19, 2022

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Jul 18, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13281

Output from acceptance testing:

% make testacc TESTS=TestAccDynamoDBTable_ PKG=dynamodb
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dynamodb/... -v -count 1 -parallel 20 -run='TestAccDynamoDBTable_'  -timeout 180m
--- PASS: TestAccDynamoDBTable_streamSpecificationValidation (20.75s)
--- PASS: TestAccDynamoDBTable_basic (92.21s)
--- PASS: TestAccDynamoDBTable_lsiNonKeyAttributes (112.85s)
--- PASS: TestAccDynamoDBTable_tags (118.72s)
--- PASS: TestAccDynamoDBTable_attributeUpdateValidation (34.95s)
--- PASS: TestAccDynamoDBTable_BillingMode_payPerRequestToProvisionedIgnoreChanges (159.73s)
--- PASS: TestAccDynamoDBTable_BillingMode_payPerRequestToProvisioned (169.43s)
--- PASS: TestAccDynamoDBTable_streamSpecification (178.72s)
--- PASS: TestAccDynamoDBTable_tableClassInfrequentAccess (179.58s)
--- PASS: TestAccDynamoDBTable_BillingModeGSI_payPerRequestToProvisioned (192.11s)
--- PASS: TestAccDynamoDBTable_gsiUpdateCapacity (194.54s)
--- PASS: TestAccDynamoDBTable_TTL_enabled (62.97s)
--- PASS: TestAccDynamoDBTable_GsiUpdateNonKeyAttributes_emptyPlan (90.43s)
--- PASS: TestAccDynamoDBTable_lsiUpdate (119.99s)
--- PASS: TestAccDynamoDBTable_TTL_disabled (104.60s)
--- PASS: TestAccDynamoDBTable_Replica_singleWithCMK (279.76s)
--- PASS: TestAccDynamoDBTable_disappears (40.50s)
--- PASS: TestAccDynamoDBTable_Disappears_payPerRequestWithGSI (111.35s)
--- PASS: TestAccDynamoDBTable_encryption (205.91s)
--- PASS: TestAccDynamoDBTable_enablePITR (89.58s)
--- PASS: TestAccDynamoDBTable_Replica_tagsOneOfTwo (374.04s)
--- PASS: TestAccDynamoDBTable_Replica_tagsTwoOfTwo (386.25s)
--- PASS: TestAccDynamoDBTable_Replica_pitr (405.01s)
--- PASS: TestAccDynamoDBTable_gsiUpdateNonKeyAttributes (422.91s)
--- PASS: TestAccDynamoDBTable_extended (228.47s)
--- PASS: TestAccDynamoDBTable_Replica_multiple (541.07s)
--- PASS: TestAccDynamoDBTable_Replica_single (623.74s)
--- PASS: TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequest (694.38s)
--- PASS: TestAccDynamoDBTable_attributeUpdate (699.51s)
--- PASS: TestAccDynamoDBTable_gsiUpdateOtherAttributes (859.49s)
--- PASS: TestAccDynamoDBTable_backup_overrideEncryption (906.50s)
--- PASS: TestAccDynamoDBTable_backupEncryption (913.74s)
--- PASS: TestAccDynamoDBTable_BillingModeGSI_provisionedToPayPerRequest (882.60s)
--- PASS: TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequestIgnoreChanges (1168.77s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	1170.940s

@YakDriver YakDriver requested a review from ewbankkit as a code owner July 18, 2022 20:55
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/apigateway Issues and PRs that pertain to the apigateway service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/codebuild Issues and PRs that pertain to the codebuild service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/ec2 Issues and PRs that pertain to the ec2 service. service/fsx Issues and PRs that pertain to the fsx service. service/iam Issues and PRs that pertain to the iam service. service/memorydb Issues and PRs that pertain to the memorydb service. service/networkfirewall Issues and PRs that pertain to the networkfirewall service. service/rds Issues and PRs that pertain to the rds service. service/vpc Issues and PRs that pertain to the vpc service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 18, 2022
@YakDriver YakDriver force-pushed the f-dynamodb-replicate-tags branch from c6493bd to 3c336af Compare July 18, 2022 21:32
ewbankkit
ewbankkit approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDynamoDBTable_' PKG=dynamodb ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dynamodb/... -v -count 1 -parallel 3  -run=TestAccDynamoDBTable_ -timeout 180m
=== RUN   TestAccDynamoDBTable_basic
=== PAUSE TestAccDynamoDBTable_basic
=== RUN   TestAccDynamoDBTable_disappears
=== PAUSE TestAccDynamoDBTable_disappears
=== RUN   TestAccDynamoDBTable_Disappears_payPerRequestWithGSI
=== PAUSE TestAccDynamoDBTable_Disappears_payPerRequestWithGSI
=== RUN   TestAccDynamoDBTable_extended
=== PAUSE TestAccDynamoDBTable_extended
=== RUN   TestAccDynamoDBTable_enablePITR
=== PAUSE TestAccDynamoDBTable_enablePITR
=== RUN   TestAccDynamoDBTable_BillingMode_payPerRequestToProvisioned
=== PAUSE TestAccDynamoDBTable_BillingMode_payPerRequestToProvisioned
=== RUN   TestAccDynamoDBTable_BillingMode_payPerRequestToProvisionedIgnoreChanges
=== PAUSE TestAccDynamoDBTable_BillingMode_payPerRequestToProvisionedIgnoreChanges
=== RUN   TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequest
=== PAUSE TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequest
=== RUN   TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequestIgnoreChanges
=== PAUSE TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequestIgnoreChanges
=== RUN   TestAccDynamoDBTable_BillingModeGSI_payPerRequestToProvisioned
=== PAUSE TestAccDynamoDBTable_BillingModeGSI_payPerRequestToProvisioned
=== RUN   TestAccDynamoDBTable_BillingModeGSI_provisionedToPayPerRequest
=== PAUSE TestAccDynamoDBTable_BillingModeGSI_provisionedToPayPerRequest
=== RUN   TestAccDynamoDBTable_streamSpecification
=== PAUSE TestAccDynamoDBTable_streamSpecification
=== RUN   TestAccDynamoDBTable_streamSpecificationValidation
=== PAUSE TestAccDynamoDBTable_streamSpecificationValidation
=== RUN   TestAccDynamoDBTable_tags
=== PAUSE TestAccDynamoDBTable_tags
=== RUN   TestAccDynamoDBTable_gsiUpdateCapacity
=== PAUSE TestAccDynamoDBTable_gsiUpdateCapacity
=== RUN   TestAccDynamoDBTable_gsiUpdateOtherAttributes
=== PAUSE TestAccDynamoDBTable_gsiUpdateOtherAttributes
=== RUN   TestAccDynamoDBTable_lsiNonKeyAttributes
=== PAUSE TestAccDynamoDBTable_lsiNonKeyAttributes
=== RUN   TestAccDynamoDBTable_gsiUpdateNonKeyAttributes
=== PAUSE TestAccDynamoDBTable_gsiUpdateNonKeyAttributes
=== RUN   TestAccDynamoDBTable_GsiUpdateNonKeyAttributes_emptyPlan
=== PAUSE TestAccDynamoDBTable_GsiUpdateNonKeyAttributes_emptyPlan
=== RUN   TestAccDynamoDBTable_TTL_enabled
=== PAUSE TestAccDynamoDBTable_TTL_enabled
=== RUN   TestAccDynamoDBTable_TTL_disabled
=== PAUSE TestAccDynamoDBTable_TTL_disabled
=== RUN   TestAccDynamoDBTable_attributeUpdate
=== PAUSE TestAccDynamoDBTable_attributeUpdate
=== RUN   TestAccDynamoDBTable_lsiUpdate
=== PAUSE TestAccDynamoDBTable_lsiUpdate
=== RUN   TestAccDynamoDBTable_attributeUpdateValidation
=== PAUSE TestAccDynamoDBTable_attributeUpdateValidation
=== RUN   TestAccDynamoDBTable_encryption
=== PAUSE TestAccDynamoDBTable_encryption
=== RUN   TestAccDynamoDBTable_Replica_multiple
=== PAUSE TestAccDynamoDBTable_Replica_multiple
=== RUN   TestAccDynamoDBTable_Replica_single
=== PAUSE TestAccDynamoDBTable_Replica_single
=== RUN   TestAccDynamoDBTable_Replica_singleWithCMK
=== PAUSE TestAccDynamoDBTable_Replica_singleWithCMK
=== RUN   TestAccDynamoDBTable_Replica_pitr
=== PAUSE TestAccDynamoDBTable_Replica_pitr
=== RUN   TestAccDynamoDBTable_Replica_tagsOneOfTwo
=== PAUSE TestAccDynamoDBTable_Replica_tagsOneOfTwo
=== RUN   TestAccDynamoDBTable_Replica_tagsTwoOfTwo
=== PAUSE TestAccDynamoDBTable_Replica_tagsTwoOfTwo
=== RUN   TestAccDynamoDBTable_tableClassInfrequentAccess
=== PAUSE TestAccDynamoDBTable_tableClassInfrequentAccess
=== RUN   TestAccDynamoDBTable_backupEncryption
=== PAUSE TestAccDynamoDBTable_backupEncryption
=== RUN   TestAccDynamoDBTable_backup_overrideEncryption
=== PAUSE TestAccDynamoDBTable_backup_overrideEncryption
=== CONT  TestAccDynamoDBTable_basic
=== CONT  TestAccDynamoDBTable_gsiUpdateNonKeyAttributes
=== CONT  TestAccDynamoDBTable_Replica_single
--- PASS: TestAccDynamoDBTable_basic (27.23s)
=== CONT  TestAccDynamoDBTable_Replica_tagsTwoOfTwo
--- PASS: TestAccDynamoDBTable_Replica_tagsTwoOfTwo (292.00s)
=== CONT  TestAccDynamoDBTable_backup_overrideEncryption
--- PASS: TestAccDynamoDBTable_Replica_single (371.02s)
=== CONT  TestAccDynamoDBTable_backupEncryption
--- PASS: TestAccDynamoDBTable_gsiUpdateNonKeyAttributes (480.94s)
=== CONT  TestAccDynamoDBTable_tableClassInfrequentAccess
--- PASS: TestAccDynamoDBTable_tableClassInfrequentAccess (46.90s)
=== CONT  TestAccDynamoDBTable_BillingModeGSI_payPerRequestToProvisioned
--- PASS: TestAccDynamoDBTable_BillingModeGSI_payPerRequestToProvisioned (60.19s)
=== CONT  TestAccDynamoDBTable_lsiNonKeyAttributes
--- PASS: TestAccDynamoDBTable_lsiNonKeyAttributes (23.91s)
=== CONT  TestAccDynamoDBTable_gsiUpdateOtherAttributes
--- PASS: TestAccDynamoDBTable_backup_overrideEncryption (867.12s)
=== CONT  TestAccDynamoDBTable_gsiUpdateCapacity
--- PASS: TestAccDynamoDBTable_gsiUpdateCapacity (46.29s)
=== CONT  TestAccDynamoDBTable_tags
--- PASS: TestAccDynamoDBTable_backupEncryption (862.44s)
=== CONT  TestAccDynamoDBTable_streamSpecificationValidation
--- PASS: TestAccDynamoDBTable_streamSpecificationValidation (1.80s)
=== CONT  TestAccDynamoDBTable_streamSpecification
--- PASS: TestAccDynamoDBTable_tags (43.04s)
=== CONT  TestAccDynamoDBTable_BillingModeGSI_provisionedToPayPerRequest
--- PASS: TestAccDynamoDBTable_streamSpecification (42.34s)
=== CONT  TestAccDynamoDBTable_Replica_pitr
--- PASS: TestAccDynamoDBTable_gsiUpdateOtherAttributes (736.23s)
=== CONT  TestAccDynamoDBTable_Replica_tagsOneOfTwo
--- PASS: TestAccDynamoDBTable_Replica_tagsOneOfTwo (269.71s)
=== CONT  TestAccDynamoDBTable_BillingMode_payPerRequestToProvisioned
--- PASS: TestAccDynamoDBTable_Replica_pitr (348.41s)
=== CONT  TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequestIgnoreChanges
--- PASS: TestAccDynamoDBTable_BillingMode_payPerRequestToProvisioned (44.83s)
=== CONT  TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequest
--- PASS: TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequest (386.66s)
=== CONT  TestAccDynamoDBTable_BillingMode_payPerRequestToProvisionedIgnoreChanges
--- PASS: TestAccDynamoDBTable_BillingMode_payPerRequestToProvisionedIgnoreChanges (44.18s)
=== CONT  TestAccDynamoDBTable_extended
--- PASS: TestAccDynamoDBTable_BillingModeGSI_provisionedToPayPerRequest (841.39s)
=== CONT  TestAccDynamoDBTable_enablePITR
--- PASS: TestAccDynamoDBTable_enablePITR (64.14s)
=== CONT  TestAccDynamoDBTable_TTL_disabled
--- PASS: TestAccDynamoDBTable_TTL_disabled (40.99s)
=== CONT  TestAccDynamoDBTable_attributeUpdate
--- PASS: TestAccDynamoDBTable_BillingMode_provisionedToPayPerRequestIgnoreChanges (868.43s)
=== CONT  TestAccDynamoDBTable_Disappears_payPerRequestWithGSI
--- PASS: TestAccDynamoDBTable_Disappears_payPerRequestWithGSI (69.80s)
=== CONT  TestAccDynamoDBTable_disappears
--- PASS: TestAccDynamoDBTable_disappears (22.51s)
=== CONT  TestAccDynamoDBTable_lsiUpdate
--- PASS: TestAccDynamoDBTable_extended (528.79s)
=== CONT  TestAccDynamoDBTable_TTL_enabled
--- PASS: TestAccDynamoDBTable_lsiUpdate (52.27s)
=== CONT  TestAccDynamoDBTable_Replica_multiple
--- PASS: TestAccDynamoDBTable_TTL_enabled (29.21s)
=== CONT  TestAccDynamoDBTable_encryption
--- PASS: TestAccDynamoDBTable_encryption (101.35s)
=== CONT  TestAccDynamoDBTable_GsiUpdateNonKeyAttributes_emptyPlan
--- PASS: TestAccDynamoDBTable_GsiUpdateNonKeyAttributes_emptyPlan (40.18s)
=== CONT  TestAccDynamoDBTable_attributeUpdateValidation
--- PASS: TestAccDynamoDBTable_attributeUpdateValidation (4.55s)
=== CONT  TestAccDynamoDBTable_Replica_singleWithCMK
--- PASS: TestAccDynamoDBTable_Replica_singleWithCMK (213.36s)
--- PASS: TestAccDynamoDBTable_attributeUpdate (846.74s)
--- PASS: TestAccDynamoDBTable_Replica_multiple (612.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	3256.232s

@YakDriver YakDriver merged commit 5c0a34a into main Jul 19, 2022
@YakDriver YakDriver deleted the f-dynamodb-replicate-tags branch July 19, 2022 15:01
@github-actions github-actions bot added this to the v4.23.0 milestone Jul 19, 2022
github-actions bot pushed a commit that referenced this pull request Jul 19, 2022
Update CHANGELOG.md for #25866
1cf03db
@github-actions
Copy link

This functionality has been released in v4.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@huzaifa-binafzal huzaifa-binafzal mentioned this pull request Jul 26, 2022
Closed
This was referenced Aug 11, 2022
Merged
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/apigateway Issues and PRs that pertain to the apigateway service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/codebuild Issues and PRs that pertain to the codebuild service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/ec2 Issues and PRs that pertain to the ec2 service. service/fsx Issues and PRs that pertain to the fsx service. service/iam Issues and PRs that pertain to the iam service. service/memorydb Issues and PRs that pertain to the memorydb service. service/networkfirewall Issues and PRs that pertain to the networkfirewall service. service/rds Issues and PRs that pertain to the rds service. service/vpc Issues and PRs that pertain to the vpc service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.23.0
Development

Successfully merging this pull request may close these issues.

DynamoDB Global Table Version 2 Replicas don't propagate tags to replica
2 participants
@YakDriver @ewbankkit