Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rds): add support for IPV6 for RDS subnet groups #24822 #26185

Merged
merged 32 commits into from
Aug 25, 2022
Merged

feat(rds): add support for IPV6 for RDS subnet groups #24822 #26185

merged 32 commits into from
Aug 25, 2022

Conversation

taufort
Copy link
Contributor

@taufort taufort commented Aug 9, 2022 •
edited by ewbankkit
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #24822.

Output from acceptance testing:

$ make testacc TESTS=TestAccRDSSubnetGroupDataSource PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSSubnetGroupDataSource'  -timeout 180m
=== RUN   TestAccRDSSubnetGroupDataSource_basic
=== PAUSE TestAccRDSSubnetGroupDataSource_basic
=== RUN   TestAccRDSSubnetGroupDataSource_nonexistent
=== PAUSE TestAccRDSSubnetGroupDataSource_nonexistent
=== CONT  TestAccRDSSubnetGroupDataSource_basic
=== CONT  TestAccRDSSubnetGroupDataSource_nonexistent
--- PASS: TestAccRDSSubnetGroupDataSource_nonexistent (8.29s)
--- PASS: TestAccRDSSubnetGroupDataSource_basic (46.18s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	46.237s

$ make testacc TESTS=TestAccRDSSubnetGroup PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSSubnetGroup'  -timeout 180m
=== RUN   TestAccRDSSubnetGroupDataSource_basic
=== PAUSE TestAccRDSSubnetGroupDataSource_basic
=== RUN   TestAccRDSSubnetGroupDataSource_nonexistent
=== PAUSE TestAccRDSSubnetGroupDataSource_nonexistent
=== RUN   TestAccRDSSubnetGroup_basic
=== PAUSE TestAccRDSSubnetGroup_basic
=== RUN   TestAccRDSSubnetGroup_basicDualNetwork
=== PAUSE TestAccRDSSubnetGroup_basicDualNetwork
=== RUN   TestAccRDSSubnetGroup_namePrefix
=== PAUSE TestAccRDSSubnetGroup_namePrefix
=== RUN   TestAccRDSSubnetGroup_generatedName
=== PAUSE TestAccRDSSubnetGroup_generatedName
=== RUN   TestAccRDSSubnetGroup_withUndocumentedCharacters
=== PAUSE TestAccRDSSubnetGroup_withUndocumentedCharacters
=== RUN   TestAccRDSSubnetGroup_updateDescription
=== PAUSE TestAccRDSSubnetGroup_updateDescription
=== CONT  TestAccRDSSubnetGroupDataSource_basic
=== CONT  TestAccRDSSubnetGroup_namePrefix
=== CONT  TestAccRDSSubnetGroup_basic
=== CONT  TestAccRDSSubnetGroup_basicDualNetwork
=== CONT  TestAccRDSSubnetGroup_updateDescription
=== CONT  TestAccRDSSubnetGroup_withUndocumentedCharacters
=== CONT  TestAccRDSSubnetGroup_generatedName
=== CONT  TestAccRDSSubnetGroupDataSource_nonexistent
--- PASS: TestAccRDSSubnetGroupDataSource_nonexistent (9.45s)
--- PASS: TestAccRDSSubnetGroup_namePrefix (49.44s)
--- PASS: TestAccRDSSubnetGroup_generatedName (49.47s)
--- PASS: TestAccRDSSubnetGroupDataSource_basic (49.96s)
--- PASS: TestAccRDSSubnetGroup_basic (54.57s)
--- PASS: TestAccRDSSubnetGroup_withUndocumentedCharacters (54.91s)
--- PASS: TestAccRDSSubnetGroup_basicDualNetwork (75.66s)
--- PASS: TestAccRDSSubnetGroup_updateDescription (94.47s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	94.557s

$ make testacc TESTS=TestAccRDSInstance_ReplicateSourceDB_networkType PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSInstance_ReplicateSourceDB_networkType'  -timeout 180m
=== RUN   TestAccRDSInstance_ReplicateSourceDB_networkType
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_networkType
=== CONT  TestAccRDSInstance_ReplicateSourceDB_networkType
--- PASS: TestAccRDSInstance_ReplicateSourceDB_networkType (1613.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1613.717s

@github-actions github-actions bot added service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 9, 2022
github-actions[bot]
github-actions bot reviewed Aug 9, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @taufort 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Aug 10, 2022
ewbankkit added 20 commits August 24, 2022 14:44
@ewbankkit
Merge branch 'main' into HEAD
180657d
@ewbankkit
Add CHANGELOG entries.
7ce4cc4
@ewbankkit
r/aws_db_subnet_group: Tidy up resource Create.
b943e0b
@ewbankkit
r/aws_db_subnet_group: Tidy up resource Read.
cd9ce8e
@ewbankkit
r/aws_db_subnet_group: Tidy up resource Update.
e00e777
@ewbankkit
r/aws_db_subnet_group: Tidy up resource Delete.
b7147b4
@ewbankkit
r/aws_db_subnet_group: Tidy up 'TestAccRDSSubnetGroup_basic'.
c7d8562 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccRDSSubnetGroup_basic' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSSubnetGroup_basic -timeout 180m
=== RUN   TestAccRDSSubnetGroup_basic
=== PAUSE TestAccRDSSubnetGroup_basic
=== CONT  TestAccRDSSubnetGroup_basic
--- PASS: TestAccRDSSubnetGroup_basic (25.77s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	29.721s
@ewbankkit
r/aws_db_subnet_group: Tidy up 'TestAccRDSSubnetGroup_namePrefix'.
d68aa37 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccRDSSubnetGroup_namePrefix' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSSubnetGroup_namePrefix -timeout 180m
=== RUN   TestAccRDSSubnetGroup_namePrefix
=== PAUSE TestAccRDSSubnetGroup_namePrefix
=== CONT  TestAccRDSSubnetGroup_namePrefix
--- PASS: TestAccRDSSubnetGroup_namePrefix (24.47s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	28.710s
@ewbankkit
r/aws_db_subnet_group: Tidy up 'TestAccRDSSubnetGroup_nameGenerated'.
dc1b6ca 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccRDSSubnetGroup_nameGenerated' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSSubnetGroup_nameGenerated -timeout 180m
=== RUN   TestAccRDSSubnetGroup_nameGenerated
=== PAUSE TestAccRDSSubnetGroup_nameGenerated
=== CONT  TestAccRDSSubnetGroup_nameGenerated
--- PASS: TestAccRDSSubnetGroup_nameGenerated (22.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	26.824s
@ewbankkit
r/aws_db_subnet_group: Add 'TestAccRDSSubnetGroup_disappears'.
7eb73d0 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccRDSSubnetGroup_disappears' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSSubnetGroup_disappears -timeout 180m
=== RUN   TestAccRDSSubnetGroup_disappears
=== PAUSE TestAccRDSSubnetGroup_disappears
=== CONT  TestAccRDSSubnetGroup_disappears
--- PASS: TestAccRDSSubnetGroup_disappears (22.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	26.677s
@ewbankkit
r/aws_db_subnet_group: Add 'TestAccRDSSubnetGroup_tags'.
5b01a6d 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccRDSSubnetGroup_tags' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSSubnetGroup_tags -timeout 180m
=== RUN   TestAccRDSSubnetGroup_tags
=== PAUSE TestAccRDSSubnetGroup_tags
=== CONT  TestAccRDSSubnetGroup_tags
--- PASS: TestAccRDSSubnetGroup_tags (53.93s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	57.831s
@ewbankkit
r/aws_db_subnet_group: Tidy up 'TestAccRDSSubnetGroup_updateDescripti…
8e0f6d4 
…on'.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccRDSSubnetGroup_updateDescription' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSSubnetGroup_updateDescription -timeout 180m
=== RUN   TestAccRDSSubnetGroup_updateDescription
=== PAUSE TestAccRDSSubnetGroup_updateDescription
=== CONT  TestAccRDSSubnetGroup_updateDescription
--- PASS: TestAccRDSSubnetGroup_updateDescription (42.62s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	46.481s
@ewbankkit
r/aws_db_subnet_group: Add 'TestAccRDSSubnetGroup_updateSubnets'.
936bb5f 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccRDSSubnetGroup_updateSubnets' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSSubnetGroup_updateSubnets -timeout 180m
=== RUN   TestAccRDSSubnetGroup_updateSubnets
=== PAUSE TestAccRDSSubnetGroup_updateSubnets
=== CONT  TestAccRDSSubnetGroup_updateSubnets
--- PASS: TestAccRDSSubnetGroup_updateSubnets (45.16s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	49.065s
@ewbankkit
r/aws_db_subnet_group: Tidy up 'TestAccRDSSubnetGroup_dualStack'.
efea55c 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccRDSSubnetGroup_dualStack' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSSubnetGroup_dualStack -timeout 180m
=== RUN   TestAccRDSSubnetGroup_dualStack
=== PAUSE TestAccRDSSubnetGroup_dualStack
=== CONT  TestAccRDSSubnetGroup_dualStack
--- PASS: TestAccRDSSubnetGroup_dualStack (43.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	47.297s
@ewbankkit
d/aws_db_subnet_group: Tidy up.
e6387ef
@ewbankkit
d/aws_db_subnet_group: Tidy up 'TestAccRDSSubnetGroupDataSource_basic'.
050fe8a 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccRDSSubnetGroupDataSource_basic' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSSubnetGroupDataSource_basic -timeout 180m
=== RUN   TestAccRDSSubnetGroupDataSource_basic
=== PAUSE TestAccRDSSubnetGroupDataSource_basic
=== CONT  TestAccRDSSubnetGroupDataSource_basic
--- PASS: TestAccRDSSubnetGroupDataSource_basic (23.33s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	27.253s
@ewbankkit
Additional CHANGELOG entry.
40ac712
@ewbankkit
d/aws_rds_orderable_db_instance: Tweak error messages.
668a879
@ewbankkit
r/aws_db_instance: Tidy up 'TestAccRDSInstance_MSSQL_tz'.
f585559 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccRDSInstance_MSSQL_tz' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSInstance_MSSQL_tz -timeout 180m
=== RUN   TestAccRDSInstance_MSSQL_tz
=== PAUSE TestAccRDSInstance_MSSQL_tz
=== CONT  TestAccRDSInstance_MSSQL_tz
--- PASS: TestAccRDSInstance_MSSQL_tz (1963.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1967.579s
@ewbankkit
r/aws_db_instance: Tidy up 'TestAccRDSInstance_DBSubnetGroupName_vpcS…
ab87da6 
…ecurityGroupIDs', 'TestAccRDSInstance_dbSubnetGroupName', 'TestAccRDSInstance_cloudWatchLogsExport' and 'TestAccRDSInstance_EnabledCloudWatchLogsExports_mySQL'.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccRDSInstance_DBSubnetGroupName_vpcSecurityGroupIDs\|TestAccRDSInstance_dbSubnetGroupName\|TestAccRDSInstance_cloudWatchLogsExport\|TestAccRDSInstance_EnabledCloudWatchLogsExports_mySQL' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSInstance_DBSubnetGroupName_vpcSecurityGroupIDs\|TestAccRDSInstance_dbSubnetGroupName\|TestAccRDSInstance_cloudWatchLogsExport\|TestAccRDSInstance_EnabledCloudWatchLogsExports_mySQL -timeout 180m
=== RUN   TestAccRDSInstance_dbSubnetGroupName
=== PAUSE TestAccRDSInstance_dbSubnetGroupName
=== RUN   TestAccRDSInstance_DBSubnetGroupName_vpcSecurityGroupIDs
=== PAUSE TestAccRDSInstance_DBSubnetGroupName_vpcSecurityGroupIDs
=== RUN   TestAccRDSInstance_cloudWatchLogsExport
=== PAUSE TestAccRDSInstance_cloudWatchLogsExport
=== RUN   TestAccRDSInstance_EnabledCloudWatchLogsExports_mySQL
=== PAUSE TestAccRDSInstance_EnabledCloudWatchLogsExports_mySQL
=== CONT  TestAccRDSInstance_dbSubnetGroupName
=== CONT  TestAccRDSInstance_cloudWatchLogsExport
--- PASS: TestAccRDSInstance_dbSubnetGroupName (523.11s)
=== CONT  TestAccRDSInstance_DBSubnetGroupName_vpcSecurityGroupIDs
--- PASS: TestAccRDSInstance_cloudWatchLogsExport (642.05s)
=== CONT  TestAccRDSInstance_EnabledCloudWatchLogsExports_mySQL
--- PASS: TestAccRDSInstance_DBSubnetGroupName_vpcSecurityGroupIDs (464.91s)
--- PASS: TestAccRDSInstance_EnabledCloudWatchLogsExports_mySQL (964.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1610.730s
@ewbankkit
r/aws_db_instance: Tidy up 'TestAccRDSInstance_SnapshotIdentifier_dbS…
5eea5f8 
…ubnetGroupName' and 'TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameVPCSecurityGroupIDs'.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupName\|TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameVPCSecurityGroupIDs' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupName\|TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameVPCSecurityGroupIDs -timeout 180m
=== RUN   TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupName
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupName
=== RUN   TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameRAMShared
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameRAMShared
=== RUN   TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameVPCSecurityGroupIDs
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameVPCSecurityGroupIDs
=== CONT  TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupName
=== CONT  TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameVPCSecurityGroupIDs
--- PASS: TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameVPCSecurityGroupIDs (948.39s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameRAMShared
    acctest.go:644: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameRAMShared (0.00s)
--- PASS: TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupName (1122.32s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1126.783s
@ewbankkit
r/aws_db_instance: Tidy up 'TestAccRDSInstance_coIPEnabled'.
1b51df2 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccRDSInstance_coIPEnabled\|TestAccRDSInstance_CoIPEnabled_' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSInstance_coIPEnabled\|TestAccRDSInstance_CoIPEnabled_ -timeout 180m
=== RUN   TestAccRDSInstance_coIPEnabled
=== PAUSE TestAccRDSInstance_coIPEnabled
=== RUN   TestAccRDSInstance_CoIPEnabled_disabledToEnabled
=== PAUSE TestAccRDSInstance_CoIPEnabled_disabledToEnabled
=== RUN   TestAccRDSInstance_CoIPEnabled_enabledToDisabled
=== PAUSE TestAccRDSInstance_CoIPEnabled_enabledToDisabled
=== RUN   TestAccRDSInstance_CoIPEnabled_restoreToPointInTime
=== PAUSE TestAccRDSInstance_CoIPEnabled_restoreToPointInTime
=== RUN   TestAccRDSInstance_CoIPEnabled_snapshotIdentifier
=== PAUSE TestAccRDSInstance_CoIPEnabled_snapshotIdentifier
=== CONT  TestAccRDSInstance_coIPEnabled
=== CONT  TestAccRDSInstance_CoIPEnabled_enabledToDisabled
=== CONT  TestAccRDSInstance_coIPEnabled
    acctest.go:1346: skipping since no Outposts found
--- SKIP: TestAccRDSInstance_coIPEnabled (1.36s)
=== CONT  TestAccRDSInstance_CoIPEnabled_snapshotIdentifier
=== CONT  TestAccRDSInstance_CoIPEnabled_enabledToDisabled
    acctest.go:1346: skipping since no Outposts found
--- SKIP: TestAccRDSInstance_CoIPEnabled_enabledToDisabled (1.43s)
=== CONT  TestAccRDSInstance_CoIPEnabled_disabledToEnabled
=== CONT  TestAccRDSInstance_CoIPEnabled_snapshotIdentifier
    acctest.go:1346: skipping since no Outposts found
--- SKIP: TestAccRDSInstance_CoIPEnabled_snapshotIdentifier (0.18s)
=== CONT  TestAccRDSInstance_CoIPEnabled_restoreToPointInTime
=== CONT  TestAccRDSInstance_CoIPEnabled_disabledToEnabled
    acctest.go:1346: skipping since no Outposts found
--- SKIP: TestAccRDSInstance_CoIPEnabled_disabledToEnabled (0.20s)
=== CONT  TestAccRDSInstance_CoIPEnabled_restoreToPointInTime
    acctest.go:1346: skipping since no Outposts found
--- SKIP: TestAccRDSInstance_CoIPEnabled_restoreToPointInTime (0.16s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	12.436s
@ewbankkit
r/aws_db_instance: Tidy up 'TestAccRDSInstance_ReplicateSourceDB_netw…
5b375a5 
…orkType'.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccRDSInstance_ReplicateSourceDB_networkType' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSInstance_ReplicateSourceDB_networkType -timeout 180m
=== RUN   TestAccRDSInstance_ReplicateSourceDB_networkType
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_networkType
=== CONT  TestAccRDSInstance_ReplicateSourceDB_networkType
    instance_test.go:1556: Step 2/2 error: Check failed: Check 4/4 error: aws_db_instance.test: Attribute 'network_type' expected "DUAL", got "IPV4"
--- FAIL: TestAccRDSInstance_ReplicateSourceDB_networkType (1550.14s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1554.676s
FAIL
make: *** [testacc] Error 1
@ewbankkit
d/aws_db_instance: Alphabetize attributes.
49e5314
@ewbankkit
d/aws_db_instance: Tidy up.
09d078c
@ewbankkit
d/aws_db_instance: Add 'network_type' attribute.
12bf78d
@ewbankkit
d/aws_db_instance: Tidy up 'TestAccRDSInstanceDataSource_basic'.
6dd1625 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccRDSInstanceDataSource_' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSInstanceDataSource_ -timeout 180m
=== RUN   TestAccRDSInstanceDataSource_basic
=== PAUSE TestAccRDSInstanceDataSource_basic
=== CONT  TestAccRDSInstanceDataSource_basic
--- PASS: TestAccRDSInstanceDataSource_basic (552.94s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	556.921s
@ewbankkit
Update documentation.
44877e0
@ewbankkit ewbankkit marked this pull request as ready for review August 25, 2022 17:56
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Aug 25, 2022
@ewbankkit
Fix terrafmt error.
e6c7f13
@ewbankkit
r/aws_db_instance: Add 'TestAccRDSInstance_networkType'.
e25a80d 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccRDSInstance_networkType\|TestAccRDSInstance_ReplicateSourceDB_networkType' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSInstance_networkType\|TestAccRDSInstance_ReplicateSourceDB_networkType -timeout 180m
=== RUN   TestAccRDSInstance_networkType
=== PAUSE TestAccRDSInstance_networkType
=== RUN   TestAccRDSInstance_ReplicateSourceDB_networkType
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_networkType
=== CONT  TestAccRDSInstance_networkType
=== CONT  TestAccRDSInstance_ReplicateSourceDB_networkType
--- PASS: TestAccRDSInstance_networkType (874.92s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_networkType (1591.78s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1595.484s
ewbankkit
ewbankkit approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSInstance_networkType\|TestAccRDSInstance_ReplicateSourceDB_networkType' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSInstance_networkType\|TestAccRDSInstance_ReplicateSourceDB_networkType -timeout 180m
=== RUN   TestAccRDSInstance_networkType
=== PAUSE TestAccRDSInstance_networkType
=== RUN   TestAccRDSInstance_ReplicateSourceDB_networkType
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_networkType
=== CONT  TestAccRDSInstance_networkType
=== CONT  TestAccRDSInstance_ReplicateSourceDB_networkType
--- PASS: TestAccRDSInstance_networkType (874.92s)
--- PASS: TestAccRDSInstance_ReplicateSourceDB_networkType (1591.78s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1595.484s
% make testacc TESTARGS='-run=TestAccRDSSubnetGroup' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSSubnetGroup -timeout 180m
=== RUN   TestAccRDSSubnetGroupDataSource_basic
=== PAUSE TestAccRDSSubnetGroupDataSource_basic
=== RUN   TestAccRDSSubnetGroup_basic
=== PAUSE TestAccRDSSubnetGroup_basic
=== RUN   TestAccRDSSubnetGroup_disappears
=== PAUSE TestAccRDSSubnetGroup_disappears
=== RUN   TestAccRDSSubnetGroup_nameGenerated
=== PAUSE TestAccRDSSubnetGroup_nameGenerated
=== RUN   TestAccRDSSubnetGroup_namePrefix
=== PAUSE TestAccRDSSubnetGroup_namePrefix
=== RUN   TestAccRDSSubnetGroup_tags
=== PAUSE TestAccRDSSubnetGroup_tags
=== RUN   TestAccRDSSubnetGroup_dualStack
=== PAUSE TestAccRDSSubnetGroup_dualStack
=== RUN   TestAccRDSSubnetGroup_updateDescription
=== PAUSE TestAccRDSSubnetGroup_updateDescription
=== RUN   TestAccRDSSubnetGroup_updateSubnets
=== PAUSE TestAccRDSSubnetGroup_updateSubnets
=== CONT  TestAccRDSSubnetGroupDataSource_basic
=== CONT  TestAccRDSSubnetGroup_tags
--- PASS: TestAccRDSSubnetGroupDataSource_basic (23.79s)
=== CONT  TestAccRDSSubnetGroup_updateDescription
--- PASS: TestAccRDSSubnetGroup_tags (57.37s)
=== CONT  TestAccRDSSubnetGroup_updateSubnets
--- PASS: TestAccRDSSubnetGroup_updateDescription (38.79s)
=== CONT  TestAccRDSSubnetGroup_nameGenerated
--- PASS: TestAccRDSSubnetGroup_nameGenerated (24.73s)
=== CONT  TestAccRDSSubnetGroup_namePrefix
--- PASS: TestAccRDSSubnetGroup_updateSubnets (42.36s)
=== CONT  TestAccRDSSubnetGroup_dualStack
--- PASS: TestAccRDSSubnetGroup_namePrefix (23.95s)
=== CONT  TestAccRDSSubnetGroup_disappears
--- PASS: TestAccRDSSubnetGroup_disappears (20.55s)
=== CONT  TestAccRDSSubnetGroup_basic
--- PASS: TestAccRDSSubnetGroup_dualStack (43.90s)
--- PASS: TestAccRDSSubnetGroup_basic (24.95s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	160.691s
% make testacc TESTARGS='-run=TestAccRDSOrderableInstanceDataSource_' PKG=rds ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 2  -run=TestAccRDSOrderableInstanceDataSource_ -timeout 180m
=== RUN   TestAccRDSOrderableInstanceDataSource_basic
=== PAUSE TestAccRDSOrderableInstanceDataSource_basic
=== RUN   TestAccRDSOrderableInstanceDataSource_preferredClass
=== PAUSE TestAccRDSOrderableInstanceDataSource_preferredClass
=== RUN   TestAccRDSOrderableInstanceDataSource_preferredVersion
=== PAUSE TestAccRDSOrderableInstanceDataSource_preferredVersion
=== RUN   TestAccRDSOrderableInstanceDataSource_preferredClassAndVersion
=== PAUSE TestAccRDSOrderableInstanceDataSource_preferredClassAndVersion
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsEnhancedMonitoring
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsEnhancedMonitoring
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsIAMDatabaseAuthentication
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsIAMDatabaseAuthentication
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsIops
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsIops
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsKerberosAuthentication
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsKerberosAuthentication
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsPerformanceInsights
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsPerformanceInsights
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsStorageAutoScaling
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsStorageAutoScaling
=== RUN   TestAccRDSOrderableInstanceDataSource_supportsStorageEncryption
=== PAUSE TestAccRDSOrderableInstanceDataSource_supportsStorageEncryption
=== CONT  TestAccRDSOrderableInstanceDataSource_basic
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsIops
--- PASS: TestAccRDSOrderableInstanceDataSource_basic (24.22s)
=== CONT  TestAccRDSOrderableInstanceDataSource_preferredClassAndVersion
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsIops (119.97s)
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsIAMDatabaseAuthentication
--- PASS: TestAccRDSOrderableInstanceDataSource_preferredClassAndVersion (131.91s)
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsEnhancedMonitoring
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsIAMDatabaseAuthentication (139.84s)
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsStorageAutoScaling
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsEnhancedMonitoring (129.30s)
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsStorageEncryption
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsStorageAutoScaling (131.10s)
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsPerformanceInsights
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsStorageEncryption (125.17s)
=== CONT  TestAccRDSOrderableInstanceDataSource_supportsKerberosAuthentication
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsPerformanceInsights (144.34s)
=== CONT  TestAccRDSOrderableInstanceDataSource_preferredVersion
--- PASS: TestAccRDSOrderableInstanceDataSource_supportsKerberosAuthentication (157.41s)
=== CONT  TestAccRDSOrderableInstanceDataSource_preferredClass
--- PASS: TestAccRDSOrderableInstanceDataSource_preferredClass (28.56s)
--- PASS: TestAccRDSOrderableInstanceDataSource_preferredVersion (136.59s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	675.584s

@ewbankkit ewbankkit merged commit b122f84 into hashicorp:main Aug 25, 2022
@github-actions github-actions bot added this to the v4.28.0 milestone Aug 25, 2022
@taufort taufort deleted the f-rds-ipv6-support branch August 26, 2022 07:45
@taufort
Copy link
Contributor Author

taufort commented Aug 26, 2022

Thanks a lot for finishing the work I started @ewbankkit. I could not spend as much time as I would have liked on this issue.

@github-actions
Copy link

This functionality has been released in v4.28.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.28.0
Development

Successfully merging this pull request may close these issues.

IPv6 Support for RDS DB Instances
2 participants
@taufort @ewbankkit