r/aws_networkmanager_vpc_attachment

[drewmullen]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

New or Affected Resource(s)

• aws_networkmanager_vpc_attachment

Potential Terraform Configuration

resource "aws_networkmanager_vpc_attachment" "example" {
  subnet_arns             = [aws_subnet.example.arn]
  core_network_id         = awscc_networkmanager_core_network.example.id
  vpc_arn                 = aws_vpc.example.arn

  options {
    ipv6_support =  false
  }

  tags = {
    "Name" : "my-vpc",
    "segment": "example"
  }
}

References

• awscc_networkmanager_vpc_attachment tries to update core_network_arn attribute in-place and hangs terraform-provider-awscc#586
• AWS Cloud WAN #25835

[github-actions]

This functionality has been released in v4.27.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[Hemant40]

Hi Folks,

i am testing this new feature added regarding to (#26227). i can now accept the VPC attachment with the new provided "aws_networkmanager_attachment_accepter" module.
But i cannot accept other kind of attachments with this module, like site_to_site_vpn kind of attachments.
Please suggest.

In my opinion, the module "aws_networkmanager_attachment_accepter" should accept all kind of attachments regardless from its attachment type (VPC/site_to_site) etc.

Code:
resource "aws_networkmanager_attachment_accepter" "vpn_acc" {
attachment_id = awscc_networkmanager_site_to_site_vpn_attachment.vpn_attachment.id
attachment_type = awscc_networkmanager_site_to_site_vpn_attachment.vpn_attachment.attachment_type
}

Error details:
╷
│ Error: expected attachment_type to be one of [VPC], got SITE_TO_SITE_VPN
│
│ with aws_networkmanager_attachment_accepter.vpn_acc,
│ on cloud_wan.tf line 63, in resource "aws_networkmanager_attachment_accepter" "vpn_acc":
│ 63: attachment_type = awscc_networkmanager_site_to_site_vpn_attachment.vpn_attachment.attachment_type

[drewmullen]

Hi,

In my opinion, the module "aws_networkmanager_attachment_accepter" should accept all kind of attachments

Yep, totally agree:

https://github.com/hashicorp/terraform-provider-aws/blob/main/internal/service/networkmanager/attachment_accepter.go#L40-L49

Adding each type is not as simple as just enabling/disabling. support has to be written in, tests included, dependency resources created. I believe most of these gaps are being worked in other issues

[Hemant40]

Hi,

Thanks for revert. i have created a separate issue (#26420) to add the site_to_site_vpn attachment as well in the "aws_networkmanager_attachment_accepter" module.

Could you please let us know regarding the estimate time for adding this site_to_site_vpn attachment feature.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.