-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppFlow trigger start date being incorrectly set #26289
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @camro 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAppFlowFlow_' PKG=appflow ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appflow/... -v -count 1 -parallel 2 -run=TestAccAppFlowFlow_ -timeout 180m
=== RUN TestAccAppFlowFlow_basic
=== PAUSE TestAccAppFlowFlow_basic
=== RUN TestAccAppFlowFlow_update
=== PAUSE TestAccAppFlowFlow_update
=== RUN TestAccAppFlowFlow_TaskProperties
=== PAUSE TestAccAppFlowFlow_TaskProperties
=== RUN TestAccAppFlowFlow_tags
=== PAUSE TestAccAppFlowFlow_tags
=== RUN TestAccAppFlowFlow_disappears
=== PAUSE TestAccAppFlowFlow_disappears
=== CONT TestAccAppFlowFlow_basic
=== CONT TestAccAppFlowFlow_tags
--- PASS: TestAccAppFlowFlow_basic (28.65s)
=== CONT TestAccAppFlowFlow_TaskProperties
--- PASS: TestAccAppFlowFlow_TaskProperties (23.47s)
=== CONT TestAccAppFlowFlow_disappears
--- PASS: TestAccAppFlowFlow_tags (66.69s)
=== CONT TestAccAppFlowFlow_update
--- PASS: TestAccAppFlowFlow_disappears (22.49s)
--- PASS: TestAccAppFlowFlow_update (41.61s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/appflow 112.026s
…est failed due to:[TriggerProps is not required for ONDEMAND Trigger Type]'.
@camro Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.27.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
When setting up an AppFlow with a Scheduled trigger and setting the
schedule_start_time
value, it actually sets thescheduled_end_time
value and the app flow is not activeeg.
input
output
![image](https://user-images.githubusercontent.com/785319/184475751-e61117be-27ed-4494-9388-97afe9c77e90.png)