Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_location_tracker_association: new data source #26404

Merged

Conversation

kamilturek
Copy link
Collaborator

@kamilturek kamilturek commented Aug 20, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #19629.

Output from acceptance testing:

$ make testacc PKG=location TESTS="TestAccLocationTrackerAssociation_|TestAccLocationTrackerAssociationDataSource_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/location/... -v -count 1 -parallel 20 -run='TestAccLocationTrackerAssociation_|TestAccLocationTrackerAssociationDataSource_'  -timeout 180m
=== RUN   TestAccLocationTrackerAssociationDataSource_basic
=== PAUSE TestAccLocationTrackerAssociationDataSource_basic
=== RUN   TestAccLocationTrackerAssociation_basic
=== PAUSE TestAccLocationTrackerAssociation_basic
=== RUN   TestAccLocationTrackerAssociation_disappears
=== PAUSE TestAccLocationTrackerAssociation_disappears
=== CONT  TestAccLocationTrackerAssociationDataSource_basic
=== CONT  TestAccLocationTrackerAssociation_disappears
=== CONT  TestAccLocationTrackerAssociation_basic
--- PASS: TestAccLocationTrackerAssociation_disappears (31.08s)
--- PASS: TestAccLocationTrackerAssociationDataSource_basic (34.37s)
--- PASS: TestAccLocationTrackerAssociation_basic (36.73s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/location	38.430s

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/location Issues and PRs that pertain to the location service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Aug 20, 2022
@kamilturek kamilturek marked this pull request as ready for review August 20, 2022 10:24
@ewbankkit ewbankkit added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 22, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLocationTrackerAssociation' PKG=location ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/location/... -v -count 1 -parallel 3  -run=TestAccLocationTrackerAssociation -timeout 180m
=== RUN   TestAccLocationTrackerAssociationDataSource_basic
=== PAUSE TestAccLocationTrackerAssociationDataSource_basic
=== RUN   TestAccLocationTrackerAssociation_basic
=== PAUSE TestAccLocationTrackerAssociation_basic
=== RUN   TestAccLocationTrackerAssociation_disappears
=== PAUSE TestAccLocationTrackerAssociation_disappears
=== CONT  TestAccLocationTrackerAssociationDataSource_basic
=== CONT  TestAccLocationTrackerAssociation_disappears
=== CONT  TestAccLocationTrackerAssociation_basic
--- PASS: TestAccLocationTrackerAssociation_disappears (18.07s)
--- PASS: TestAccLocationTrackerAssociationDataSource_basic (19.22s)
--- PASS: TestAccLocationTrackerAssociation_basic (21.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/location	25.160s

@ewbankkit
Copy link
Contributor

@kamilturek Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 966d3cb into hashicorp:main Aug 22, 2022
@github-actions github-actions bot added this to the v4.28.0 milestone Aug 22, 2022
@kamilturek kamilturek deleted the f-data-aws-location-tracker-association branch August 22, 2022 15:44
@github-actions
Copy link

This functionality has been released in v4.28.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/location Issues and PRs that pertain to the location service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants