Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISO partition does not support aws_instance disableApiStop argument #26424

Open
adimupltr opened this issue Aug 22, 2022 · 5 comments · Fixed by #26745
Open

ISO partition does not support aws_instance disableApiStop argument #26424

adimupltr opened this issue Aug 22, 2022 · 5 comments · Fixed by #26745
Labels
bug Addresses a defect in current functionality. partition/aws-iso-b Pertains to the aws-iso-b partition. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@adimupltr
Copy link

adimupltr commented Aug 22, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Relates #18593

Terraform CLI and Terraform AWS Provider Version

Terraform CLI 1.2.4
Terraform AWS Provider 4.24.0

Affected Resource(s)

  • aws_instance

Expected Behavior

No error when running terraform plan in the ISO partition.

Actual Behavior

When running terraform plan in a region not supporting the disableApiStop argument.

Error: reading EC2 Instance (redacted) attribute: InvalidParameterValue: Value (disableApiStop) for parameter attribute is invalid. Unknown attribute

Steps to Reproduce

Run terraform plan in an environment with an existing aws_instance resource in a region not supporting disableApiStop (for example us-isob-east-1 )

Important Factoids

It looks like support for the disableApiStop argument was added in 4.20.0 for all regions, however not all regions have this new feature implemented. For example the ISO partition does not support this new feature.
Reference PR: #25185

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/ec2 Issues and PRs that pertain to the ec2 service. labels Aug 22, 2022
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. partition/aws-iso Pertains to the aws-iso partition. partition/aws-iso-b Pertains to the aws-iso-b partition. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 22, 2022
@YakDriver
Copy link
Member

We cannot verify the fix in #26745 actually fixes the issue. If you can report back to let us know, we'd appreciate!

@github-actions github-actions bot added this to the v4.31.0 milestone Sep 9, 2022
@github-actions
Copy link

This functionality has been released in v4.31.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@adimupltr
Copy link
Author

Hey @YakDriver thanks for looking into this issue. I have tested the provider v4.31.0 and the error is still present when running terraform plan. Can you please re-open the issue ?

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2022
@YakDriver YakDriver reopened this Oct 26, 2022
@YakDriver
Copy link
Member

@adimupltr Can you provide any error message or portion of error message? The fix should have worked so it's difficult to know what's going on without being able to repro. Any extra information would help.

@YakDriver YakDriver removed the partition/aws-iso Pertains to the aws-iso partition. label Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. partition/aws-iso-b Pertains to the aws-iso-b partition. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants