Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS MWAA Validation Error Retry - Support Upcoming Service Changes #26429

Closed
dhegberg opened this issue Aug 22, 2022 · 2 comments
Closed

AWS MWAA Validation Error Retry - Support Upcoming Service Changes #26429

dhegberg opened this issue Aug 22, 2022 · 2 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/mwaa Issues and PRs that pertain to the mwaa service.

Comments

@dhegberg
Copy link
Contributor

dhegberg commented Aug 22, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS MWAA is planning on removing an internal retry in the CreateEnvironment API that will require retry on ValidationException as part of the Terraform MWAA Environment create handling.

New or Affected Resource(s)

  • aws_mwaa_environment

Background

  • On the creation of a new execution role there can be a noticeable permission propagation delay in some AWS regions.
  • MWAA CreateEnvironment needs the permissions from that role to complete the CreateEnvironment operation. In the past, MWAA has used internal retries to wait for permissions to propagate.
  • Since the service cannot determine when the missing permissions are the result of propagation delay or a misconfigured execution role, a large number of our customers are subject to the latency from retries even when there is no chance of success. To improve the general customer experience we're planning on removing the retries and immediately returning a ValidationException.
  • Terraform templates that call CreateEnvironment quickly after the execution role is generated may receive a 400 response from the service.
  • Existing environments or accounts with existing execution roles will not be impacted.

Proposal

The Terraform MWAA Environment resource will need to build in a retry on the ValidationException for a period of ~30 seconds to handle the change.

We're looking to minimize potential customer impact by proactively making the change in Terraform before making the service change.

We'd like to make sure the change is in line with Terraform community expectations before we submit a pull request.

@dhegberg dhegberg added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 22, 2022
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/mwaa Issues and PRs that pertain to the mwaa service. labels Aug 22, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Oct 3, 2022
@DrFaust92
Copy link
Collaborator

Closed via #27031

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/mwaa Issues and PRs that pertain to the mwaa service.
Projects
None yet
Development

No branches or pull requests

3 participants