Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_cloudfront_origin_access_control #26508

Merged

Conversation

roberth-k
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #26490

Output from acceptance testing:

$ make testacc TESTS=TestAccCloudFrontOriginAccessControl_ PKG=cloudfront
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run='TestAccCloudFrontOriginAccessControl_'  -timeout 180m
=== RUN   TestAccCloudFrontOriginAccessControl_basic
=== PAUSE TestAccCloudFrontOriginAccessControl_basic
=== RUN   TestAccCloudFrontOriginAccessControl_disappears
=== PAUSE TestAccCloudFrontOriginAccessControl_disappears
=== RUN   TestAccCloudFrontOriginAccessControl_Name
=== PAUSE TestAccCloudFrontOriginAccessControl_Name
=== RUN   TestAccCloudFrontOriginAccessControl_Description
=== PAUSE TestAccCloudFrontOriginAccessControl_Description
=== RUN   TestAccCloudFrontOriginAccessControl_SigningBehavior
=== PAUSE TestAccCloudFrontOriginAccessControl_SigningBehavior
=== CONT  TestAccCloudFrontOriginAccessControl_basic
=== CONT  TestAccCloudFrontOriginAccessControl_Description
=== CONT  TestAccCloudFrontOriginAccessControl_SigningBehavior
=== CONT  TestAccCloudFrontOriginAccessControl_Name
=== CONT  TestAccCloudFrontOriginAccessControl_disappears
--- PASS: TestAccCloudFrontOriginAccessControl_basic (20.17s)
--- PASS: TestAccCloudFrontOriginAccessControl_disappears (22.00s)
--- PASS: TestAccCloudFrontOriginAccessControl_Name (32.95s)
--- PASS: TestAccCloudFrontOriginAccessControl_SigningBehavior (45.49s)
--- PASS: TestAccCloudFrontOriginAccessControl_Description (53.84s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront 55.494s

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudfront Issues and PRs that pertain to the cloudfront service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 27, 2022
@roberth-k roberth-k force-pushed the f-aws_cloudfront_origin_access_control branch from 9bce887 to 0a973dc Compare August 27, 2022 22:43
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Aug 29, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCloudFrontOriginAccessControl_' PKG=cloudfront ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudfront/... -v -count 1 -parallel 2  -run=TestAccCloudFrontOriginAccessControl_ -timeout 180m
=== RUN   TestAccCloudFrontOriginAccessControl_basic
=== PAUSE TestAccCloudFrontOriginAccessControl_basic
=== RUN   TestAccCloudFrontOriginAccessControl_disappears
=== PAUSE TestAccCloudFrontOriginAccessControl_disappears
=== RUN   TestAccCloudFrontOriginAccessControl_Name
=== PAUSE TestAccCloudFrontOriginAccessControl_Name
=== RUN   TestAccCloudFrontOriginAccessControl_Description
=== PAUSE TestAccCloudFrontOriginAccessControl_Description
=== RUN   TestAccCloudFrontOriginAccessControl_SigningBehavior
=== PAUSE TestAccCloudFrontOriginAccessControl_SigningBehavior
=== CONT  TestAccCloudFrontOriginAccessControl_basic
=== CONT  TestAccCloudFrontOriginAccessControl_Description
--- PASS: TestAccCloudFrontOriginAccessControl_basic (16.14s)
=== CONT  TestAccCloudFrontOriginAccessControl_SigningBehavior
--- PASS: TestAccCloudFrontOriginAccessControl_Description (39.99s)
=== CONT  TestAccCloudFrontOriginAccessControl_Name
--- PASS: TestAccCloudFrontOriginAccessControl_SigningBehavior (25.89s)
=== CONT  TestAccCloudFrontOriginAccessControl_disappears
--- PASS: TestAccCloudFrontOriginAccessControl_disappears (11.07s)
--- PASS: TestAccCloudFrontOriginAccessControl_Name (24.92s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	68.979s

@ewbankkit
Copy link
Contributor

@roberth-k Thanks for the contribution 🎉 👏.

@github-actions
Copy link

github-actions bot commented Sep 2, 2022

This functionality has been released in v4.29.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudfront Issues and PRs that pertain to the cloudfront service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants