Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redshift serverless endpoint #26555

Merged
merged 10 commits into from
Sep 1, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Aug 30, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #24501

Output from acceptance testing:

$ make testacc TESTS=TestAccRedshiftServerlessEndpointAccess_ PKG=redshiftserverless
--- PASS: TestAccRedshiftServerlessEndpointAccess_basic (883.76s)
--- PASS: TestAccRedshiftServerlessEndpointAccess_disappears_workgroup (552.98s)
--- PASS: TestAccRedshiftServerlessEndpointAccess_disappears (783.29s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 30, 2022
@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Aug 30, 2022
@DrFaust92 DrFaust92 added new-resource Introduces a new resource. enhancement Requests to existing resources that expand the functionality or scope. labels Aug 30, 2022
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 30, 2022
@DrFaust92 DrFaust92 removed the needs-triage Waiting for first response or review from a maintainer. label Aug 30, 2022
@DrFaust92
Copy link
Collaborator Author

Initial tests passing, tweaking sweepers/update tests

@DrFaust92 DrFaust92 marked this pull request as ready for review August 30, 2022 21:42
@DrFaust92 DrFaust92 changed the title Redshift serverless endpoint - WIP Redshift serverless endpoint Aug 30, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRedshiftServerless' PKG=redshiftserverless ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshiftserverless/... -v -count 1 -parallel 3  -run=TestAccRedshiftServerless -timeout 180m
=== RUN   TestAccRedshiftServerlessEndpointAccess_basic
=== PAUSE TestAccRedshiftServerlessEndpointAccess_basic
=== RUN   TestAccRedshiftServerlessEndpointAccess_disappears_workgroup
=== PAUSE TestAccRedshiftServerlessEndpointAccess_disappears_workgroup
=== RUN   TestAccRedshiftServerlessEndpointAccess_disappears
=== PAUSE TestAccRedshiftServerlessEndpointAccess_disappears
=== RUN   TestAccRedshiftServerlessNamespace_basic
=== PAUSE TestAccRedshiftServerlessNamespace_basic
=== RUN   TestAccRedshiftServerlessNamespace_tags
=== PAUSE TestAccRedshiftServerlessNamespace_tags
=== RUN   TestAccRedshiftServerlessNamespace_disappears
=== PAUSE TestAccRedshiftServerlessNamespace_disappears
=== RUN   TestAccRedshiftServerlessWorkgroup_basic
=== PAUSE TestAccRedshiftServerlessWorkgroup_basic
=== RUN   TestAccRedshiftServerlessWorkgroup_tags
=== PAUSE TestAccRedshiftServerlessWorkgroup_tags
=== RUN   TestAccRedshiftServerlessWorkgroup_disappears
=== PAUSE TestAccRedshiftServerlessWorkgroup_disappears
=== CONT  TestAccRedshiftServerlessEndpointAccess_basic
=== CONT  TestAccRedshiftServerlessNamespace_disappears
=== CONT  TestAccRedshiftServerlessNamespace_basic
--- PASS: TestAccRedshiftServerlessNamespace_disappears (17.73s)
=== CONT  TestAccRedshiftServerlessNamespace_tags
--- PASS: TestAccRedshiftServerlessNamespace_basic (38.19s)
=== CONT  TestAccRedshiftServerlessEndpointAccess_disappears
--- PASS: TestAccRedshiftServerlessNamespace_tags (42.62s)
--- PASS: TestAccRedshiftServerlessWorkgroup_tags (528.60s)
=== CONT  TestAccRedshiftServerlessWorkgroup_disappears
--- PASS: TestAccRedshiftServerlessEndpointAccess_disappears (729.37s)
=== CONT  TestAccRedshiftServerlessWorkgroup_basic
--- PASS: TestAccRedshiftServerlessWorkgroup_basic (439.81s)
=== CONT  TestAccRedshiftServerlessEndpointAccess_disappears_workgroup
--- PASS: TestAccRedshiftServerlessWorkgroup_disappears (638.76s)
--- PASS: TestAccRedshiftServerlessEndpointAccess_basic (1173.96s)
--- PASS: TestAccRedshiftServerlessEndpointAccess_disappears_workgroup (624.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshiftserverless	1761.773s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 37730aa into hashicorp:main Sep 1, 2022
@github-actions github-actions bot added this to the v4.29.0 milestone Sep 1, 2022
@ewbankkit ewbankkit mentioned this pull request Sep 1, 2022
3 tasks
@github-actions
Copy link

github-actions bot commented Sep 2, 2022

This functionality has been released in v4.29.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Redshift Serverless support
2 participants