Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-Managed Kafka Event Source Mapping: Optionally specify consumer_group_id upon resource creation #26559

Closed
A122943 opened this issue Aug 31, 2022 · 2 comments · Fixed by #26560
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service.
Milestone

Comments

@A122943
Copy link
Contributor

A122943 commented Aug 31, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Adds "self_managed_kafka_config" (SelfManagedKafkaEventSourceConfig) and "amazon_managed_kafka_config" (AmazonManagedKafkaEventSourceConfig) blocks to "aws_lambda_event_source_mapping" resource

Enables setting Kafka ConsumerGroupId upon resource creation

  • "The identifier for the Kafka consumer group to join. The consumer group ID must be unique among all your Kafka event sources. After creating a Kafka event source mapping with the consumer group ID specified, you cannot update this value."

New or Affected Resource(s)

  • aws_lambda_event_source_mapping

Potential Terraform Configuration

resource "aws_lambda_event_source_mapping" "self_managed" {
  function_name     = aws_lambda_function.example.arn
  topics            = ["Example"]
  starting_position = "TRIM_HORIZON"

  # begin new syntax
  self_managed_kafka_config {
    consumer_group_id = "some-id"
  }
  # end

  self_managed_event_source {
    endpoints = {
      KAFKA_BOOTSTRAP_SERVERS = "kafka1.example.com:9092,kafka2.example.com:9092"
    }
  }

  source_access_configuration {
    type = "VPC_SUBNET"
    uri  = "subnet:subnet-example1"
  }
}
resource "aws_lambda_event_source_mapping" "msk" {
  event_source_arn  = aws_msk_cluster.example.arn
  function_name     = aws_lambda_function.example.arn
  topics            = ["Example"]
  starting_position = "TRIM_HORIZON"

  # begin new syntax
  amazon_managed_kafka_config {
    consumer_group_id = "some-id"
  }
  # end
}

References

Discussion

  • Despite sharing ConsumerGroupId, the Amazon-managed Kafka event source does not interface with SelfManagedKafkaEventSourceConfig, it uses AmazonManagedKafkaEventSourceConfig.
@A122943 A122943 added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 31, 2022
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/lambda Issues and PRs that pertain to the lambda service. labels Aug 31, 2022
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Aug 31, 2022
@github-actions github-actions bot added this to the v4.29.0 milestone Sep 1, 2022
@github-actions
Copy link

github-actions bot commented Sep 2, 2022

This functionality has been released in v4.29.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 3, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service.
Projects
None yet
2 participants