Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resources for controling Control Tower Guardrails #26612

Closed
mbevc1 opened this issue Sep 1, 2022 · 4 comments · Fixed by #26990
Closed

Add resources for controling Control Tower Guardrails #26612

mbevc1 opened this issue Sep 1, 2022 · 4 comments · Fixed by #26990
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. new-service Introduces a new service.
Milestone

Comments

@mbevc1
Copy link

mbevc1 commented Sep 1, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

We got API support for AWS Control Tower Guardrails: https://docs.aws.amazon.com/controltower/latest/userguide/guardrail-api-examples-short.html

New or Affected Resource(s)

  • aws_controltower_enable_control
  • aws_controltower_disable_control
  • aws_controltower_get_control

Potential Terraform Configuration

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.

References

@mbevc1 mbevc1 added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 1, 2022
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 1, 2022
@ewbankkit ewbankkit added new-resource Introduces a new resource. new-service Introduces a new service. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 2, 2022
@silvaalbert
Copy link
Contributor

silvaalbert commented Sep 2, 2022

Suggest this be implemented as a resource for aws_controltower_control and a corresponding data source. There is also a ListEnabledControls API call not referenced in this issue that could be a useful data source.

@silvaalbert
Copy link
Contributor

I'll take this one, I'm actively working on it.

@github-actions
Copy link

This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. new-service Introduces a new service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants