Retry when creating or deleting asg_autoscaling_attachment resources

[lurcio]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11301.
Relates #10435.
Relates #10445.

Output from acceptance testing:

$ make testacc TESTS='TestAccAutoScalingAttachment_' PKG=autoscaling

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 20 -run='TestAccAutoScalingAttachment_'  -timeout 180m
=== RUN   TestAccAutoScalingAttachment_elb
=== PAUSE TestAccAutoScalingAttachment_elb
=== RUN   TestAccAutoScalingAttachment_albTargetGroup
=== PAUSE TestAccAutoScalingAttachment_albTargetGroup
=== CONT  TestAccAutoScalingAttachment_elb
=== CONT  TestAccAutoScalingAttachment_albTargetGroup
--- PASS: TestAccAutoScalingAttachment_elb (85.62s)
--- PASS: TestAccAutoScalingAttachment_albTargetGroup (94.50s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	96.230s

[lurcio]

This PR adds retries to the resourceAttachmentCreate and resourceAttachmentDelete functions for the aws_autoscaling_attachment resource. I ran into issues when attaching more than 10 Target Groups to an Auto Scaling Group at once. I found this problem also mentioned in #11301.

I'm aware that resource.Retry is deprecated in favour of resource.RetryContext, but did not want to figure out how to refactor the code to use the new function for my first contribution 😄

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAutoScalingAttachment_' PKG=autoscaling ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2  -run=TestAccAutoScalingAttachment_ -timeout 180m
=== RUN   TestAccAutoScalingAttachment_elb
=== PAUSE TestAccAutoScalingAttachment_elb
=== RUN   TestAccAutoScalingAttachment_albTargetGroup
=== PAUSE TestAccAutoScalingAttachment_albTargetGroup
=== RUN   TestAccAutoScalingAttachment_multipleELBs
=== PAUSE TestAccAutoScalingAttachment_multipleELBs
=== RUN   TestAccAutoScalingAttachment_multipleALBTargetGroups
=== PAUSE TestAccAutoScalingAttachment_multipleALBTargetGroups
=== CONT  TestAccAutoScalingAttachment_elb
=== CONT  TestAccAutoScalingAttachment_multipleELBs
--- PASS: TestAccAutoScalingAttachment_elb (94.19s)
=== CONT  TestAccAutoScalingAttachment_albTargetGroup
--- PASS: TestAccAutoScalingAttachment_albTargetGroup (50.07s)
=== CONT  TestAccAutoScalingAttachment_multipleALBTargetGroups
--- PASS: TestAccAutoScalingAttachment_multipleELBs (248.75s)
--- PASS: TestAccAutoScalingAttachment_multipleALBTargetGroups (116.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	265.149s

[ewbankkit]

@lurcio Thanks for the contribution 🎉 👏.
I went ahead and added some test cases for creating and deleting 11 attachments at once.

[lurcio]

@ewbankkit Wooo, thank you! I'm doing a little dance right now.

[github-actions]

This functionality has been released in v4.31.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.