Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_eip: Deprecate vpc and make domain a settable parameter #26714

Closed
gdavison opened this issue Sep 8, 2022 · 3 comments · Fixed by #31567
Closed

resource/aws_eip: Deprecate vpc and make domain a settable parameter #26714

gdavison opened this issue Sep 8, 2022 · 3 comments · Fixed by #31567
Assignees
@johnsonaj
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone
v5.0.0

Comments

@gdavison
Copy link
Contributor

gdavison commented Sep 8, 2022

Deprecate the non-standard vpc parameter in favour of the domain parameter. Make domain properly settable.

Affected Resource

  • aws_eip
@gdavison gdavison added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 8, 2022
@github-actions github-actions bot added the service/ec2 Issues and PRs that pertain to the ec2 service. label Sep 8, 2022
@gdavison gdavison mentioned this issue Sep 8, 2022
Open
@ewbankkit
Copy link
Contributor

Relates #23625.

@ewbankkit ewbankkit modified the milestones: v6.0.0, v5.0.0 May 4, 2023
@johnsonaj johnsonaj mentioned this issue May 24, 2023
Merged
@johnsonaj johnsonaj self-assigned this May 24, 2023
@github-actions
Copy link

This functionality has been released in v5.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@johnsonaj johnsonaj

Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging a pull request may close this issue.

aws_eip: deprecate vpc attribute hashicorp/terraform-provider-aws
3 participants
@gdavison @ewbankkit @johnsonaj