enhancement(resourcegroups): Add configuration type and attribute #26934

IainSteers · 2022-09-22T09:40:26Z

Output from acceptance testing:

I added some new acceptance tests for the configuration group and also verified that the additions don't fail the existing acceptance tests.

$ make testacc TESTS=TestAccResourceGroupsGroup PKG=resourcegroups
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/resourcegroups/... -v -count 1 -parallel 20 -run='TestAccResourceGroupsGroup'  -timeout 180m
=== RUN   TestAccResourceGroupsGroup_Resource_basic
=== PAUSE TestAccResourceGroupsGroup_Resource_basic
=== RUN   TestAccResourceGroupsGroup_Resource_Configuration
=== PAUSE TestAccResourceGroupsGroup_Resource_Configuration
=== RUN   TestAccResourceGroupsGroup_Resource_tags
=== PAUSE TestAccResourceGroupsGroup_Resource_tags
=== CONT  TestAccResourceGroupsGroup_Resource_basic
=== CONT  TestAccResourceGroupsGroup_Resource_Configuration
=== CONT  TestAccResourceGroupsGroup_Resource_tags
--- PASS: TestAccResourceGroupsGroup_Resource_basic (30.40s)
--- PASS: TestAccResourceGroupsGroup_Resource_tags (47.49s)
--- PASS: TestAccResourceGroupsGroup_Resource_Configuration (55.93s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/resourcegroups	57.856s
...

github-actions · 2022-09-22T09:40:39Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Please review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

github-actions

Welcome @IainSteers 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

dkheyman · 2022-09-22T17:30:18Z

This is crucial for my customer's use of capacity reservations. If this works according to the planned use of Configuration, let's approve!

IainSteers · 2022-09-22T19:24:44Z

@dkheyman as well as the acceptance tests, using one of our test AWS accounts I was able to use this resource to create a Host Resource Group, verify the fields in the console.

I was then able to reference the created Host-Resource-Group from both the Instance Launch Wizard and a Launch Template successfully and have dedicated hosts and instances spin up.

Basically following https://aws.amazon.com/blogs/compute/implementing-autoscaling-for-ec2-mac-instances/ but with this new resource support

Acceptance test output: % make testacc TESTARGS='-run=TestAccResourceGroupsGroup_' PKG=resourcegroups ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/resourcegroups/... -v -count 1 -parallel 2 -run=TestAccResourceGroupsGroup_ -timeout 180m === RUN TestAccResourceGroupsGroup_basic === PAUSE TestAccResourceGroupsGroup_basic === RUN TestAccResourceGroupsGroup_tags === PAUSE TestAccResourceGroupsGroup_tags === RUN TestAccResourceGroupsGroup_Configuration === PAUSE TestAccResourceGroupsGroup_Configuration === CONT TestAccResourceGroupsGroup_basic === CONT TestAccResourceGroupsGroup_Configuration --- PASS: TestAccResourceGroupsGroup_basic (34.23s) === CONT TestAccResourceGroupsGroup_tags --- PASS: TestAccResourceGroupsGroup_Configuration (58.01s) --- PASS: TestAccResourceGroupsGroup_tags (46.30s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/resourcegroups 84.833s

Acceptance test output: % make testacc TESTARGS='-run=TestAccResourceGroupsGroup_' PKG=resourcegroups ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/resourcegroups/... -v -count 1 -parallel 2 -run=TestAccResourceGroupsGroup_ -timeout 180m === RUN TestAccResourceGroupsGroup_basic === PAUSE TestAccResourceGroupsGroup_basic === RUN TestAccResourceGroupsGroup_tags === PAUSE TestAccResourceGroupsGroup_tags === RUN TestAccResourceGroupsGroup_Configuration === PAUSE TestAccResourceGroupsGroup_Configuration === CONT TestAccResourceGroupsGroup_basic === CONT TestAccResourceGroupsGroup_Configuration --- PASS: TestAccResourceGroupsGroup_basic (34.75s) === CONT TestAccResourceGroupsGroup_tags --- PASS: TestAccResourceGroupsGroup_Configuration (56.45s) --- PASS: TestAccResourceGroupsGroup_tags (44.25s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/resourcegroups 83.145s

…ashicorp#15090). Acceptance test output: % make testacc TESTARGS='-run=TestAccResourceGroupsGroup_' PKG=resourcegroups ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/resourcegroups/... -v -count 1 -parallel 2 -run=TestAccResourceGroupsGroup_ -timeout 180m === RUN TestAccResourceGroupsGroup_basic === PAUSE TestAccResourceGroupsGroup_basic === RUN TestAccResourceGroupsGroup_tags === PAUSE TestAccResourceGroupsGroup_tags === RUN TestAccResourceGroupsGroup_Configuration === PAUSE TestAccResourceGroupsGroup_Configuration === CONT TestAccResourceGroupsGroup_basic === CONT TestAccResourceGroupsGroup_Configuration --- PASS: TestAccResourceGroupsGroup_basic (32.33s) === CONT TestAccResourceGroupsGroup_tags --- PASS: TestAccResourceGroupsGroup_Configuration (53.89s) --- PASS: TestAccResourceGroupsGroup_tags (43.16s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/resourcegroups 79.452s

Acceptance test output: % make testacc TESTARGS='-run=TestAccResourceGroupsGroup_' PKG=resourcegroups ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/resourcegroups/... -v -count 1 -parallel 2 -run=TestAccResourceGroupsGroup_ -timeout 180m === RUN TestAccResourceGroupsGroup_basic === PAUSE TestAccResourceGroupsGroup_basic === RUN TestAccResourceGroupsGroup_tags === PAUSE TestAccResourceGroupsGroup_tags === RUN TestAccResourceGroupsGroup_Configuration === PAUSE TestAccResourceGroupsGroup_Configuration === CONT TestAccResourceGroupsGroup_basic === CONT TestAccResourceGroupsGroup_Configuration --- PASS: TestAccResourceGroupsGroup_basic (34.17s) === CONT TestAccResourceGroupsGroup_tags --- PASS: TestAccResourceGroupsGroup_Configuration (56.72s) --- PASS: TestAccResourceGroupsGroup_tags (45.15s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/resourcegroups 83.659s

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccResourceGroupsGroup_' PKG=resourcegroups ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/resourcegroups/... -v -count 1 -parallel 2  -run=TestAccResourceGroupsGroup_ -timeout 180m
=== RUN   TestAccResourceGroupsGroup_basic
=== PAUSE TestAccResourceGroupsGroup_basic
=== RUN   TestAccResourceGroupsGroup_tags
=== PAUSE TestAccResourceGroupsGroup_tags
=== RUN   TestAccResourceGroupsGroup_Configuration
=== PAUSE TestAccResourceGroupsGroup_Configuration
=== CONT  TestAccResourceGroupsGroup_basic
=== CONT  TestAccResourceGroupsGroup_Configuration
--- PASS: TestAccResourceGroupsGroup_basic (34.17s)
=== CONT  TestAccResourceGroupsGroup_tags
--- PASS: TestAccResourceGroupsGroup_Configuration (56.72s)
--- PASS: TestAccResourceGroupsGroup_tags (45.15s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/resourcegroups	83.659s

ewbankkit · 2022-10-20T19:35:18Z

@IainSteers Thanks for the contribution 🎉 👏.

github-actions · 2022-10-20T23:11:58Z

This functionality has been released in v4.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-11-21T02:30:38Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

IainSteers added 2 commits September 22, 2022 10:25

Support configuration type resource groups

e63246e

Add acceptance tests for configuration resource groups

85624f1

Add Changelog for PR 26934

31dc757

github-actions bot reviewed Sep 22, 2022

View reviewed changes

Fix import order and usage lint

9de3a59

IainSteers marked this pull request as ready for review September 22, 2022 10:07

breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 11, 2022

IainSteers and others added 7 commits October 20, 2022 17:50

Format test terraform blocks

fcef7db

r/aws_resourcegroups_group: Alphabetize attributes.

05d9eb1

r/aws_resourcegroups_group: Order CRUD handlers.

b64acd6

ewbankkit approved these changes Oct 20, 2022

View reviewed changes

ewbankkit added 2 commits October 20, 2022 15:36

Tweak CHANGELOG entry.

4e65e1f

Document 'configuration' block.

6de5bd1

github-actions bot added the documentation Introduces or discusses updates to documentation. label Oct 20, 2022

Fix golangi-lint 'unparam'.

d08ff90

ewbankkit merged commit 647880f into hashicorp:main Oct 20, 2022

github-actions bot added this to the v4.36.0 milestone Oct 20, 2022

github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enhancement(resourcegroups): Add configuration type and attribute #26934

enhancement(resourcegroups): Add configuration type and attribute #26934

IainSteers commented Sep 22, 2022 •

edited

Loading

github-actions bot commented Sep 22, 2022

github-actions bot left a comment

dkheyman commented Sep 22, 2022

IainSteers commented Sep 22, 2022 •

edited

Loading

ewbankkit left a comment

ewbankkit commented Oct 20, 2022

github-actions bot commented Oct 20, 2022

github-actions bot commented Nov 21, 2022

enhancement(resourcegroups): Add configuration type and attribute #26934

enhancement(resourcegroups): Add configuration type and attribute #26934

Conversation

IainSteers commented Sep 22, 2022 • edited Loading

github-actions bot commented Sep 22, 2022

Community Note

github-actions bot left a comment

Choose a reason for hiding this comment

dkheyman commented Sep 22, 2022

IainSteers commented Sep 22, 2022 • edited Loading

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Oct 20, 2022

github-actions bot commented Oct 20, 2022

github-actions bot commented Nov 21, 2022

IainSteers commented Sep 22, 2022 •

edited

Loading

IainSteers commented Sep 22, 2022 •

edited

Loading