Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: resourcegroups group should support Host-resource-group/configuration type groups #26933

Closed
IainSteers opened this issue Sep 22, 2022 · 4 comments · Fixed by #26934
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/resourcegroups Issues and PRs that pertain to the resourcegroups service.
Milestone

Comments

@IainSteers
Copy link
Contributor

Description

The aws_resourcegroups_group resource should support host-resource-groups and configuration groups in general.

AWS implemented Host-Resource-Groups as a type of resource-group. Instead of a resource-query, configuration groups use the group configuration API to attach or update group configurations

Affected Resource(s) and/or Data Source(s)

  • aws_resourcegroups_group

Potential Terraform Configuration

resource "aws_licensemanager_license_configuration"  "mac_license_config"{  
  name                     = "mac-dedicated-license"
  description              = "Pass through configuration for Host Resource Group"
  license_count            = 32
  license_count_hard_limit = false
  license_counting_type    = "Core"
}

resource "aws_resourcegroups_group" "mac" {
  name        = "mac-hrg"
  description = "A host-resource-group for mac dedicated instances"

  configuration {
    type = "AWS::EC2::HostManagement"

    parameters {
      name   = "allowed-host-families"
      values = [
        "mac1",
      ]
    }

    parameters {
      name   = "allowed-host-based-license-configurations"
      values = [
        aws_licensemanager_license_configuration.mac_license_config.arn,
      ]
    }

    parameters {
      name   = "auto-allocate-host"
      values = [
        "true",
      ]
    }

    parameters {
      name   = "auto-release-host"
      values = [
        "true",
      ]
    }
  }

  configuration {
    type = "AWS::ResourceGroups::Generic"

    parameters {
      name = "allowed-resource-types"
      values = [
        "AWS::EC2::Host",
      ]
    }

    parameters {
      name = "deletion-protection"
      values = [
        "UNLESS_EMPTY"
      ]
    }
  }
}

References

Examples and description of host-resource-groups https://aws.amazon.com/blogs/compute/implementing-autoscaling-for-ec2-mac-instances/

Supported types https://docs.aws.amazon.com/ARG/latest/APIReference/about-slg.html#about-slg-types

Would you like to implement a fix?

Yes

@IainSteers IainSteers added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Sep 22, 2022
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added service/licensemanager Issues and PRs that pertain to the licensemanager service. service/resourcegroups Issues and PRs that pertain to the resourcegroups service. labels Sep 22, 2022
@IainSteers
Copy link
Contributor Author

I'll be submitting a pull request shortly that should implement this.

@ewbankkit ewbankkit removed service/licensemanager Issues and PRs that pertain to the licensemanager service. needs-triage Waiting for first response or review from a maintainer. labels Oct 20, 2022
@github-actions github-actions bot added this to the v4.36.0 milestone Oct 20, 2022
@github-actions
Copy link

This functionality has been released in v4.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/resourcegroups Issues and PRs that pertain to the resourcegroups service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants