Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_appconfig data sources #27054

Merged
merged 2 commits into from
Oct 3, 2022
Merged

aws_appconfig data sources #27054

merged 2 commits into from
Oct 3, 2022

Conversation

mtt88
Copy link
Contributor

@mtt88 mtt88 commented Oct 2, 2022

  • Add data source for appconfig_configuration_profile
  • Add data source for appconfig_configuration_profiles
  • Add data source for appconfig_environment
  • Add data source for appconfig_environments

Description

Relations

Closes #26119

References

Output from Acceptance Testing

make testacc TESTS=TestAccAppConfigConfigurationProfileDataSource PKG=appconfig
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appconfig/... -v -count 1 -parallel 20 -run='TestAccAppConfigConfigurationProfileDataSource'  -timeout 180m
=== RUN   TestAccAppConfigConfigurationProfileDataSource_basic
=== PAUSE TestAccAppConfigConfigurationProfileDataSource_basic
=== CONT  TestAccAppConfigConfigurationProfileDataSource_basic
--- PASS: TestAccAppConfigConfigurationProfileDataSource_basic (26.61s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appconfig  26.660s

make testacc TESTS=TestAccAppConfigEnvironmentDataSource PKG=appconfig
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appconfig/... -v -count 1 -parallel 20 -run='TestAccAppConfigEnvironmentDataSource'  -timeout 180m
=== RUN   TestAccAppConfigEnvironmentDataSource_basic
=== PAUSE TestAccAppConfigEnvironmentDataSource_basic
=== CONT  TestAccAppConfigEnvironmentDataSource_basic
--- PASS: TestAccAppConfigEnvironmentDataSource_basic (33.24s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appconfig  33.291s

make testacc TESTS=TestAccAppConfigConfigurationProfilesDataSource PKG=appconfig
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appconfig/... -v -count 1 -parallel 20 -run='TestAccAppConfigConfigurationProfilesDataSource'  -timeout 180m
=== RUN   TestAccAppConfigConfigurationProfilesDataSource_basic
=== PAUSE TestAccAppConfigConfigurationProfilesDataSource_basic
=== CONT  TestAccAppConfigConfigurationProfilesDataSource_basic
--- PASS: TestAccAppConfigConfigurationProfilesDataSource_basic (25.19s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appconfig  25.278s

make testacc TESTS=TestAccAppConfigEnvironmentsDataSource PKG=appconfig
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appconfig/... -v -count 1 -parallel 20 -run='TestAccAppConfigEnvironmentsDataSource'  -timeout 180m
=== RUN   TestAccAppConfigEnvironmentsDataSource_basic
=== PAUSE TestAccAppConfigEnvironmentsDataSource_basic
=== CONT  TestAccAppConfigEnvironmentsDataSource_basic
--- PASS: TestAccAppConfigEnvironmentsDataSource_basic (25.04s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appconfig  25.085s


...

@mtt88
New aws_appconfig data sources
134a4d9 
Add data source for appconfig_configuration_profile
Add data source for appconfig_configuration_profiles
Add data source for appconfig_environment
Add data source for appconfig_environments
@github-actions
Copy link

github-actions bot commented Oct 2, 2022

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/appconfig Issues and PRs that pertain to the appconfig service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Oct 2, 2022
@ewbankkit ewbankkit added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 3, 2022
ewbankkit
ewbankkit reviewed Oct 3, 2022
View reviewed changes
GNUmakefile
@@ -92,7 +92,7 @@ testacc: fmtcheck
echo "For example if updating internal/service/acm/certificate.go, use the test names in internal/service/acm/certificate_test.go starting with TestAcc and up to the underscore:"; \
echo "make testacc TESTS=TestAccACMCertificate_ PKG=acm"; \
echo ""; \
echo "See the contributing guide for more information: https://github.com/hashicorp/terraform-provider-aws/blob/main/docs/contributing/running-and-writing-acceptance-tests.md"; \
echo "See the contributing guide for more information: https://hashicorp.github.io/terraform-provider-aws/running-and-writing-acceptance-tests"; \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ewbankkit
ewbankkit approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAppConfigConfigurationProfile\|TestAccAppConfigEnvironment' PKG=appconfig ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appconfig/... -v -count 1 -parallel 3  -run=TestAccAppConfigConfigurationProfile\|TestAccAppConfigEnvironment -timeout 180m
=== RUN   TestAccAppConfigConfigurationProfileDataSource_basic
=== PAUSE TestAccAppConfigConfigurationProfileDataSource_basic
=== RUN   TestAccAppConfigConfigurationProfile_basic
=== PAUSE TestAccAppConfigConfigurationProfile_basic
=== RUN   TestAccAppConfigConfigurationProfile_disappears
=== PAUSE TestAccAppConfigConfigurationProfile_disappears
=== RUN   TestAccAppConfigConfigurationProfile_Validators_json
=== PAUSE TestAccAppConfigConfigurationProfile_Validators_json
=== RUN   TestAccAppConfigConfigurationProfile_Validators_lambda
=== PAUSE TestAccAppConfigConfigurationProfile_Validators_lambda
=== RUN   TestAccAppConfigConfigurationProfile_Validators_multiple
=== PAUSE TestAccAppConfigConfigurationProfile_Validators_multiple
=== RUN   TestAccAppConfigConfigurationProfile_updateName
=== PAUSE TestAccAppConfigConfigurationProfile_updateName
=== RUN   TestAccAppConfigConfigurationProfile_updateDescription
=== PAUSE TestAccAppConfigConfigurationProfile_updateDescription
=== RUN   TestAccAppConfigConfigurationProfile_tags
=== PAUSE TestAccAppConfigConfigurationProfile_tags
=== RUN   TestAccAppConfigConfigurationProfilesDataSource_basic
=== PAUSE TestAccAppConfigConfigurationProfilesDataSource_basic
=== RUN   TestAccAppConfigEnvironmentDataSource_basic
=== PAUSE TestAccAppConfigEnvironmentDataSource_basic
=== RUN   TestAccAppConfigEnvironment_basic
=== PAUSE TestAccAppConfigEnvironment_basic
=== RUN   TestAccAppConfigEnvironment_disappears
=== PAUSE TestAccAppConfigEnvironment_disappears
=== RUN   TestAccAppConfigEnvironment_updateName
=== PAUSE TestAccAppConfigEnvironment_updateName
=== RUN   TestAccAppConfigEnvironment_updateDescription
=== PAUSE TestAccAppConfigEnvironment_updateDescription
=== RUN   TestAccAppConfigEnvironment_monitors
=== PAUSE TestAccAppConfigEnvironment_monitors
=== RUN   TestAccAppConfigEnvironment_multipleEnvironments
=== PAUSE TestAccAppConfigEnvironment_multipleEnvironments
=== RUN   TestAccAppConfigEnvironment_tags
=== PAUSE TestAccAppConfigEnvironment_tags
=== RUN   TestAccAppConfigEnvironmentsDataSource_basic
=== PAUSE TestAccAppConfigEnvironmentsDataSource_basic
=== CONT  TestAccAppConfigConfigurationProfileDataSource_basic
=== CONT  TestAccAppConfigEnvironmentDataSource_basic
=== CONT  TestAccAppConfigConfigurationProfile_Validators_multiple
--- PASS: TestAccAppConfigConfigurationProfileDataSource_basic (19.20s)
=== CONT  TestAccAppConfigEnvironment_monitors
--- PASS: TestAccAppConfigEnvironmentDataSource_basic (19.36s)
=== CONT  TestAccAppConfigEnvironmentsDataSource_basic
--- PASS: TestAccAppConfigEnvironmentsDataSource_basic (16.71s)
=== CONT  TestAccAppConfigEnvironment_tags
--- PASS: TestAccAppConfigConfigurationProfile_Validators_multiple (43.54s)
=== CONT  TestAccAppConfigEnvironment_multipleEnvironments
--- PASS: TestAccAppConfigEnvironment_monitors (49.83s)
=== CONT  TestAccAppConfigEnvironment_updateName
--- PASS: TestAccAppConfigEnvironment_tags (45.64s)
=== CONT  TestAccAppConfigEnvironment_updateDescription
--- PASS: TestAccAppConfigEnvironment_multipleEnvironments (38.37s)
=== CONT  TestAccAppConfigConfigurationProfile_tags
--- PASS: TestAccAppConfigEnvironment_updateName (33.62s)
=== CONT  TestAccAppConfigConfigurationProfilesDataSource_basic
--- PASS: TestAccAppConfigConfigurationProfilesDataSource_basic (20.79s)
=== CONT  TestAccAppConfigConfigurationProfile_updateDescription
--- PASS: TestAccAppConfigConfigurationProfile_tags (51.60s)
=== CONT  TestAccAppConfigEnvironment_disappears
--- PASS: TestAccAppConfigEnvironment_updateDescription (54.49s)
=== CONT  TestAccAppConfigEnvironment_basic
--- PASS: TestAccAppConfigEnvironment_disappears (15.29s)
=== CONT  TestAccAppConfigConfigurationProfile_Validators_json
--- PASS: TestAccAppConfigEnvironment_basic (17.91s)
=== CONT  TestAccAppConfigConfigurationProfile_Validators_lambda
--- PASS: TestAccAppConfigConfigurationProfile_updateDescription (34.17s)
=== CONT  TestAccAppConfigConfigurationProfile_updateName
--- PASS: TestAccAppConfigConfigurationProfile_updateName (33.87s)
=== CONT  TestAccAppConfigConfigurationProfile_disappears
--- PASS: TestAccAppConfigConfigurationProfile_Validators_json (48.25s)
=== CONT  TestAccAppConfigConfigurationProfile_basic
--- PASS: TestAccAppConfigConfigurationProfile_disappears (16.48s)
--- PASS: TestAccAppConfigConfigurationProfile_Validators_lambda (56.33s)
--- PASS: TestAccAppConfigConfigurationProfile_basic (18.94s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appconfig	219.777s

@ewbankkit
Copy link
Contributor

@mtt88 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 9404582 into hashicorp:main Oct 3, 2022
@github-actions github-actions bot added this to the v4.34.0 milestone Oct 3, 2022
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

This functionality has been released in v4.34.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Nov 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/appconfig Issues and PRs that pertain to the appconfig service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.34.0
Development

Successfully merging this pull request may close these issues.

Add Data Sources for AppConfig
2 participants
@mtt88 @ewbankkit