New DataSource: aws_appmesh_virtual_gateway #27057

AhmedGrati · 2022-10-02T19:02:01Z

Description

New DataSource for aws_appmesh_virtual_gateway

Relations

Closes #26907.
Relates #17590.

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccAppMeshVirtualGatewayDataSource  PKG=appmesh
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20 -run='TestAccAppMeshVirtualGatewayDataSource'  -timeout 180m
=== RUN   TestAccAppMeshVirtualGatewayDataSource_basic
=== PAUSE TestAccAppMeshVirtualGatewayDataSource_basic
=== RUN   TestAccAppMeshVirtualGatewayDataSource_backendDefaults
=== PAUSE TestAccAppMeshVirtualGatewayDataSource_backendDefaults
=== RUN   TestAccAppMeshVirtualGatewayDataSource_backendDefaultsUpdated
=== PAUSE TestAccAppMeshVirtualGatewayDataSource_backendDefaultsUpdated
=== RUN   TestAccAppMeshVirtualGatewayDataSource_backendDefaultsCertificate
=== PAUSE TestAccAppMeshVirtualGatewayDataSource_backendDefaultsCertificate
=== RUN   TestAccAppMeshVirtualGatewayDataSource_listenerConnectionPool
=== PAUSE TestAccAppMeshVirtualGatewayDataSource_listenerConnectionPool
=== RUN   TestAccAppMeshVirtualGatewayDataSource_listenerConnectionPoolUpdated
=== PAUSE TestAccAppMeshVirtualGatewayDataSource_listenerConnectionPoolUpdated
=== RUN   TestAccAppMeshVirtualGatewayDataSource_listenerHealthChecks
=== PAUSE TestAccAppMeshVirtualGatewayDataSource_listenerHealthChecks
=== RUN   TestAccAppMeshVirtualGatewayDataSource_listenerTLSACM
=== PAUSE TestAccAppMeshVirtualGatewayDataSource_listenerTLSACM
=== RUN   TestAccAppMeshVirtualGatewayDataSource_listenerTLSFile
=== PAUSE TestAccAppMeshVirtualGatewayDataSource_listenerTLSFile
=== RUN   TestAccAppMeshVirtualGatewayDataSource_listenerValidation
=== PAUSE TestAccAppMeshVirtualGatewayDataSource_listenerValidation
=== RUN   TestAccAppMeshVirtualGatewayDataSource_logging
=== PAUSE TestAccAppMeshVirtualGatewayDataSource_logging
=== RUN   TestAccAppMeshVirtualGatewayDataSource_tags
=== PAUSE TestAccAppMeshVirtualGatewayDataSource_tags
=== CONT  TestAccAppMeshVirtualGatewayDataSource_basic
=== CONT  TestAccAppMeshVirtualGatewayDataSource_listenerValidation
=== CONT  TestAccAppMeshVirtualGatewayDataSource_tags
=== CONT  TestAccAppMeshVirtualGatewayDataSource_logging
=== CONT  TestAccAppMeshVirtualGatewayDataSource_listenerTLSFile
=== CONT  TestAccAppMeshVirtualGatewayDataSource_backendDefaultsCertificate
=== CONT  TestAccAppMeshVirtualGatewayDataSource_listenerConnectionPoolUpdated
=== CONT  TestAccAppMeshVirtualGatewayDataSource_listenerHealthChecks
=== CONT  TestAccAppMeshVirtualGatewayDataSource_listenerConnectionPool
=== CONT  TestAccAppMeshVirtualGatewayDataSource_listenerTLSACM
=== CONT  TestAccAppMeshVirtualGatewayDataSource_backendDefaultsUpdated
=== CONT  TestAccAppMeshVirtualGatewayDataSource_backendDefaults
--- PASS: TestAccAppMeshVirtualGatewayDataSource_listenerHealthChecks (26.14s)
--- PASS: TestAccAppMeshVirtualGatewayDataSource_basic (28.43s)
--- PASS: TestAccAppMeshVirtualGatewayDataSource_backendDefaultsCertificate (28.48s)
--- PASS: TestAccAppMeshVirtualGatewayDataSource_listenerValidation (28.53s)
--- PASS: TestAccAppMeshVirtualGatewayDataSource_listenerConnectionPoolUpdated (28.64s)
--- PASS: TestAccAppMeshVirtualGatewayDataSource_backendDefaultsUpdated (28.68s)
--- PASS: TestAccAppMeshVirtualGatewayDataSource_backendDefaults (28.70s)
--- PASS: TestAccAppMeshVirtualGatewayDataSource_listenerTLSFile (28.70s)
--- PASS: TestAccAppMeshVirtualGatewayDataSource_tags (28.72s)
--- PASS: TestAccAppMeshVirtualGatewayDataSource_logging (28.73s)
--- PASS: TestAccAppMeshVirtualGatewayDataSource_listenerConnectionPool (28.76s)
--- PASS: TestAccAppMeshVirtualGatewayDataSource_listenerTLSACM (61.52s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appmesh    61.677s
...

github-actions · 2022-10-02T19:02:17Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

github-actions · 2022-10-02T19:02:29Z

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

Check open pull requests with the dependencies label to view other dependency updates.
If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
If this pull request is for supporting a new AWS service:
- Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
- If this pull request is already a separate pull request from the above item, you can ignore this message.

sandeep-s-solanki

LGTM

sandeep-s-solanki

@AhmedGrati Great work! Checks on the PR are failing. Please could you take a look:
https://github.com/hashicorp/terraform-provider-aws/actions/runs/3170021436/jobs/5162326582

We are eagerly awaiting this change, please let us know if we can help.

Thanks

AhmedGrati · 2022-10-11T18:31:47Z

@sandeep-s-solanki Thank you 😊 ! Sure I will fix it ASAP 🙏.

AhmedGrati · 2022-10-11T18:42:08Z

@sandeep-s-solanki It looks like this error comes from the fact that we are using version v1 of this action: actions/first-interaction. For more context, check this GitHub thread: actions/first-interaction#101.
Therefore, migrating to v1.1.1 solves the problem. I can create an issue and a PR to solve this problem if you want.

sandeep-s-solanki · 2022-10-12T09:35:37Z

@AhmedGrati that would be great to solve the issue. We will wait for this PR to merged. Do you know how long the merging process takes for a PR once all check have passed? Also when will a new provider version will be released with these changes? Thank again for your help

AhmedGrati · 2022-10-12T12:47:18Z

@sandeep-s-solanki I have solved the issue in a separate PR. Once merged, we could re-run this pipeline. It would be really great if you review it 🙏😊.

AhmedGrati · 2022-10-13T17:12:36Z

Hey @sandeep-s-solanki, I think it's ready to merge now. Thank you for your efforts 🙏😊.

sandeep-s-solanki · 2022-10-17T09:35:14Z

@AhmedGrati looks great. Thank for your help! 👍

sandeep-s-solanki · 2022-10-21T09:33:39Z

@AhmedGrati who can merge this, as all checks have now passed?

AhmedGrati · 2022-10-21T09:48:04Z

Hey @breathingdust, Is there anything else we need to do to get this PR going?

Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>

…lete.

Acceptance test output: % make testacc TESTARGS='-run=TestAccAppMesh_serial/^VirtualGateway$$' PKG=appmesh ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20 -run=TestAccAppMesh_serial/^VirtualGateway$ -timeout 180m === RUN TestAccAppMesh_serial === PAUSE TestAccAppMesh_serial === CONT TestAccAppMesh_serial === RUN TestAccAppMesh_serial/VirtualGateway === RUN TestAccAppMesh_serial/VirtualGateway/listenerTls === RUN TestAccAppMesh_serial/VirtualGateway/logging === RUN TestAccAppMesh_serial/VirtualGateway/tags === RUN TestAccAppMesh_serial/VirtualGateway/disappears === RUN TestAccAppMesh_serial/VirtualGateway/backendDefaultsCertificate === RUN TestAccAppMesh_serial/VirtualGateway/listenerConnectionPool === RUN TestAccAppMesh_serial/VirtualGateway/listenerHealthChecks === RUN TestAccAppMesh_serial/VirtualGateway/basic === RUN TestAccAppMesh_serial/VirtualGateway/backendDefaults === RUN TestAccAppMesh_serial/VirtualGateway/listenerValidation === RUN TestAccAppMesh_serial/VirtualGateway/multiListenerValidation --- PASS: TestAccAppMesh_serial (338.93s) --- PASS: TestAccAppMesh_serial/VirtualGateway (338.93s) --- PASS: TestAccAppMesh_serial/VirtualGateway/listenerTls (90.28s) --- PASS: TestAccAppMesh_serial/VirtualGateway/logging (36.88s) --- PASS: TestAccAppMesh_serial/VirtualGateway/tags (36.88s) --- PASS: TestAccAppMesh_serial/VirtualGateway/disappears (12.97s) --- PASS: TestAccAppMesh_serial/VirtualGateway/backendDefaultsCertificate (15.76s) --- PASS: TestAccAppMesh_serial/VirtualGateway/listenerConnectionPool (25.99s) --- PASS: TestAccAppMesh_serial/VirtualGateway/listenerHealthChecks (26.14s) --- PASS: TestAccAppMesh_serial/VirtualGateway/basic (15.54s) --- PASS: TestAccAppMesh_serial/VirtualGateway/backendDefaults (26.19s) --- PASS: TestAccAppMesh_serial/VirtualGateway/listenerValidation (26.16s) --- PASS: TestAccAppMesh_serial/VirtualGateway/multiListenerValidation (26.14s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/appmesh 346.915s

Acceptance test output: % make testacc TESTARGS='-run=TestAccAppMesh_serial/^VirtualGateway$$/dataSourceBasic' PKG=appmesh ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20 -run=TestAccAppMesh_serial/^VirtualGateway$/dataSourceBasic -timeout 180m === RUN TestAccAppMesh_serial === PAUSE TestAccAppMesh_serial === CONT TestAccAppMesh_serial === RUN TestAccAppMesh_serial/VirtualGateway === RUN TestAccAppMesh_serial/VirtualGateway/dataSourceBasic --- PASS: TestAccAppMesh_serial (14.70s) --- PASS: TestAccAppMesh_serial/VirtualGateway (14.70s) --- PASS: TestAccAppMesh_serial/VirtualGateway/dataSourceBasic (14.70s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/appmesh 19.835s

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAppMesh_serial/^VirtualGateway$$' PKG=appmesh
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20  -run=TestAccAppMesh_serial/^VirtualGateway$ -timeout 180m
=== RUN   TestAccAppMesh_serial
=== PAUSE TestAccAppMesh_serial
=== CONT  TestAccAppMesh_serial
=== RUN   TestAccAppMesh_serial/VirtualGateway
=== RUN   TestAccAppMesh_serial/VirtualGateway/listenerTls
=== RUN   TestAccAppMesh_serial/VirtualGateway/logging
=== RUN   TestAccAppMesh_serial/VirtualGateway/tags
=== RUN   TestAccAppMesh_serial/VirtualGateway/disappears
=== RUN   TestAccAppMesh_serial/VirtualGateway/backendDefaultsCertificate
=== RUN   TestAccAppMesh_serial/VirtualGateway/listenerConnectionPool
=== RUN   TestAccAppMesh_serial/VirtualGateway/listenerHealthChecks
=== RUN   TestAccAppMesh_serial/VirtualGateway/basic
=== RUN   TestAccAppMesh_serial/VirtualGateway/backendDefaults
=== RUN   TestAccAppMesh_serial/VirtualGateway/listenerValidation
=== RUN   TestAccAppMesh_serial/VirtualGateway/multiListenerValidation
--- PASS: TestAccAppMesh_serial (338.93s)
    --- PASS: TestAccAppMesh_serial/VirtualGateway (338.93s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/listenerTls (90.28s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/logging (36.88s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/tags (36.88s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/disappears (12.97s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/backendDefaultsCertificate (15.76s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/listenerConnectionPool (25.99s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/listenerHealthChecks (26.14s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/basic (15.54s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/backendDefaults (26.19s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/listenerValidation (26.16s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/multiListenerValidation (26.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appmesh	346.915s
% make testacc TESTARGS='-run=TestAccAppMesh_serial/^VirtualGateway$$/dataSourceBasic' PKG=appmesh
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20  -run=TestAccAppMesh_serial/^VirtualGateway$/dataSourceBasic -timeout 180m
=== RUN   TestAccAppMesh_serial
=== PAUSE TestAccAppMesh_serial
=== CONT  TestAccAppMesh_serial
=== RUN   TestAccAppMesh_serial/VirtualGateway
=== RUN   TestAccAppMesh_serial/VirtualGateway/dataSourceBasic
--- PASS: TestAccAppMesh_serial (14.70s)
    --- PASS: TestAccAppMesh_serial/VirtualGateway (14.70s)
        --- PASS: TestAccAppMesh_serial/VirtualGateway/dataSourceBasic (14.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appmesh	19.835s

ewbankkit · 2023-03-23T19:59:50Z

@AhmedGrati Thanks for the contribution 🎉 👏.

github-actions · 2023-03-24T02:08:00Z

This functionality has been released in v4.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2023-04-23T02:15:42Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

sandeep-s-solanki approved these changes Oct 10, 2022

View reviewed changes

sandeep-s-solanki reviewed Oct 11, 2022

View reviewed changes

breathingdust added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 11, 2022

AhmedGrati mentioned this pull request Oct 12, 2022

[Repo]: Error in Pull Request Comments Job in GitHub Actions CI for New Contributors #27209

Closed

sandeep-s-solanki approved these changes Oct 17, 2022

View reviewed changes

shogohida mentioned this pull request Oct 30, 2022

Add new data source for aws appmesh virtual node #27545

Merged

AhmedGrati added 7 commits March 14, 2023 20:02

feat(appmesh): add app mesh virtual gateway data source

2b7c662

fix(appmesh): update virtual gateway data type

84a2f55

test(appmesh): add virtual gateway data source config functions

fd990ae

test(appmesh): finish test function of virtual gateway datasource

20a7d69

update lints and semgrep

52ebc50

docs(appmesh): finish the docs of virtual gateway data source

47988c9

docs(appmesh): remove unecessary file

cc69467

AhmedGrati force-pushed the f-aws-appmesh-virtual-gateway branch from f933913 to 3db1f24 Compare March 14, 2023 19:06

github-actions bot removed the provider Pertains to the provider itself, rather than any interaction with AWS. label Mar 14, 2023

AhmedGrati force-pushed the f-aws-appmesh-virtual-gateway branch 2 times, most recently from f30c461 to 47cc909 Compare March 14, 2023 20:01

fix: update gnu make file

60cbc4b

Signed-off-by: AhmedGrati <ahmedgrati1999@gmail.com>

AhmedGrati force-pushed the f-aws-appmesh-virtual-gateway branch from 47cc909 to 60cbc4b Compare March 15, 2023 10:35

github-actions bot added the generators Relates to code generators. label Mar 15, 2023

ewbankkit added 9 commits March 23, 2023 14:27

Merge branch 'main' into HEAD

c409572

Correct CHANGELOG entry.

0765bb2

Simplify 'dataSourcePropertyFromResourceProperty'.

bd5011e

r/aws_appmesh_virtual_gateway: Alphabetize attributes.

2a88bfb

Merge branch 'main' into HEAD

ca5a3bd

r/aws_appmesh_virtual_gateway: Tidy up resource Create, Update and De…

28b456c

…lete.

r/aws_appmesh_virtual_gateway: Tidy up resource Read.

346bd2b

ewbankkit approved these changes Mar 23, 2023

View reviewed changes

Fix golangci-lint 'whitespace'.

a5652b6

ewbankkit merged commit 6196589 into hashicorp:main Mar 23, 2023

github-actions bot added this to the v4.60.0 milestone Mar 23, 2023

github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New DataSource: aws_appmesh_virtual_gateway #27057

New DataSource: aws_appmesh_virtual_gateway #27057

AhmedGrati commented Oct 2, 2022 •

edited by ewbankkit

Loading

github-actions bot commented Oct 2, 2022

github-actions bot commented Oct 2, 2022

sandeep-s-solanki left a comment

sandeep-s-solanki left a comment •

edited

Loading

AhmedGrati commented Oct 11, 2022

AhmedGrati commented Oct 11, 2022

sandeep-s-solanki commented Oct 12, 2022 •

edited

Loading

AhmedGrati commented Oct 12, 2022

AhmedGrati commented Oct 13, 2022

sandeep-s-solanki commented Oct 17, 2022

sandeep-s-solanki commented Oct 21, 2022 •

edited

Loading

AhmedGrati commented Oct 21, 2022

ewbankkit left a comment

ewbankkit commented Mar 23, 2023

github-actions bot commented Mar 24, 2023

github-actions bot commented Apr 23, 2023

New DataSource: aws_appmesh_virtual_gateway #27057

New DataSource: aws_appmesh_virtual_gateway #27057

Conversation

AhmedGrati commented Oct 2, 2022 • edited by ewbankkit Loading

Description

Relations

References

Output from Acceptance Testing

github-actions bot commented Oct 2, 2022

Community Note

github-actions bot commented Oct 2, 2022

sandeep-s-solanki left a comment

Choose a reason for hiding this comment

sandeep-s-solanki left a comment • edited Loading

Choose a reason for hiding this comment

AhmedGrati commented Oct 11, 2022

AhmedGrati commented Oct 11, 2022

sandeep-s-solanki commented Oct 12, 2022 • edited Loading

AhmedGrati commented Oct 12, 2022

AhmedGrati commented Oct 13, 2022

sandeep-s-solanki commented Oct 17, 2022

sandeep-s-solanki commented Oct 21, 2022 • edited Loading

AhmedGrati commented Oct 21, 2022

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Mar 23, 2023

github-actions bot commented Mar 24, 2023

github-actions bot commented Apr 23, 2023

AhmedGrati commented Oct 2, 2022 •

edited by ewbankkit

Loading

sandeep-s-solanki left a comment •

edited

Loading

sandeep-s-solanki commented Oct 12, 2022 •

edited

Loading

sandeep-s-solanki commented Oct 21, 2022 •

edited

Loading