Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source - AWS MediaConvert Queue #27075

Merged
merged 12 commits into from
Oct 19, 2023
Merged

New Data Source - AWS MediaConvert Queue #27075

merged 12 commits into from
Oct 19, 2023

Conversation

chrisandrews7
Copy link
Contributor

@chrisandrews7 chrisandrews7 commented Oct 3, 2022

Description

New data source for aws_media_convert_queue

Relations

#7533

References

None

Output from Acceptance Testing

$ make testacc TESTS=TestAccMediaConvertQueueDataSource PKG=mediaconvert
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/mediaconvert/... -v -count 1 -parallel 20 -run='TestAccMediaConvertQueueDataSource'  -timeout 180m
=== RUN   TestAccMediaConvertQueueDataSource_basic
=== PAUSE TestAccMediaConvertQueueDataSource_basic
=== RUN   TestAccMediaConvertQueueDataSource_withStatus
=== PAUSE TestAccMediaConvertQueueDataSource_withStatus
=== RUN   TestAccMediaConvertQueueDataSource_withTags
=== PAUSE TestAccMediaConvertQueueDataSource_withTags
=== CONT  TestAccMediaConvertQueueDataSource_basic
=== CONT  TestAccMediaConvertQueueDataSource_withTags
=== CONT  TestAccMediaConvertQueueDataSource_withStatus
--- PASS: TestAccMediaConvertQueueDataSource_withTags (107.81s)
--- PASS: TestAccMediaConvertQueueDataSource_withStatus (107.82s)
--- PASS: TestAccMediaConvertQueueDataSource_basic (109.05s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/mediaconvert    109.133s

@github-actions
Copy link

github-actions bot commented Oct 3, 2022

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/mediaconvert Issues and PRs that pertain to the mediaconvert service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Oct 3, 2022
@breathingdust breathingdust added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 11, 2022
@github-actions github-actions bot removed the provider Pertains to the provider itself, rather than any interaction with AWS. label Apr 17, 2023
@github-actions github-actions bot added generators Relates to code generators. and removed generators Relates to code generators. labels Apr 17, 2023
@chrisandrews7
Copy link
Contributor Author

@breathingdust Could this be reviewed please?
Ideally soon so it doesn't keep having merge conflicts.

@chrisandrews7
Copy link
Contributor Author

@breathingdust @jar-b @ewbankkit any timeline on when this can be merged please?

Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc TESTS=TestAccMediaConvertQueueDataSource PKG=mediaconvert
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/mediaconvert/... -v -count 1 -parallel 20 -run='TestAccMediaConvertQueueDataSource'  -timeout 360m

--- PASS: TestAccMediaConvertQueueDataSource_withStatus (92.91s)
--- PASS: TestAccMediaConvertQueueDataSource_basic (93.18s)
--- PASS: TestAccMediaConvertQueueDataSource_withTags (102.88s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/mediaconvert       106.083s

@jar-b jar-b merged commit de1f229 into hashicorp:main Oct 19, 2023
41 checks passed
@github-actions github-actions bot added this to the v5.22.0 milestone Oct 19, 2023
@jar-b
Copy link
Member

jar-b commented Oct 19, 2023

Thanks for your contribution, @chrisandrews7! 👏

Apologies for the delay in getting this merged.

@github-actions
Copy link

This functionality has been released in v5.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. service/mediaconvert Issues and PRs that pertain to the mediaconvert service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants