New aws_lb / aws_albs datasource

[mtt88]

Description

New aws_lbs/aws_albs datasource - allows user to query for all load balancers in a region and optionally filter by tags.

Relations

Closes #25687

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccELBV2LoadBalancersDataSource_basic PKG=elbv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run='TestAccELBV2LoadBalancersDataSource_basic'  -timeout 180m
=== RUN   TestAccELBV2LoadBalancersDataSource_basic
=== PAUSE TestAccELBV2LoadBalancersDataSource_basic
=== CONT  TestAccELBV2LoadBalancersDataSource_basic
--- PASS: TestAccELBV2LoadBalancersDataSource_basic (180.42s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elbv2      180.476s

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[phzietsman]

@ewbankkit @justinretzolk could you eye-ball this one, please 🙏

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccELBV2LoadBalancersDataSource_' PKG=elbv2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 3  -run=TestAccELBV2LoadBalancersDataSource_ -timeout 180m
=== RUN   TestAccELBV2LoadBalancersDataSource_basic
=== PAUSE TestAccELBV2LoadBalancersDataSource_basic
=== CONT  TestAccELBV2LoadBalancersDataSource_basic
--- PASS: TestAccELBV2LoadBalancersDataSource_basic (159.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	165.041s
% make testacc TESTARGS='-run=TestAccELBV2LoadBalancerDataSource_' PKG=elbv2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 3  -run=TestAccELBV2LoadBalancerDataSource_ -timeout 180m
=== RUN   TestAccELBV2LoadBalancerDataSource_basic
=== PAUSE TestAccELBV2LoadBalancerDataSource_basic
=== RUN   TestAccELBV2LoadBalancerDataSource_outpost
=== PAUSE TestAccELBV2LoadBalancerDataSource_outpost
=== RUN   TestAccELBV2LoadBalancerDataSource_backwardsCompatibility
=== PAUSE TestAccELBV2LoadBalancerDataSource_backwardsCompatibility
=== CONT  TestAccELBV2LoadBalancerDataSource_basic
=== CONT  TestAccELBV2LoadBalancerDataSource_backwardsCompatibility
=== CONT  TestAccELBV2LoadBalancerDataSource_outpost
    acctest.go:1368: skipping since no Outposts found
--- SKIP: TestAccELBV2LoadBalancerDataSource_outpost (0.99s)
--- PASS: TestAccELBV2LoadBalancerDataSource_backwardsCompatibility (171.48s)
--- PASS: TestAccELBV2LoadBalancerDataSource_basic (172.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	178.707s
% make testacc TESTARGS='-run=TestAccELBV2LoadBalancer_ALB_basic\|TestAccELBV2LoadBalancer_NLB_basic\|TestAccELBV2LoadBalancer_disappears' PKG=elbv2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 3  -run=TestAccELBV2LoadBalancer_ALB_basic\|TestAccELBV2LoadBalancer_NLB_basic\|TestAccELBV2LoadBalancer_disappears -timeout 180m
=== RUN   TestAccELBV2LoadBalancer_ALB_basic
=== PAUSE TestAccELBV2LoadBalancer_ALB_basic
=== RUN   TestAccELBV2LoadBalancer_NLB_basic
=== PAUSE TestAccELBV2LoadBalancer_NLB_basic
=== RUN   TestAccELBV2LoadBalancer_disappears
=== PAUSE TestAccELBV2LoadBalancer_disappears
=== CONT  TestAccELBV2LoadBalancer_ALB_basic
=== CONT  TestAccELBV2LoadBalancer_disappears
=== CONT  TestAccELBV2LoadBalancer_NLB_basic
--- PASS: TestAccELBV2LoadBalancer_disappears (147.15s)
--- PASS: TestAccELBV2LoadBalancer_ALB_basic (157.32s)
--- PASS: TestAccELBV2LoadBalancer_NLB_basic (213.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	218.912s

[ewbankkit]

@mtt88 Thanks for the contribution 🎉 👏.
In general everything was great. I removed the aws_albs alias as we are only keep the aws_alb_* resources around for backwards compatibility.

[mtt88]

Thanks for reviewing @ewbankkit

[github-actions]

This functionality has been released in v4.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.