Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_appstream_stack: Fix panic on read #27257

Merged
merged 4 commits into from
Oct 20, 2022
Merged

resource/aws_appstream_stack: Fix panic on read #27257

merged 4 commits into from
Oct 20, 2022

Conversation

gdavison
Copy link
Contributor

Reading an aws_appstream_stack causes a panic.

Adds validation and improves tests

Relations

Closes #27228

References

Output from Acceptance Testing

$ make testacc PKG=appstream TESTS=TestAccAppStreamStack_

--- PASS: TestAccAppStreamStack_basic (23.86s)
--- PASS: TestAccAppStreamStack_disappears (26.55s)
--- PASS: TestAccAppStreamStack_applicationSettings_removeFromDisabled (39.51s)
--- PASS: TestAccAppStreamStack_complete (50.26s)
--- PASS: TestAccAppStreamStack_withTags (52.54s)
--- PASS: TestAccAppStreamStack_applicationSettings_removeFromEnabled (56.85s)
--- PASS: TestAccAppStreamStack_applicationSettings_basic (78.10s)

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/appstream Issues and PRs that pertain to the appstream service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 14, 2022
ewbankkit
ewbankkit approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAppStreamStack_' PKG=appstream ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appstream/... -v -count 1 -parallel 2  -run=TestAccAppStreamStack_ -timeout 180m
=== RUN   TestAccAppStreamStack_basic
=== PAUSE TestAccAppStreamStack_basic
=== RUN   TestAccAppStreamStack_disappears
=== PAUSE TestAccAppStreamStack_disappears
=== RUN   TestAccAppStreamStack_complete
=== PAUSE TestAccAppStreamStack_complete
=== RUN   TestAccAppStreamStack_applicationSettings_basic
=== PAUSE TestAccAppStreamStack_applicationSettings_basic
=== RUN   TestAccAppStreamStack_applicationSettings_removeFromEnabled
=== PAUSE TestAccAppStreamStack_applicationSettings_removeFromEnabled
=== RUN   TestAccAppStreamStack_applicationSettings_removeFromDisabled
=== PAUSE TestAccAppStreamStack_applicationSettings_removeFromDisabled
=== RUN   TestAccAppStreamStack_withTags
=== PAUSE TestAccAppStreamStack_withTags
=== CONT  TestAccAppStreamStack_basic
=== CONT  TestAccAppStreamStack_applicationSettings_removeFromEnabled
--- PASS: TestAccAppStreamStack_basic (21.20s)
=== CONT  TestAccAppStreamStack_withTags
--- PASS: TestAccAppStreamStack_applicationSettings_removeFromEnabled (34.20s)
=== CONT  TestAccAppStreamStack_complete
--- PASS: TestAccAppStreamStack_complete (35.46s)
=== CONT  TestAccAppStreamStack_applicationSettings_basic
--- PASS: TestAccAppStreamStack_withTags (36.72s)
=== CONT  TestAccAppStreamStack_applicationSettings_removeFromDisabled
--- PASS: TestAccAppStreamStack_applicationSettings_removeFromDisabled (24.38s)
=== CONT  TestAccAppStreamStack_disappears
--- PASS: TestAccAppStreamStack_disappears (13.85s)
--- PASS: TestAccAppStreamStack_applicationSettings_basic (52.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appstream	102.175s

@gdavison gdavison merged commit 5e03789 into main Oct 20, 2022
@gdavison gdavison deleted the b-appstream-panic branch October 20, 2022 21:34
@github-actions github-actions bot added this to the v4.36.0 milestone Oct 20, 2022
@github-actions
Copy link

This functionality has been released in v4.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/appstream Issues and PRs that pertain to the appstream service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.36.0
Development

Successfully merging this pull request may close these issues.

[Bug]: Provider Crashes
2 participants
@gdavison @ewbankkit