-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: aws_lightsail_domain_entry
#27309
New Resource: aws_lightsail_domain_entry
#27309
Conversation
Removed Old resource files from before refactor
* Add the FindDomainEntryById function to find
* Added new resource domain_entry
* addd tests for the resource domain_entry
* Refactor to support new design * update docs with additional attributes * Add Import section
* Add support for importing resource
* resolve semgrep issues
* Remove AWS from function name * Remote Lightsail from function name
* update code block type
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccLightsailDomainEntry_' PKG=lightsail
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20 -run=TestAccLightsailDomainEntry_ -timeout 180m
=== RUN TestAccLightsailDomainEntry_basic
=== PAUSE TestAccLightsailDomainEntry_basic
=== RUN TestAccLightsailDomainEntry_disappears
=== PAUSE TestAccLightsailDomainEntry_disappears
=== CONT TestAccLightsailDomainEntry_basic
=== CONT TestAccLightsailDomainEntry_disappears
--- PASS: TestAccLightsailDomainEntry_basic (33.70s)
--- PASS: TestAccLightsailDomainEntry_disappears (33.86s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/lightsail 37.981s
@brittandeyoung @blckct Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR will add the new
aws_lightsail_domain_entry
resource. This will allow users to manage domain entries for Lightsail with terraform.Relations
Relates #9370
Closes #2731
References
This is a PR to refactor and revive and cover the functionality of this PR #9370. Original commits where kept in order to give credit to the original author.
Output from Acceptance Testing