Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_sqs_queue: Send any configured value of sqs_managed_sse_enabled on Create #27335

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Oct 19, 2022

Description

Always send any configured value of sqs_managed_sse_enabled when creating an SQS Queue.
In particular a configured false value is sent, which overrides the new service default value of true.

Relations

Relates #22197.
Relates #26843 (comment).

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccSQSQueue_managedEncryption\|TestAccSQSQueue_basic\|TestAccSQSQueue_encryption' PKG=sqs ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/sqs/... -v -count 1 -parallel 20  -run=TestAccSQSQueue_managedEncryption\|TestAccSQSQueue_basic\|TestAccSQSQueue_encryption -timeout 180m
=== RUN   TestAccSQSQueue_basic
=== PAUSE TestAccSQSQueue_basic
=== RUN   TestAccSQSQueue_encryption
=== PAUSE TestAccSQSQueue_encryption
=== RUN   TestAccSQSQueue_managedEncryption
=== PAUSE TestAccSQSQueue_managedEncryption
=== CONT  TestAccSQSQueue_basic
=== CONT  TestAccSQSQueue_encryption
=== CONT  TestAccSQSQueue_managedEncryption
--- PASS: TestAccSQSQueue_basic (49.88s)
--- PASS: TestAccSQSQueue_encryption (128.82s)
--- PASS: TestAccSQSQueue_managedEncryption (129.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sqs	133.199s

…d' on Create.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccSQSQueue_managedEncryption\|TestAccSQSQueue_basic\|TestAccSQSQueue_encryption' PKG=sqs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sqs/... -v -count 1 -parallel 20  -run=TestAccSQSQueue_managedEncryption\|TestAccSQSQueue_basic\|TestAccSQSQueue_encryption -timeout 180m
=== RUN   TestAccSQSQueue_basic
=== PAUSE TestAccSQSQueue_basic
=== RUN   TestAccSQSQueue_encryption
=== PAUSE TestAccSQSQueue_encryption
=== RUN   TestAccSQSQueue_managedEncryption
=== PAUSE TestAccSQSQueue_managedEncryption
=== CONT  TestAccSQSQueue_basic
=== CONT  TestAccSQSQueue_encryption
=== CONT  TestAccSQSQueue_managedEncryption
--- PASS: TestAccSQSQueue_basic (49.88s)
--- PASS: TestAccSQSQueue_encryption (128.82s)
--- PASS: TestAccSQSQueue_managedEncryption (129.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sqs	133.199s
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. service/sqs Issues and PRs that pertain to the sqs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 19, 2022
@ewbankkit ewbankkit merged commit da4b3f1 into main Oct 19, 2022
@ewbankkit ewbankkit deleted the b-aws_sqs_queue.sqs_managed_sse_enabled-pass-false branch October 19, 2022 21:01
@github-actions github-actions bot added this to the v4.36.0 milestone Oct 19, 2022
github-actions bot pushed a commit that referenced this pull request Oct 19, 2022
@github-actions
Copy link

This functionality has been released in v4.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/sqs Issues and PRs that pertain to the sqs service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant