-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data source for DX Router Configuration #27341
Add data source for DX Router Configuration #27341
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good, requesting small styling changes, no functional changes required.
internal/service/directconnect/router_configuration_data_source.go
Outdated
Show resolved
Hide resolved
internal/service/directconnect/router_configuration_data_source.go
Outdated
Show resolved
Hide resolved
internal/service/directconnect/router_configuration_data_source.go
Outdated
Show resolved
Hide resolved
internal/service/directconnect/router_configuration_data_source.go
Outdated
Show resolved
Hide resolved
internal/service/directconnect/router_configuration_data_source.go
Outdated
Show resolved
Hide resolved
internal/service/directconnect/router_configuration_data_source.go
Outdated
Show resolved
Hide resolved
internal/service/directconnect/router_configuration_data_source_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Glenn <glennchia7@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccDirectConnectRouterConfigurationDataSource_ PKG=directconnect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/directconnect/... -v -count 1 -parallel 20 -run='TestAccDirectConnectRouterConfigurationDataSource_' -timeout 180m
=== RUN TestAccDirectConnectRouterConfigurationDataSource_basic
router_configuration_data_source_test.go:17: Environment variable VIRTUAL_INTERFACE_ID is not set
--- SKIP: TestAccDirectConnectRouterConfigurationDataSource_basic (0.00s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/directconnect 4.891s
@schuylr Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds the
aws_dx_router_configuration
data source to allow users to download sample router configurations for their Direct Connect VIF.Relations
Closes #26432
References
https://docs.aws.amazon.com/directconnect/latest/UserGuide/create-vif.html#vif-router-config
https://docs.aws.amazon.com/sdk-for-go/api/service/directconnect/#DirectConnect.DescribeRouterConfiguration
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/directconnect#Client.DescribeRouterConfiguration
https://docs.aws.amazon.com/directconnect/latest/APIReference/API_DescribeRouterConfiguration.html
https://docs.aws.amazon.com/directconnect/latest/APIReference/API_RouterType.html
Output from Acceptance Testing
Note that a DX VIF must be provided via the
VIRTUAL_INTERFACE_ID
env variable.