Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for updating tags in apprunner vpc connection #27345

Merged
merged 10 commits into from
Oct 24, 2022

Conversation

kpena027
Copy link
Contributor

@kpena027 kpena027 commented Oct 20, 2022

Description

Adds the ability to modify tags for aws_apprunner_vpc_connector .

Relations

Closes #26426

References

https://pkg.go.dev/github.com/aws/aws-sdk-go@v1.44.118/service/apprunner#AppRunner.TagResource
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/apprunner_vpc_connector
https://docs.aws.amazon.com/apprunner/latest/api/API_TagResource.html

Output from Acceptance Testing

make testacc PKG=apprunner TESTS=TestAccAppRunnerVPCConnector      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 20 -run='TestAccAppRunnerVPCConnector'  -timeout 180m
=== RUN   TestAccAppRunnerVPCConnector_basic
=== PAUSE TestAccAppRunnerVPCConnector_basic
=== RUN   TestAccAppRunnerVPCConnector_disappears
=== PAUSE TestAccAppRunnerVPCConnector_disappears
=== RUN   TestAccAppRunnerVPCConnector_tags
=== PAUSE TestAccAppRunnerVPCConnector_tags
=== CONT  TestAccAppRunnerVPCConnector_basic
=== CONT  TestAccAppRunnerVPCConnector_tags
=== CONT  TestAccAppRunnerVPCConnector_disappears
--- PASS: TestAccAppRunnerVPCConnector_disappears (28.70s)
--- PASS: TestAccAppRunnerVPCConnector_basic (31.70s)
--- PASS: TestAccAppRunnerVPCConnector_tags (60.34s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/apprunner  64.399s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/apprunner Issues and PRs that pertain to the apprunner service. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Oct 20, 2022
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. tags Pertains to resource tagging. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 20, 2022
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/XS Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. labels Oct 20, 2022
@kpena027 kpena027 marked this pull request as ready for review October 20, 2022 21:59
Copy link
Contributor

@ddericco ddericco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kpena027 Thanks for the PR! Made a few suggestions. I noticed there aren't any documentation changes, but based on the issue they may not be needed - I'd recommend double-checking to be sure.

internal/service/apprunner/vpc_connector_test.go Outdated Show resolved Hide resolved
Comment on lines 187 to 189
resource "aws_subnet" "test" {
cidr_block = "10.1.1.0/24"
vpc_id = aws_vpc.test.id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there specific changes being made here? Or is this just changing the order of the resources in the function?

internal/service/apprunner/vpc_connector_test.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Oct 21, 2022
Copy link
Collaborator

@GlennChia GlennChia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good, small styling changes requested.

internal/service/apprunner/vpc_connector_test.go Outdated Show resolved Hide resolved
internal/service/apprunner/vpc_connector_test.go Outdated Show resolved Hide resolved
internal/service/apprunner/vpc_connector_test.go Outdated Show resolved Hide resolved
internal/service/apprunner/vpc_connector.go Outdated Show resolved Hide resolved
kpena027 and others added 3 commits October 21, 2022 14:20
Co-authored-by: Glenn <glennchia7@gmail.com>
…orm-provider-aws into f-apprunner-vpcconn-tags
@kpena027
Copy link
Contributor Author

@GlennChia all set

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAppRunnerVPCConnector_' PKG=apprunner ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 3  -run=TestAccAppRunnerVPCConnector_ -timeout 180m
=== RUN   TestAccAppRunnerVPCConnector_basic
=== PAUSE TestAccAppRunnerVPCConnector_basic
=== RUN   TestAccAppRunnerVPCConnector_disappears
=== PAUSE TestAccAppRunnerVPCConnector_disappears
=== RUN   TestAccAppRunnerVPCConnector_tags
=== PAUSE TestAccAppRunnerVPCConnector_tags
=== CONT  TestAccAppRunnerVPCConnector_basic
=== CONT  TestAccAppRunnerVPCConnector_tags
=== CONT  TestAccAppRunnerVPCConnector_disappears
--- PASS: TestAccAppRunnerVPCConnector_disappears (34.35s)
--- PASS: TestAccAppRunnerVPCConnector_basic (37.88s)
--- PASS: TestAccAppRunnerVPCConnector_tags (69.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	73.305s

@ewbankkit
Copy link
Contributor

@kpena027 Thanks for the contribution 🎉 👏.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Oct 24, 2022
@ewbankkit ewbankkit merged commit 7ea2bc3 into hashicorp:main Oct 24, 2022
@github-actions github-actions bot added this to the v4.37.0 milestone Oct 24, 2022
@github-actions
Copy link

This functionality has been released in v4.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/apprunner Issues and PRs that pertain to the apprunner service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_apprunner_vpc_connector doesn't support update
4 participants