-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add usage_mode
to support short-lived certificates
#27496
Add usage_mode
to support short-lived certificates
#27496
Conversation
Community NoteVoting for Prioritization
For Submitters
|
usage_mode
to support short lived certificatesusage_mode
to support short-lived certificates
Could the respective reviewer please run all the respective tests, I've just ran |
…c' in acceptance tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccACMPCACertificateAuthority_basic\|TestAccACMPCACertificateAuthority_usageMode\|TestAccACMPCACertificateAuthority_deleteFromActiveState\|TestAccACMPCACertificateAuthorityDataSource_' PKG=acmpca ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/acmpca/... -v -count 1 -parallel 3 -run=TestAccACMPCACertificateAuthority_basic\|TestAccACMPCACertificateAuthority_usageMode\|TestAccACMPCACertificateAuthority_deleteFromActiveState\|TestAccACMPCACertificateAuthorityDataSource_ -timeout 180m
=== RUN TestAccACMPCACertificateAuthorityDataSource_basic
=== PAUSE TestAccACMPCACertificateAuthorityDataSource_basic
=== RUN TestAccACMPCACertificateAuthorityDataSource_s3ObjectACL
=== PAUSE TestAccACMPCACertificateAuthorityDataSource_s3ObjectACL
=== RUN TestAccACMPCACertificateAuthority_basic
=== PAUSE TestAccACMPCACertificateAuthority_basic
=== RUN TestAccACMPCACertificateAuthority_usageMode
=== PAUSE TestAccACMPCACertificateAuthority_usageMode
=== RUN TestAccACMPCACertificateAuthority_deleteFromActiveState
=== PAUSE TestAccACMPCACertificateAuthority_deleteFromActiveState
=== CONT TestAccACMPCACertificateAuthorityDataSource_basic
=== CONT TestAccACMPCACertificateAuthority_usageMode
=== CONT TestAccACMPCACertificateAuthority_basic
--- PASS: TestAccACMPCACertificateAuthority_usageMode (22.13s)
=== CONT TestAccACMPCACertificateAuthorityDataSource_s3ObjectACL
--- PASS: TestAccACMPCACertificateAuthority_basic (22.35s)
=== CONT TestAccACMPCACertificateAuthority_deleteFromActiveState
--- PASS: TestAccACMPCACertificateAuthorityDataSource_basic (23.32s)
--- PASS: TestAccACMPCACertificateAuthorityDataSource_s3ObjectACL (20.72s)
--- PASS: TestAccACMPCACertificateAuthority_deleteFromActiveState (21.43s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/acmpca 47.820s
@bschaatsbergen Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Add a new argument:
usage_mode
to resource:aws_acmpca_certificate_authority
to support short-lived certificates.Relations
Closes #27491
References
Output from Acceptance Testing