Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tiered storage to Amazon MSK #27546

Merged
merged 13 commits into from
Nov 11, 2022

Conversation

bschaatsbergen
Copy link
Member

@bschaatsbergen bschaatsbergen commented Oct 30, 2022

Description

Adds support for tiered storage in Amazon MSK.

Relations

Closes #27540

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccKafkaCluster_basic\|TestAccKafkaCluster_storageMode PKG=kafka
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kafka/... -v -count 1 -parallel 20 -run='TestAccKafkaCluster_basic|TestAccKafkaCluster_storageMode'  -timeout 180m
=== RUN   TestAccKafkaCluster_basic
=== PAUSE TestAccKafkaCluster_basic
=== RUN   TestAccKafkaCluster_storageMode
=== PAUSE TestAccKafkaCluster_storageMode
=== CONT  TestAccKafkaCluster_basic
=== CONT  TestAccKafkaCluster_storageMode
--- PASS: TestAccKafkaCluster_basic (999.97s)
--- PASS: TestAccKafkaCluster_storageMode (1877.88s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/kafka      1879.662s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/kafka Issues and PRs that pertain to the kafka service. labels Oct 30, 2022
@jar-b jar-b added needs-triage Waiting for first response or review from a maintainer. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 31, 2022
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 1, 2022
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/XS Managed by automation to categorize the size of a PR. labels Nov 2, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Nov 2, 2022
@bschaatsbergen bschaatsbergen marked this pull request as ready for review November 8, 2022 16:35
@bschaatsbergen bschaatsbergen changed the title [WIP] Amazon MSK Storage Mode Amazon MSK Storage Mode Nov 8, 2022
@bschaatsbergen bschaatsbergen changed the title Amazon MSK Storage Mode Add Tiered storage to Amazon MSK Nov 8, 2022
@bschaatsbergen bschaatsbergen marked this pull request as draft November 8, 2022 19:38
@bschaatsbergen
Copy link
Member Author

Need to run tests... high likely doing that tomorrow.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Nov 10, 2022
@bschaatsbergen bschaatsbergen marked this pull request as ready for review November 10, 2022 20:20
@bschaatsbergen
Copy link
Member Author

Ready for review :)

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccKafkaCluster_basic\|TestAccKafkaCluster_storageMode PKG=kafka
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kafka/... -v -count 1 -parallel 20 -run='TestAccKafkaCluster_basic|TestAccKafkaCluster_storageMode'  -timeout 180m
=== RUN   TestAccKafkaCluster_basic
=== PAUSE TestAccKafkaCluster_basic
=== RUN   TestAccKafkaCluster_storageMode
=== PAUSE TestAccKafkaCluster_storageMode
=== CONT  TestAccKafkaCluster_basic
=== CONT  TestAccKafkaCluster_storageMode
--- PASS: TestAccKafkaCluster_basic (1781.56s)
--- PASS: TestAccKafkaCluster_storageMode (2716.12s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kafka	2721.649s

@ewbankkit
Copy link
Contributor

@bschaatsbergen Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit f46bb68 into hashicorp:main Nov 11, 2022
@github-actions github-actions bot added this to the v4.40.0 milestone Nov 11, 2022
@trevorpburke
Copy link

@ewbankkit do you know roughly when v4.40.0 might be added to the TF registry? looks like aws is still on v4.39.0

@bschaatsbergen
Copy link
Member Author

We aim to release every week @trevorpburke around Thursday.

@bschaatsbergen bschaatsbergen deleted the storage-mode-kafka-cluster branch November 16, 2022 08:29
@github-actions
Copy link

This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/kafka Issues and PRs that pertain to the kafka service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Support for Amazon MSK Tiered storage
5 participants