-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tiered storage to Amazon MSK #27546
Add Tiered storage to Amazon MSK #27546
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Need to run tests... high likely doing that tomorrow. |
Ready for review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccKafkaCluster_basic\|TestAccKafkaCluster_storageMode PKG=kafka
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kafka/... -v -count 1 -parallel 20 -run='TestAccKafkaCluster_basic|TestAccKafkaCluster_storageMode' -timeout 180m
=== RUN TestAccKafkaCluster_basic
=== PAUSE TestAccKafkaCluster_basic
=== RUN TestAccKafkaCluster_storageMode
=== PAUSE TestAccKafkaCluster_storageMode
=== CONT TestAccKafkaCluster_basic
=== CONT TestAccKafkaCluster_storageMode
--- PASS: TestAccKafkaCluster_basic (1781.56s)
--- PASS: TestAccKafkaCluster_storageMode (2716.12s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/kafka 2721.649s
@bschaatsbergen Thanks for the contribution 🎉 👏. |
@ewbankkit do you know roughly when v4.40.0 might be added to the TF registry? looks like aws is still on v4.39.0 |
We aim to release every week @trevorpburke around Thursday. |
This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds support for tiered storage in Amazon MSK.
Relations
Closes #27540
References
Output from Acceptance Testing