-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d/aws_ip_ranges: Case insensitive comparison for regions
and services
#27558
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc TESTARGS='-run=TestAccMetaIPRangesDataSource_' PKG=meta ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/meta/... -v -count 1 -parallel 3 -run=TestAccMetaIPRangesDataSource_ -timeout 180m
=== RUN TestAccMetaIPRangesDataSource_basic
=== PAUSE TestAccMetaIPRangesDataSource_basic
=== RUN TestAccMetaIPRangesDataSource_none
=== PAUSE TestAccMetaIPRangesDataSource_none
=== RUN TestAccMetaIPRangesDataSource_url
=== PAUSE TestAccMetaIPRangesDataSource_url
=== RUN TestAccMetaIPRangesDataSource_uppercase
=== PAUSE TestAccMetaIPRangesDataSource_uppercase
=== CONT TestAccMetaIPRangesDataSource_basic
=== CONT TestAccMetaIPRangesDataSource_url
=== CONT TestAccMetaIPRangesDataSource_uppercase
--- PASS: TestAccMetaIPRangesDataSource_basic (14.47s)
=== CONT TestAccMetaIPRangesDataSource_none
--- PASS: TestAccMetaIPRangesDataSource_url (14.66s)
--- PASS: TestAccMetaIPRangesDataSource_uppercase (14.67s)
--- PASS: TestAccMetaIPRangesDataSource_none (11.73s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/meta 27.551s
This functionality has been released in v4.38.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Fixes a regression introduced in #27221 whereby comparisons for
regions
andservices
became case-sensitive.Relations
Closes #27554.
Output from Acceptance Testing