-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_sfn_state_machine: Add name_prefix
argument
#27574
Conversation
Acceptance test output: % make testacc TESTARGS='-run=TestAccSFNActivity_' PKG=sfn ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/sfn/... -v -count 1 -parallel 3 -run=TestAccSFNActivity_ -timeout 180m === RUN TestAccSFNActivity_basic === PAUSE TestAccSFNActivity_basic === RUN TestAccSFNActivity_tags === PAUSE TestAccSFNActivity_tags === CONT TestAccSFNActivity_basic === CONT TestAccSFNActivity_tags --- PASS: TestAccSFNActivity_basic (19.98s) === CONT TestAccSFNActivity_tags testing_new.go:84: Error running post-test destroy, there may be dangling resources: Step Function Activity still exists: arn:aws:states:us-west-2:067819342479:activity:tf-acc-test-4936253122607672332 --- FAIL: TestAccSFNActivity_tags (44.45s) FAIL FAIL github.com/hashicorp/terraform-provider-aws/internal/service/sfn 48.442s FAIL make: *** [testacc] Error 1
Acceptance test output: % make testacc TESTARGS='-run=TestAccSFNActivity_' PKG=sfn ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/sfn/... -v -count 1 -parallel 3 -run=TestAccSFNActivity_ -timeout 180m === RUN TestAccSFNActivity_basic === PAUSE TestAccSFNActivity_basic === RUN TestAccSFNActivity_tags === PAUSE TestAccSFNActivity_tags === CONT TestAccSFNActivity_basic === CONT TestAccSFNActivity_tags --- PASS: TestAccSFNActivity_tags (69.59s) --- PASS: TestAccSFNActivity_basic (74.98s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/sfn 79.335s
Acceptance test output: % SWF_DOMAIN_TESTING_ENABLED=1 make testacc TESTARGS='-run=TestAccSWFDomain_' PKG=swf ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/swf/... -v -count 1 -parallel 3 -run=TestAccSWFDomain_ -timeout 180m === RUN TestAccSWFDomain_basic === PAUSE TestAccSWFDomain_basic === RUN TestAccSWFDomain_nameGenerated === PAUSE TestAccSWFDomain_nameGenerated === RUN TestAccSWFDomain_namePrefix === PAUSE TestAccSWFDomain_namePrefix === RUN TestAccSWFDomain_tags === PAUSE TestAccSWFDomain_tags === RUN TestAccSWFDomain_description === PAUSE TestAccSWFDomain_description === CONT TestAccSWFDomain_basic === CONT TestAccSWFDomain_tags === CONT TestAccSWFDomain_description --- PASS: TestAccSWFDomain_description (20.60s) === CONT TestAccSWFDomain_namePrefix --- PASS: TestAccSWFDomain_basic (21.20s) === CONT TestAccSWFDomain_nameGenerated --- PASS: TestAccSWFDomain_namePrefix (18.86s) --- PASS: TestAccSWFDomain_nameGenerated (18.78s) --- PASS: TestAccSWFDomain_tags (46.25s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/swf 50.504s
Acceptance test output: % make testacc TESTARGS='-run=TestAccSFNActivity_' PKG=sfn ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/sfn/... -v -count 1 -parallel 3 -run=TestAccSFNActivity_ -timeout 180m === RUN TestAccSFNActivity_basic === PAUSE TestAccSFNActivity_basic === RUN TestAccSFNActivity_tags === PAUSE TestAccSFNActivity_tags === CONT TestAccSFNActivity_basic === CONT TestAccSFNActivity_tags --- PASS: TestAccSFNActivity_basic (19.31s) --- PASS: TestAccSFNActivity_tags (69.13s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/sfn 73.319s
Acceptance test output: % make testacc TESTARGS='-run=TestAccSFNActivityDataSource_' PKG=sfn ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/sfn/... -v -count 1 -parallel 3 -run=TestAccSFNActivityDataSource_ -timeout 180m === RUN TestAccSFNActivityDataSource_basic === PAUSE TestAccSFNActivityDataSource_basic === CONT TestAccSFNActivityDataSource_basic --- PASS: TestAccSFNActivityDataSource_basic (26.80s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/sfn 30.968s
Acceptance test output: % make testacc TESTARGS='-run=TestAccSFNStateMachine_' PKG=sfn ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/sfn/... -v -count 1 -parallel 3 -run=TestAccSFNStateMachine_ -timeout 180m === RUN TestAccSFNStateMachine_createUpdate === PAUSE TestAccSFNStateMachine_createUpdate === RUN TestAccSFNStateMachine_expressUpdate === PAUSE TestAccSFNStateMachine_expressUpdate === RUN TestAccSFNStateMachine_standardUpdate === PAUSE TestAccSFNStateMachine_standardUpdate === RUN TestAccSFNStateMachine_tags === PAUSE TestAccSFNStateMachine_tags === RUN TestAccSFNStateMachine_tracing === PAUSE TestAccSFNStateMachine_tracing === RUN TestAccSFNStateMachine_disappears === PAUSE TestAccSFNStateMachine_disappears === RUN TestAccSFNStateMachine_expressLogging === PAUSE TestAccSFNStateMachine_expressLogging === CONT TestAccSFNStateMachine_createUpdate === CONT TestAccSFNStateMachine_tracing === CONT TestAccSFNStateMachine_standardUpdate --- PASS: TestAccSFNStateMachine_createUpdate (101.37s) === CONT TestAccSFNStateMachine_tags --- PASS: TestAccSFNStateMachine_standardUpdate (102.78s) === CONT TestAccSFNStateMachine_expressLogging --- PASS: TestAccSFNStateMachine_tracing (107.31s) === CONT TestAccSFNStateMachine_expressUpdate --- PASS: TestAccSFNStateMachine_expressLogging (127.65s) === CONT TestAccSFNStateMachine_disappears --- PASS: TestAccSFNStateMachine_tags (132.07s) --- PASS: TestAccSFNStateMachine_expressUpdate (127.97s) --- PASS: TestAccSFNStateMachine_disappears (84.75s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/sfn 319.585s
…5090). Acceptance test output: % make testacc TESTARGS='-run=TestAccSFNStateMachine_' PKG=sfn ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/sfn/... -v -count 1 -parallel 3 -run=TestAccSFNStateMachine_ -timeout 180m === RUN TestAccSFNStateMachine_createUpdate === PAUSE TestAccSFNStateMachine_createUpdate === RUN TestAccSFNStateMachine_expressUpdate === PAUSE TestAccSFNStateMachine_expressUpdate === RUN TestAccSFNStateMachine_standardUpdate === PAUSE TestAccSFNStateMachine_standardUpdate === RUN TestAccSFNStateMachine_tags === PAUSE TestAccSFNStateMachine_tags === RUN TestAccSFNStateMachine_tracing === PAUSE TestAccSFNStateMachine_tracing === RUN TestAccSFNStateMachine_disappears === PAUSE TestAccSFNStateMachine_disappears === RUN TestAccSFNStateMachine_expressLogging === PAUSE TestAccSFNStateMachine_expressLogging === CONT TestAccSFNStateMachine_createUpdate === CONT TestAccSFNStateMachine_tracing === CONT TestAccSFNStateMachine_expressLogging --- PASS: TestAccSFNStateMachine_createUpdate (102.69s) === CONT TestAccSFNStateMachine_disappears --- PASS: TestAccSFNStateMachine_tracing (107.93s) === CONT TestAccSFNStateMachine_standardUpdate --- PASS: TestAccSFNStateMachine_expressLogging (109.37s) === CONT TestAccSFNStateMachine_tags --- PASS: TestAccSFNStateMachine_standardUpdate (71.73s) === CONT TestAccSFNStateMachine_expressUpdate --- PASS: TestAccSFNStateMachine_disappears (84.48s) --- PASS: TestAccSFNStateMachine_expressUpdate (62.61s) --- PASS: TestAccSFNStateMachine_tags (135.87s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/sfn 249.652s
Acceptance test output: % make testacc TESTARGS='-run=TestAccSFNActivity_disappears' PKG=sfn ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/sfn/... -v -count 1 -parallel 3 -run=TestAccSFNActivity_disappears -timeout 180m === RUN TestAccSFNActivity_disappears === PAUSE TestAccSFNActivity_disappears === CONT TestAccSFNActivity_disappears --- PASS: TestAccSFNActivity_disappears (23.30s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/sfn 37.425s
…5090). Acceptance test output: % make testacc TESTARGS='-run=TestAccSFNStateMachineDataSource_' PKG=sfn ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/sfn/... -v -count 1 -parallel 3 -run=TestAccSFNStateMachineDataSource_ -timeout 180m === RUN TestAccSFNStateMachineDataSource_basic === PAUSE TestAccSFNStateMachineDataSource_basic === CONT TestAccSFNStateMachineDataSource_basic --- PASS: TestAccSFNStateMachineDataSource_basic (67.16s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/sfn 71.512s
Acceptance test output: % make sweep SWEEPARGS=-sweep-run=aws_sfn_activity,aws_sfn_state_machine WARNING: This will destroy infrastructure. Use only in development accounts. go test ./internal/sweep -v -tags=sweep -sweep=us-west-2,us-east-1,us-east-2 -sweep-run=aws_sfn_activity,aws_sfn_state_machine -timeout 60m 2022/11/01 09:38:06 [DEBUG] Running Sweepers for region (us-west-2): 2022/11/01 09:38:06 [DEBUG] Running Sweeper (aws_sfn_activity) in region (us-west-2) 2022/11/01 09:38:06 [INFO] Retrieved credentials from "EnvConfigCredentials" 2022/11/01 09:38:06 [DEBUG] Trying to get account information via sts:GetCallerIdentity 2022/11/01 09:38:06 [DEBUG] Trying to get account information via sts:GetCallerIdentity 2022/11/01 09:38:07 [DEBUG] Waiting for state to become: [success] 2022/11/01 09:38:07 [DEBUG] Waiting for state to become: [success] 2022/11/01 09:38:07 [DEBUG] Deleting Step Functions Activity: arn:aws:states:us-west-2:123456789012:activity:8insfll7bk 2022/11/01 09:38:07 [DEBUG] Waiting for state to become: [success] 2022/11/01 09:38:07 [DEBUG] Deleting Step Functions Activity: arn:aws:states:us-west-2:123456789012:activity:tqkwct7ni8 2022/11/01 09:38:07 [DEBUG] Deleting Step Functions Activity: arn:aws:states:us-west-2:123456789012:activity:z8emyrl6 2022/11/01 09:38:08 [DEBUG] Completed Sweeper (aws_sfn_activity) in region (us-west-2) in 2.039239611s 2022/11/01 09:38:08 [DEBUG] Running Sweeper (aws_sfn_state_machine) in region (us-west-2) 2022/11/01 09:38:08 [DEBUG] Waiting for state to become: [success] 2022/11/01 09:38:08 [DEBUG] Deleting Step Functions State Machine: arn:aws:states:us-west-2:123456789012:stateMachine:tf-acc-test-2233972156310038186 2022/11/01 09:38:08 [DEBUG] Waiting for state to become: [] 2022/11/01 09:38:08 [TRACE] Waiting 200ms before next try 2022/11/01 09:38:09 [TRACE] Waiting 400ms before next try 2022/11/01 09:38:09 [TRACE] Waiting 800ms before next try 2022/11/01 09:38:10 [TRACE] Waiting 1.6s before next try 2022/11/01 09:38:12 [TRACE] Waiting 3.2s before next try 2022/11/01 09:38:15 [TRACE] Waiting 6.4s before next try 2022/11/01 09:38:22 [TRACE] Waiting 10s before next try 2022/11/01 09:38:32 [TRACE] Waiting 10s before next try 2022/11/01 09:38:42 [DEBUG] Completed Sweeper (aws_sfn_state_machine) in region (us-west-2) in 33.905723812s 2022/11/01 09:38:42 Completed Sweepers for region (us-west-2) in 35.945206544s 2022/11/01 09:38:42 Sweeper Tests for region (us-west-2) ran successfully: - aws_sfn_activity - aws_sfn_state_machine 2022/11/01 09:38:42 [DEBUG] Running Sweepers for region (us-east-1): 2022/11/01 09:38:42 [DEBUG] Running Sweeper (aws_sfn_activity) in region (us-east-1) 2022/11/01 09:38:42 [INFO] Retrieved credentials from "EnvConfigCredentials" 2022/11/01 09:38:42 [DEBUG] Trying to get account information via sts:GetCallerIdentity 2022/11/01 09:38:42 [DEBUG] Trying to get account information via sts:GetCallerIdentity 2022/11/01 09:38:43 [DEBUG] Completed Sweeper (aws_sfn_activity) in region (us-east-1) in 781.40589ms 2022/11/01 09:38:43 [DEBUG] Running Sweeper (aws_sfn_state_machine) in region (us-east-1) 2022/11/01 09:38:43 [DEBUG] Completed Sweeper (aws_sfn_state_machine) in region (us-east-1) in 40.949297ms 2022/11/01 09:38:43 Completed Sweepers for region (us-east-1) in 822.40173ms 2022/11/01 09:38:43 Sweeper Tests for region (us-east-1) ran successfully: - aws_sfn_state_machine - aws_sfn_activity 2022/11/01 09:38:43 [DEBUG] Running Sweepers for region (us-east-2): 2022/11/01 09:38:43 [DEBUG] Running Sweeper (aws_sfn_activity) in region (us-east-2) 2022/11/01 09:38:43 [INFO] Retrieved credentials from "EnvConfigCredentials" 2022/11/01 09:38:43 [DEBUG] Trying to get account information via sts:GetCallerIdentity 2022/11/01 09:38:43 [DEBUG] Trying to get account information via sts:GetCallerIdentity 2022/11/01 09:38:43 [DEBUG] Completed Sweeper (aws_sfn_activity) in region (us-east-2) in 664.725939ms 2022/11/01 09:38:43 [DEBUG] Running Sweeper (aws_sfn_state_machine) in region (us-east-2) 2022/11/01 09:38:43 [DEBUG] Completed Sweeper (aws_sfn_state_machine) in region (us-east-2) in 51.677755ms 2022/11/01 09:38:43 Completed Sweepers for region (us-east-2) in 716.453528ms 2022/11/01 09:38:43 Sweeper Tests for region (us-east-2) ran successfully: - aws_sfn_activity - aws_sfn_state_machine ok github.com/hashicorp/terraform-provider-aws/internal/sweep 42.533s
Acceptance test output: % make testacc TESTARGS='-run=TestAccSFNStateMachine_' PKG=sfn ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/sfn/... -v -count 1 -parallel 3 -run=TestAccSFNStateMachine_ -timeout 180m === RUN TestAccSFNStateMachine_createUpdate === PAUSE TestAccSFNStateMachine_createUpdate === RUN TestAccSFNStateMachine_expressUpdate === PAUSE TestAccSFNStateMachine_expressUpdate === RUN TestAccSFNStateMachine_standardUpdate === PAUSE TestAccSFNStateMachine_standardUpdate === RUN TestAccSFNStateMachine_nameGenerated === PAUSE TestAccSFNStateMachine_nameGenerated === RUN TestAccSFNStateMachine_namePrefix === PAUSE TestAccSFNStateMachine_namePrefix === RUN TestAccSFNStateMachine_tags === PAUSE TestAccSFNStateMachine_tags === RUN TestAccSFNStateMachine_tracing === PAUSE TestAccSFNStateMachine_tracing === RUN TestAccSFNStateMachine_disappears === PAUSE TestAccSFNStateMachine_disappears === RUN TestAccSFNStateMachine_expressLogging === PAUSE TestAccSFNStateMachine_expressLogging === CONT TestAccSFNStateMachine_createUpdate === CONT TestAccSFNStateMachine_tags === CONT TestAccSFNStateMachine_disappears --- PASS: TestAccSFNStateMachine_createUpdate (83.80s) === CONT TestAccSFNStateMachine_expressLogging --- PASS: TestAccSFNStateMachine_disappears (86.70s) === CONT TestAccSFNStateMachine_tracing --- PASS: TestAccSFNStateMachine_expressLogging (62.77s) === CONT TestAccSFNStateMachine_nameGenerated --- PASS: TestAccSFNStateMachine_tags (154.33s) === CONT TestAccSFNStateMachine_namePrefix --- PASS: TestAccSFNStateMachine_tracing (126.12s) === CONT TestAccSFNStateMachine_standardUpdate --- PASS: TestAccSFNStateMachine_nameGenerated (66.47s) === CONT TestAccSFNStateMachine_expressUpdate --- PASS: TestAccSFNStateMachine_namePrefix (64.44s) --- PASS: TestAccSFNStateMachine_expressUpdate (68.11s) --- PASS: TestAccSFNStateMachine_standardUpdate (68.53s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/sfn 285.690s
Community NoteVoting for Prioritization
For Submitters
|
This functionality has been released in v4.38.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds the
name_prefix
argument using the standard resource name generation pattern.Relations
Closes #19485.
Output from Acceptance Testing