-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add import of aws_ses_active_receipt_rule_set
resource
#27604
Add import of aws_ses_active_receipt_rule_set
resource
#27604
Conversation
Community NoteVoting for Prioritization
For Submitters
|
57ab30f
to
7511ca5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@kamilturek @ewbankkit Is there anything I can do to help with this PR merge? |
7511ca5
to
b04f424
Compare
b04f424
to
ed0730e
Compare
Conflicts resolved.
|
aws_ses_active_receipt_rule_set
resourceaws_ses_active_receipt_rule_set
resource
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
$ make testacc PKG=ses TESTS=TestAccSESActiveReceiptRuleSet_serial
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ses/... -v -count 1 -parallel 20 -run='TestAccSESActiveReceiptRuleSet_serial' -timeout 180m
=== RUN TestAccSESActiveReceiptRuleSet_serial
=== PAUSE TestAccSESActiveReceiptRuleSet_serial
=== CONT TestAccSESActiveReceiptRuleSet_serial
=== RUN TestAccSESActiveReceiptRuleSet_serial/Resource
=== RUN TestAccSESActiveReceiptRuleSet_serial/Resource/basic
=== RUN TestAccSESActiveReceiptRuleSet_serial/Resource/disappears
=== RUN TestAccSESActiveReceiptRuleSet_serial/DataSource
=== RUN TestAccSESActiveReceiptRuleSet_serial/DataSource/basic
=== RUN TestAccSESActiveReceiptRuleSet_serial/DataSource/noActiveRuleSet
--- PASS: TestAccSESActiveReceiptRuleSet_serial (50.98s)
--- PASS: TestAccSESActiveReceiptRuleSet_serial/Resource (32.66s)
--- PASS: TestAccSESActiveReceiptRuleSet_serial/Resource/basic (18.04s)
--- PASS: TestAccSESActiveReceiptRuleSet_serial/Resource/disappears (14.62s)
--- PASS: TestAccSESActiveReceiptRuleSet_serial/DataSource (18.32s)
--- PASS: TestAccSESActiveReceiptRuleSet_serial/DataSource/basic (15.94s)
--- PASS: TestAccSESActiveReceiptRuleSet_serial/DataSource/noActiveRuleSet (2.37s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ses 54.441s
Thanks for your contribution, @yktakaha4! 👍 |
This functionality has been released in v5.5.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Enable Import with the following command.
As a specification of SES, only one active receipt rule set is valid within the same region.
describe-active-receipt-rule-set
AWS API cannot take any arguments and return an active rule set when called.Import command will succeed only if the rule_set_name passed matches the API return value.
ref: https://docs.aws.amazon.com/cli/latest/reference/ses/describe-active-receipt-rule-set.html
Relations
Closes #29369
References
If no Active ruleset exists, Import will fail.
Import will also fail if the ruleset names do not match.
If rule_set_name matches,
Output from Acceptance Testing
In my local.