Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add gp3 storage_type support to aws_db_instance #27702

Closed
katdev opened this issue Nov 8, 2022 · 11 comments · Fixed by #27670
Closed

[Enhancement]: Add gp3 storage_type support to aws_db_instance #27702

katdev opened this issue Nov 8, 2022 · 11 comments · Fixed by #27670
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Milestone

Comments

@katdev
Copy link

katdev commented Nov 8, 2022

Description

As of November 4(ish), the gp3 storage type is now supported on RDS, but it's not yet supported by the latest version of the AWS provider. Attempting to specify gp3 results in:

│ Error: expected storage_type to be one of [standard gp2 io1], got gp3
│ 
│   with aws_db_instance.db_instance,
│   on .terraform/main.tf line 67, in resource "aws_db_instance" "db_instance":67:   storage_type                        = "gp3"

Please add support to the AWS provider for this storage type, along with support for the advanced settings available with gp3, Provisioned IOPS and Storage throughput.

Affected Resource(s) and/or Data Source(s)

aws_db_instance

Potential Terraform Configuration

resource "aws_db_instance" "default" {
  ...
  allocated_storage    = 10
  storage_type         = "gp3"
  provisioned_iops     = 12000
  storage_throughput   = 500
}

References

Announcement.
User guide.

Would you like to implement a fix?

No, thank you

@katdev katdev added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Nov 8, 2022
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/rds Issues and PRs that pertain to the rds service. label Nov 8, 2022
@bschaatsbergen
Copy link
Member

Hi @katdev, thanks for raising this issue. I'll pick it up 👍

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Nov 8, 2022
@bschaatsbergen
Copy link
Member

Fixed by @erz4 in #27670 👏

@FouzanAshraf
Copy link

The same issue lies in Ansible rds_instance module too. It is not supporting creation of new RDS instance when passing storage type as gp3. Any fixes for that ?

@theintz
Copy link

theintz commented Nov 23, 2022

The same issue lies in Ansible rds_instance module too. It is not supporting creation of new RDS instance when passing storage type as gp3. Any fixes for that ?

You should probably ask that question in the Ansible repo :)

@rodrigoechaide
Copy link

Hello! What about this issue? Is somebody working on it?

@etiennechabert
Copy link

See this PR and comment: #27670 (review)

My understanding is that @gdavison and his team might take over the PR that @erz4 started

@github-actions github-actions bot added this to the v4.45.0 milestone Dec 1, 2022
@github-actions
Copy link

github-actions bot commented Dec 2, 2022

This functionality has been released in v4.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@DanielViglione
Copy link

talk about perfect timing! gp3 for rds is exactly what I wanted.

@etiennechabert
Copy link

Foremost, thanks a lot for bringing this change that quickly @ewbankkit, and @erz4 as well as everyone involved 👏

Sadly, it seems that there is a bug for existing RDS instances blocking the switch from gp2 to gp3, you will most likely be blocked by this error:

InvalidParameterCombination: You can't specify IOPS or storage throughput for engine postgres and a storage size less than 400

FYI, an issue already exists for this bug: #28160

Maybe you want to give your 👍 there, if this is also a blocker for you.

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Projects
None yet
8 participants