r/aws_transfer_server - support on_partial_upload block on workflow_details

[mtt88]

Description

A couple of small improvements to the workflow_details attribute on r/aws_transfer_server

• Adds additional validation around removal of workflow_details
• Adds support for on_partial_upload workflow detail attribute

Relations

Closes #27657

References

Docs for on_partial_upload parameter.

Output from Acceptance Testing

Note - I changed the visibility of the TestAccServer_workflowDetails test to allow execution in isolation. It would
be great to get some assistance running the entire transfer test suite.

make testacc TESTS=TestAccServer_workflowDetails PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20 -run='TestAccServer_workflowDetails'  -timeout 180m
=== RUN   TestAccServer_workflowDetails
--- PASS: TestAccServer_workflowDetails (233.89s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/transfer   233.954s


...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccTransfer_serial/Server' PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20  -run=TestAccTransfer_serial/Server -timeout 180m
=== RUN   TestAccTransfer_serial
=== PAUSE TestAccTransfer_serial
=== CONT  TestAccTransfer_serial
=== RUN   TestAccTransfer_serial/Server
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCSecurityGroupIDs
=== RUN   TestAccTransfer_serial/Server/DataSourceBasic
=== RUN   TestAccTransfer_serial/Server/LambdaFunction
=== RUN   TestAccTransfer_serial/Server/Protocols
=== RUN   TestAccTransfer_serial/Server/SecurityPolicy
=== RUN   TestAccTransfer_serial/Server/DataSourceServiceManaged
=== RUN   TestAccTransfer_serial/Server/Domain
=== RUN   TestAccTransfer_serial/Server/HostKey
=== RUN   TestAccTransfer_serial/Server/DataSourceAPIGateway
=== RUN   TestAccTransfer_serial/Server/APIGatewayForceDestroy
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypeVPCToPublic
=== RUN   TestAccTransfer_serial/Server/tags
=== RUN   TestAccTransfer_serial/Server/disappears
=== RUN   TestAccTransfer_serial/Server/ForceDestroy
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPC
=== RUN   TestAccTransfer_serial/Server/VPC
=== RUN   TestAccTransfer_serial/Server/VPCAddressAllocationIDs
=== RUN   TestAccTransfer_serial/Server/basic
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypePublicToVPC
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCAddressAllocationIDs
=== RUN   TestAccTransfer_serial/Server/VPCAddressAllocationIDsSecurityGroupIDs
=== RUN   TestAccTransfer_serial/Server/VPCSecurityGroupIDs
=== RUN   TestAccTransfer_serial/Server/Workflow
=== RUN   TestAccTransfer_serial/Server/AuthenticationLoginBanners
=== RUN   TestAccTransfer_serial/Server/VPCEndpointID
=== RUN   TestAccTransfer_serial/Server/DirectoryService
=== RUN   TestAccTransfer_serial/Server/UpdateEndpointTypePublicToVPCAddressAllocationIDs
=== RUN   TestAccTransfer_serial/Server/APIGateway
--- PASS: TestAccTransfer_serial (6367.64s)
    --- PASS: TestAccTransfer_serial/Server (6367.64s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCSecurityGroupIDs (117.03s)
        --- PASS: TestAccTransfer_serial/Server/DataSourceBasic (187.90s)
        --- PASS: TestAccTransfer_serial/Server/LambdaFunction (217.70s)
        --- PASS: TestAccTransfer_serial/Server/Protocols (267.74s)
        --- PASS: TestAccTransfer_serial/Server/SecurityPolicy (179.30s)
        --- PASS: TestAccTransfer_serial/Server/DataSourceServiceManaged (189.06s)
        --- PASS: TestAccTransfer_serial/Server/Domain (161.19s)
        --- PASS: TestAccTransfer_serial/Server/HostKey (189.98s)
        --- PASS: TestAccTransfer_serial/Server/DataSourceAPIGateway (191.51s)
        --- PASS: TestAccTransfer_serial/Server/APIGatewayForceDestroy (195.72s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypeVPCToPublic (219.05s)
        --- PASS: TestAccTransfer_serial/Server/tags (185.82s)
        --- PASS: TestAccTransfer_serial/Server/disappears (186.55s)
        --- PASS: TestAccTransfer_serial/Server/ForceDestroy (195.08s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPC (148.61s)
        --- PASS: TestAccTransfer_serial/Server/VPC (190.75s)
        --- PASS: TestAccTransfer_serial/Server/VPCAddressAllocationIDs (263.16s)
        --- PASS: TestAccTransfer_serial/Server/basic (200.92s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypePublicToVPC (257.35s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypeVPCEndpointToVPCAddressAllocationIDs (328.39s)
        --- PASS: TestAccTransfer_serial/Server/VPCAddressAllocationIDsSecurityGroupIDs (216.72s)
        --- PASS: TestAccTransfer_serial/Server/VPCSecurityGroupIDs (75.92s)
        --- PASS: TestAccTransfer_serial/Server/Workflow (213.90s)
        --- PASS: TestAccTransfer_serial/Server/AuthenticationLoginBanners (190.40s)
        --- PASS: TestAccTransfer_serial/Server/VPCEndpointID (77.88s)
        --- PASS: TestAccTransfer_serial/Server/DirectoryService (901.77s)
        --- PASS: TestAccTransfer_serial/Server/UpdateEndpointTypePublicToVPCAddressAllocationIDs (447.25s)
        --- PASS: TestAccTransfer_serial/Server/APIGateway (170.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	6372.659s

[ewbankkit]

@mtt88 Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.