-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
f/ add support for Neptune Serverless #27763
f/ add support for Neptune Serverless #27763
Conversation
…dation functions
Community NoteVoting for Prioritization
For Submitters
|
9fcb5db
to
d73f185
Compare
d73f185
to
9647899
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccNeptuneCluster_serverlessConfiguration\|TestAccNeptuneCluster_basic' PKG=neptune ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/neptune/... -v -count 1 -parallel 2 -run=TestAccNeptuneCluster_serverlessConfiguration\|TestAccNeptuneCluster_basic -timeout 180m
=== RUN TestAccNeptuneCluster_basic
=== PAUSE TestAccNeptuneCluster_basic
=== RUN TestAccNeptuneCluster_serverlessConfiguration
=== PAUSE TestAccNeptuneCluster_serverlessConfiguration
=== CONT TestAccNeptuneCluster_basic
=== CONT TestAccNeptuneCluster_serverlessConfiguration
--- PASS: TestAccNeptuneCluster_serverlessConfiguration (168.81s)
--- PASS: TestAccNeptuneCluster_basic (168.91s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/neptune 176.125s
@thomasgouveia Thanks for the contribution 🎉 👏. |
@ewbankkit you're welcome! :) |
This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR add the support of AWS Neptune Serverless.
It also add two validation functions for float types :
FloatGreaterOrEqualThan
andFloatLowerOrEqualThan
.Below is an example Terraform configuration to run a serverless Neptune cluster :
To enable Serverless, as AWS documentation explain it, we simply need to provide the new block
serverless_v2_scaling_configuration
in theaws_neptune_cluster
resource.This block has two attributes with default values :
min_capacity
: default to 2.5max_capacity
: default to 128See https://docs.aws.amazon.com/neptune/latest/userguide/neptune-serverless-capacity-scaling.html for more details about those attributes.
Relations
Closes #27622
References
https://docs.aws.amazon.com/neptune/latest/userguide/neptune-serverless-using.html#neptune-conversion-to-serverless
https://docs.aws.amazon.com/neptune/latest/userguide/neptune-serverless-capacity-scaling.html
Output from Acceptance Testing