F aws add multiple listeners and port matching #27799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
size/XL
|
Thank you for your contribution! 🚀 Please note that the Remove any changes to the |
github-actions
bot
removed
documentation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome @dgr237 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
bendu
approved these changes
Nov 21, 2022
breathingdust
added
enhancement
|
@YakDriver @breathingdust can you please take a look at this PR? I'm from the AWS App Mesh team and the change seems fine to me. |
bendu
approved these changes
Jan 10, 2023
johnsonaj
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
LGTM 🚀
$ make testacc TESTARGS='-run=TestAccAppMesh_serial' PKG=appmesh
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appmesh/... -v -count 1 -parallel 20 -run=TestAccAppMesh_serial -timeout 180m
--- PASS: TestAccAppMesh_serial (1744.11s)
--- PASS: TestAccAppMesh_serial/VirtualRouter (81.56s)
--- PASS: TestAccAppMesh_serial/VirtualRouter/tags (29.91s)
--- PASS: TestAccAppMesh_serial/VirtualRouter/basic (20.59s)
--- PASS: TestAccAppMesh_serial/VirtualRouter/disappears (10.45s)
--- PASS: TestAccAppMesh_serial/VirtualRouter/multiListener (20.62s)
--- PASS: TestAccAppMesh_serial/VirtualService (85.33s)
--- PASS: TestAccAppMesh_serial/VirtualService/disappears (11.35s)
--- PASS: TestAccAppMesh_serial/VirtualService/virtualNode (22.52s)
--- PASS: TestAccAppMesh_serial/VirtualService/virtualRouter (20.13s)
--- PASS: TestAccAppMesh_serial/VirtualService/tags (31.32s)
--- PASS: TestAccAppMesh_serial/GatewayRoute (263.11s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/http2Route (40.41s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/http2RouteWithPort (40.48s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/basic (13.48s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/grpcRoute (22.44s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/httpRoute (40.53s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/httpRouteWithPort (40.52s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/tags (31.34s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/disappears (11.44s)
--- PASS: TestAccAppMesh_serial/GatewayRoute/grpcRouteWithPort (22.46s)
--- PASS: TestAccAppMesh_serial/Mesh (63.75s)
--- PASS: TestAccAppMesh_serial/Mesh/basic (11.69s)
--- PASS: TestAccAppMesh_serial/Mesh/egressFilter (24.50s)
--- PASS: TestAccAppMesh_serial/Mesh/tags (27.56s)
--- PASS: TestAccAppMesh_serial/Route (517.77s)
--- PASS: TestAccAppMesh_serial/Route/http2RouteWithPortMatch (22.58s)
--- PASS: TestAccAppMesh_serial/Route/httpRetryPolicy (31.42s)
--- PASS: TestAccAppMesh_serial/Route/tcpRouteWithPortMatch (31.74s)
--- PASS: TestAccAppMesh_serial/Route/tcpRouteTimeout (22.57s)
--- PASS: TestAccAppMesh_serial/Route/grpcRouteEmptyMatch (13.41s)
--- PASS: TestAccAppMesh_serial/Route/http2Route (22.50s)
--- PASS: TestAccAppMesh_serial/Route/httpHeader (22.34s)
--- PASS: TestAccAppMesh_serial/Route/disappears (11.52s)
--- PASS: TestAccAppMesh_serial/Route/http2RouteTimeout (22.48s)
--- PASS: TestAccAppMesh_serial/Route/tcpRoute (31.74s)
--- PASS: TestAccAppMesh_serial/Route/grpcRoute (40.62s)
--- PASS: TestAccAppMesh_serial/Route/grpcRouteWithPortMatch (40.50s)
--- PASS: TestAccAppMesh_serial/Route/httpRouteWithPortMatch (73.46s)
--- PASS: TestAccAppMesh_serial/Route/httpRouteTimeout (22.60s)
--- PASS: TestAccAppMesh_serial/Route/routePriority (22.38s)
--- PASS: TestAccAppMesh_serial/Route/tags (31.70s)
--- PASS: TestAccAppMesh_serial/Route/grpcRouteTimeout (22.52s)
--- PASS: TestAccAppMesh_serial/Route/httpRoute (31.68s)
--- PASS: TestAccAppMesh_serial/VirtualGateway (253.42s)
--- PASS: TestAccAppMesh_serial/VirtualGateway/basic (12.36s)
--- PASS: TestAccAppMesh_serial/VirtualGateway/listenerConnectionPool (20.57s)
--- PASS: TestAccAppMesh_serial/VirtualGateway/listenerTls (64.23s)
--- PASS: TestAccAppMesh_serial/VirtualGateway/listenerValidation (20.79s)
--- PASS: TestAccAppMesh_serial/VirtualGateway/logging (20.86s)
--- PASS: TestAccAppMesh_serial/VirtualGateway/tags (29.10s)
--- PASS: TestAccAppMesh_serial/VirtualGateway/disappears (10.58s)
--- PASS: TestAccAppMesh_serial/VirtualGateway/backendDefaults (20.87s)
--- PASS: TestAccAppMesh_serial/VirtualGateway/backendDefaultsCertificate (12.50s)
--- PASS: TestAccAppMesh_serial/VirtualGateway/listenerHealthChecks (20.72s)
--- PASS: TestAccAppMesh_serial/VirtualGateway/multiListenerValidation (20.84s)
--- PASS: TestAccAppMesh_serial/VirtualNode (479.17s)
--- PASS: TestAccAppMesh_serial/VirtualNode/logging (22.07s)
--- PASS: TestAccAppMesh_serial/VirtualNode/cloudMapServiceDiscovery (108.63s)
--- PASS: TestAccAppMesh_serial/VirtualNode/listenerHealthChecks (21.15s)
--- PASS: TestAccAppMesh_serial/VirtualNode/multiListenerValidation (21.01s)
--- PASS: TestAccAppMesh_serial/VirtualNode/backendClientPolicyFile (21.14s)
--- PASS: TestAccAppMesh_serial/VirtualNode/tags (29.39s)
--- PASS: TestAccAppMesh_serial/VirtualNode/listenerOutlierDetection (21.03s)
--- PASS: TestAccAppMesh_serial/VirtualNode/listenerTimeout (20.84s)
--- PASS: TestAccAppMesh_serial/VirtualNode/listenerTls (64.28s)
--- PASS: TestAccAppMesh_serial/VirtualNode/listenerValidation (20.74s)
--- PASS: TestAccAppMesh_serial/VirtualNode/basic (12.45s)
--- PASS: TestAccAppMesh_serial/VirtualNode/backendClientPolicyAcm (51.57s)
--- PASS: TestAccAppMesh_serial/VirtualNode/backendDefaultsCertificate (12.61s)
--- PASS: TestAccAppMesh_serial/VirtualNode/disappears (10.58s)
--- PASS: TestAccAppMesh_serial/VirtualNode/backendDefaults (20.76s)
--- PASS: TestAccAppMesh_serial/VirtualNode/listenerConnectionPool (20.90s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/appmesh 1747.056s
|
@dgr237 thank you for the contribution! 👏🏾 🎉 |
Merged
|
This functionality has been released in v4.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
This was referenced Jan 20, 2023
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request adds the functionality to be able specify multi listeners on the following resources:
aws_appmesh_virtual_node
aws_appmesh_virtual_gateway
aws_appmesh_virtual_router
In addition port has been added to match on the routes for:
aws_appmesh_gateway_route
aws_appmesh_route
Added weighted_target port to aws_appmesh_route.
Relations
Closes #27698
Closes #26380
References
This functionality enables services to expose multiple ports/ protocols and route traffic to the different ports form other services running on the cluster or from the gateway.
Output from Acceptance Testing