Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_vpc_network_performance_metric_subscription: New resource #28150

Merged
merged 9 commits into from
Dec 5, 2022

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Dec 2, 2022

Description

Adds the aws_vpc_network_performance_metric_subscription resource.

Relations

Closes #28149.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccVPCNetworkPerformanceMetricSubscription_serial' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPCNetworkPerformanceMetricSubscription_serial -timeout 180m
=== RUN   TestAccVPCNetworkPerformanceMetricSubscription_serial
=== RUN   TestAccVPCNetworkPerformanceMetricSubscription_serial/basic
=== RUN   TestAccVPCNetworkPerformanceMetricSubscription_serial/disappears
--- PASS: TestAccVPCNetworkPerformanceMetricSubscription_serial (23.89s)
    --- PASS: TestAccVPCNetworkPerformanceMetricSubscription_serial/basic (13.46s)
    --- PASS: TestAccVPCNetworkPerformanceMetricSubscription_serial/disappears (10.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	28.853s
% make sweep SWEEPARGS=-sweep-run=aws_vpc_network_performance_metric_subscription
# make sweep SWEEPARGS=-sweep-run=aws_example_thing
# set SWEEPARGS=-sweep-allow-failures to continue after first failure
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -tags=sweep -sweep=us-west-2,us-east-1,us-east-2 -sweep-run=aws_vpc_network_performance_metric_subscription -timeout 60m
2022/12/05 08:07:29 [DEBUG] Running Sweepers for region (us-west-2):
2022/12/05 08:07:29 [DEBUG] Running Sweeper (aws_vpc_network_performance_metric_subscription) in region (us-west-2)
2022/12/05 08:07:29 [INFO] Retrieved credentials from "EnvConfigCredentials"
2022/12/05 08:07:29 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/12/05 08:07:29 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/12/05 08:07:30 [DEBUG] Waiting for state to become: [success]
2022/12/05 08:07:30 [DEBUG] Waiting for state to become: [success]
2022/12/05 08:07:30 [DEBUG] Deleting EC2 AWS Network Performance Metric Subscriptione: eu-north-1/me-south-1/aggregate-latency/p50
2022/12/05 08:07:30 [DEBUG] Deleting EC2 AWS Network Performance Metric Subscriptione: eun1-az2/eun1-az2/aggregate-latency/p50
2022/12/05 08:07:31 [DEBUG] Completed Sweeper (aws_vpc_network_performance_metric_subscription) in region (us-west-2) in 2.318155886s
2022/12/05 08:07:31 Completed Sweepers for region (us-west-2) in 2.318405745s
2022/12/05 08:07:31 Sweeper Tests for region (us-west-2) ran successfully:
	- aws_vpc_network_performance_metric_subscription
2022/12/05 08:07:31 [DEBUG] Running Sweepers for region (us-east-1):
2022/12/05 08:07:31 [DEBUG] Running Sweeper (aws_vpc_network_performance_metric_subscription) in region (us-east-1)
2022/12/05 08:07:31 [INFO] Retrieved credentials from "EnvConfigCredentials"
2022/12/05 08:07:31 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/12/05 08:07:31 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/12/05 08:07:32 [DEBUG] Completed Sweeper (aws_vpc_network_performance_metric_subscription) in region (us-east-1) in 715.174336ms
2022/12/05 08:07:32 Completed Sweepers for region (us-east-1) in 715.199724ms
2022/12/05 08:07:32 Sweeper Tests for region (us-east-1) ran successfully:
	- aws_vpc_network_performance_metric_subscription
2022/12/05 08:07:32 [DEBUG] Running Sweepers for region (us-east-2):
2022/12/05 08:07:32 [DEBUG] Running Sweeper (aws_vpc_network_performance_metric_subscription) in region (us-east-2)
2022/12/05 08:07:32 [INFO] Retrieved credentials from "EnvConfigCredentials"
2022/12/05 08:07:32 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/12/05 08:07:32 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/12/05 08:07:32 [DEBUG] Completed Sweeper (aws_vpc_network_performance_metric_subscription) in region (us-east-2) in 406.287554ms
2022/12/05 08:07:32 Completed Sweepers for region (us-east-2) in 406.308465ms
2022/12/05 08:07:32 Sweeper Tests for region (us-east-2) ran successfully:
	- aws_vpc_network_performance_metric_subscription
ok  	github.com/hashicorp/terraform-provider-aws/internal/sweep	10.961s

Acceptance test output:

% make testacc TESTARGS='-run=TestAccVPCNetworkPerformanceMetricSubscription_serial' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPCNetworkPerformanceMetricSubscription_serial -timeout 180m
=== RUN   TestAccVPCNetworkPerformanceMetricSubscription_serial
=== RUN   TestAccVPCNetworkPerformanceMetricSubscription_serial/basic
=== RUN   TestAccVPCNetworkPerformanceMetricSubscription_serial/disappears
--- PASS: TestAccVPCNetworkPerformanceMetricSubscription_serial (23.89s)
    --- PASS: TestAccVPCNetworkPerformanceMetricSubscription_serial/basic (13.46s)
    --- PASS: TestAccVPCNetworkPerformanceMetricSubscription_serial/disappears (10.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	28.853s
@github-actions
Copy link

github-actions bot commented Dec 2, 2022

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/vpc Issues and PRs that pertain to the vpc service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Dec 2, 2022
@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Dec 2, 2022
@github-actions github-actions bot added the sweeper Pertains to changes to or issues with the sweeper. label Dec 5, 2022
@github-actions github-actions bot added github_actions Pull requests that update Github_actions code repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. and removed repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. github_actions Pull requests that update Github_actions code labels Dec 5, 2022
@ewbankkit ewbankkit merged commit d48eb76 into main Dec 5, 2022
@ewbankkit ewbankkit deleted the f-aws_vpc_network_performance_metric_subscription branch December 5, 2022 13:49
@github-actions github-actions bot added this to the v4.46.0 milestone Dec 5, 2022
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

This functionality has been released in v4.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jan 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/vpc Issues and PRs that pertain to the vpc service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Real-time performance monitoring for the AWS Global Network
1 participant