-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add execution_role
to Athena Workgroup
#28420
Add execution_role
to Athena Workgroup
#28420
Conversation
Community NoteVoting for Prioritization
For Submitters
|
@bschaatsbergen , thanks for putting up this pull request. I did some FYI, I also put up a small PR to your branch to fix the "Acceptance Test Linting / terrafmt" check failure. Btw, Happy New Year! |
Ah that's nice of you @djleeam, I was on holidays, I'll finalize the PR asap. Happy new year :) |
Fix terrafmt check on test resource
…xpandWorkGroupConfigurationUpdates'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAthenaWorkGroup_' PKG=athena ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/athena/... -v -count 1 -parallel 3 -run=TestAccAthenaWorkGroup_ -timeout 180m
=== RUN TestAccAthenaWorkGroup_basic
=== PAUSE TestAccAthenaWorkGroup_basic
=== RUN TestAccAthenaWorkGroup_aclConfig
=== PAUSE TestAccAthenaWorkGroup_aclConfig
=== RUN TestAccAthenaWorkGroup_disappears
=== PAUSE TestAccAthenaWorkGroup_disappears
=== RUN TestAccAthenaWorkGroup_bytesScannedCutoffPerQuery
=== PAUSE TestAccAthenaWorkGroup_bytesScannedCutoffPerQuery
=== RUN TestAccAthenaWorkGroup_enforceWorkGroup
=== PAUSE TestAccAthenaWorkGroup_enforceWorkGroup
=== RUN TestAccAthenaWorkGroup_configurationEngineVersion
=== PAUSE TestAccAthenaWorkGroup_configurationEngineVersion
=== RUN TestAccAthenaWorkGroup_configurationExecutionRole
=== PAUSE TestAccAthenaWorkGroup_configurationExecutionRole
=== RUN TestAccAthenaWorkGroup_publishCloudWatchMetricsEnabled
=== PAUSE TestAccAthenaWorkGroup_publishCloudWatchMetricsEnabled
=== RUN TestAccAthenaWorkGroup_ResultEncryption_sseS3
=== PAUSE TestAccAthenaWorkGroup_ResultEncryption_sseS3
=== RUN TestAccAthenaWorkGroup_ResultEncryption_kms
=== PAUSE TestAccAthenaWorkGroup_ResultEncryption_kms
=== RUN TestAccAthenaWorkGroup_Result_outputLocation
=== PAUSE TestAccAthenaWorkGroup_Result_outputLocation
=== RUN TestAccAthenaWorkGroup_requesterPaysEnabled
=== PAUSE TestAccAthenaWorkGroup_requesterPaysEnabled
=== RUN TestAccAthenaWorkGroup_ResultOutputLocation_forceDestroy
=== PAUSE TestAccAthenaWorkGroup_ResultOutputLocation_forceDestroy
=== RUN TestAccAthenaWorkGroup_description
=== PAUSE TestAccAthenaWorkGroup_description
=== RUN TestAccAthenaWorkGroup_state
=== PAUSE TestAccAthenaWorkGroup_state
=== RUN TestAccAthenaWorkGroup_forceDestroy
=== PAUSE TestAccAthenaWorkGroup_forceDestroy
=== RUN TestAccAthenaWorkGroup_tags
=== PAUSE TestAccAthenaWorkGroup_tags
=== CONT TestAccAthenaWorkGroup_basic
=== CONT TestAccAthenaWorkGroup_ResultEncryption_kms
=== CONT TestAccAthenaWorkGroup_description
--- PASS: TestAccAthenaWorkGroup_basic (18.32s)
=== CONT TestAccAthenaWorkGroup_state
--- PASS: TestAccAthenaWorkGroup_description (29.63s)
=== CONT TestAccAthenaWorkGroup_tags
--- PASS: TestAccAthenaWorkGroup_ResultEncryption_kms (32.33s)
=== CONT TestAccAthenaWorkGroup_configurationEngineVersion
--- PASS: TestAccAthenaWorkGroup_state (42.95s)
=== CONT TestAccAthenaWorkGroup_ResultEncryption_sseS3
--- PASS: TestAccAthenaWorkGroup_tags (47.59s)
=== CONT TestAccAthenaWorkGroup_publishCloudWatchMetricsEnabled
--- PASS: TestAccAthenaWorkGroup_configurationEngineVersion (50.33s)
=== CONT TestAccAthenaWorkGroup_configurationExecutionRole
--- PASS: TestAccAthenaWorkGroup_ResultEncryption_sseS3 (23.18s)
=== CONT TestAccAthenaWorkGroup_requesterPaysEnabled
--- PASS: TestAccAthenaWorkGroup_configurationExecutionRole (27.10s)
=== CONT TestAccAthenaWorkGroup_ResultOutputLocation_forceDestroy
--- PASS: TestAccAthenaWorkGroup_publishCloudWatchMetricsEnabled (35.28s)
=== CONT TestAccAthenaWorkGroup_forceDestroy
--- PASS: TestAccAthenaWorkGroup_requesterPaysEnabled (35.00s)
=== CONT TestAccAthenaWorkGroup_enforceWorkGroup
--- PASS: TestAccAthenaWorkGroup_forceDestroy (32.27s)
=== CONT TestAccAthenaWorkGroup_bytesScannedCutoffPerQuery
--- PASS: TestAccAthenaWorkGroup_enforceWorkGroup (32.72s)
=== CONT TestAccAthenaWorkGroup_Result_outputLocation
--- PASS: TestAccAthenaWorkGroup_ResultOutputLocation_forceDestroy (46.77s)
=== CONT TestAccAthenaWorkGroup_disappears
--- PASS: TestAccAthenaWorkGroup_disappears (14.21s)
=== CONT TestAccAthenaWorkGroup_aclConfig
--- PASS: TestAccAthenaWorkGroup_bytesScannedCutoffPerQuery (34.41s)
--- PASS: TestAccAthenaWorkGroup_aclConfig (19.91s)
--- PASS: TestAccAthenaWorkGroup_Result_outputLocation (45.91s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/athena 203.188s
@bschaatsbergen Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Relations
Closes #28386
References
Output from Acceptance Testing