Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various AWS SSM Providers parameters are missing arguments #2876

Closed
jimsmith opened this issue Jan 5, 2018 · 8 comments
Closed

Various AWS SSM Providers parameters are missing arguments #2876

jimsmith opened this issue Jan 5, 2018 · 8 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service.
Milestone

Comments

@jimsmith
Copy link

jimsmith commented Jan 5, 2018

Hi,

So using latest terraform 0.11.1 following the documentation to create a SSM AWS maintenance window task:
https://www.terraform.io/docs/providers/aws/r/ssm_maintenance_window_task.html

The following is not supported by Terraform, taken from AWS Documentation CLI:
https://docs.aws.amazon.com/cli/latest/reference/ssm/register-task-with-maintenance-window.html

[--name <value>]
[--description <value>]

These are required so the tasks have meaningful names and descriptions.

Additionally I have noticed that Comment & Timedout (seconds) there doesn't appear to be any supported arguments to get these populated into AWS

TimeoutSeconds
Comment

https://docs.aws.amazon.com/systems-manager/latest/userguide/sysman-maintenance-walk.html
https://docs.aws.amazon.com/cli/latest/reference/ssm/update-maintenance-window-task.html

Also I note that when running terraform apply (with no changes) resources get (new resource required) which gives the user the 'impression' the resources are being destroyed and then re-created..... however infact the same AWS resources exist and remain..... this is a bug as this shouldn't happen equally when updating parameters shouldn't re-create as AWS has the update maintenance window task.

The below AWS CLI allows me to add in Comment and TimeoutSeconds:

aws --profile jim --region eu-west-2 ssm update-maintenance-window-task \
--window-id mw-0a1faf6cb61b24a68 \
--window-task-id 40e3ae25-daae-4b63-9539-2129fde69618 \
--task-invocation-parameters "RunCommand={Comment=A_Comment,TimeoutSeconds=900}"
@jimsmith jimsmith changed the title Feature Request - Update to what AWS parameters have for aws_ssm_maintenance_window_task Feature Request - AWS-RunRemoteScript SSM Document - update to what AWS parameters have for aws_ssm_maintenance_window_task Jan 8, 2018
@jimsmith jimsmith changed the title Feature Request - AWS-RunRemoteScript SSM Document - update to what AWS parameters have for aws_ssm_maintenance_window_task aws_ssm_maintenance_window_task is missing optional arguments Jan 8, 2018
@jimsmith
Copy link
Author

jimsmith commented Jan 9, 2018

Adding that: https://www.terraform.io/docs/providers/aws/r/ssm_maintenance_window.html
doesn't have support for description

@jimsmith
Copy link
Author

jimsmith commented Jan 9, 2018

Adding that: https://www.terraform.io/docs/providers/aws/r/ssm_maintenance_window_target.html
doesn't have support for Target Name nor description

@jimsmith jimsmith changed the title aws_ssm_maintenance_window_task is missing optional arguments Various AWS SSM Providers parameters are missing arguments Jan 9, 2018
@jimsmith
Copy link
Author

Bump

@radeksimko radeksimko added enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service. labels Jan 17, 2018
@nbrys
Copy link
Contributor

nbrys commented Aug 27, 2018

+1 for this issue

@egirard78
Copy link

+1 to include those parameters.

@bryanhodge
Copy link

+1 for this issue

@bflad
Copy link
Contributor

bflad commented Jul 16, 2019

Hi @jimsmith (and folks watching this issue) 👋 Thank you for submitting this feature request and sorry about the delays in getting everything sorted here. In the future, its preferable for contributors and maintainers to have bug reports and features requests broken out so the updates can be individually tracked. Many of the items noted in this issue are now resolved and I am going to close this in preference of more targeted GitHub issues.

Releasing in version 2.20.0 of the Terraform AWS Provider later this week:

  • resource/aws_ssm_maintenance_window_task: Support resource import and in-place updates
  • resource/aws_ssm_maintenance_window_task: Add task_invocation_parameters configuration block

Previously released in version 2.12.0 of the Terraform AWS Provider:

  • resource/aws_ssm_maintenance_window_target: Add support for name and description for maintenance window targets

Previously released in version 1.44.0 of the Terraform AWS Provider:

  • resource/aws_ssm_maintenance_window_task: Add description and name arguments

Tracking for the aws_ssm_maintenance_window resource support of description: #9035

For further feature requests or bug reports with functionality within the Terraform AWS Provider, please create a new GitHub issue following the template for triage. Thanks!

@bflad bflad closed this as completed Jul 16, 2019
@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants