Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_route53_record: convert alias from TypeSet to TypeList #28771

Closed
gdavison opened this issue Jan 9, 2023 · 3 comments
Closed

resource/aws_route53_record: convert alias from TypeSet to TypeList #28771

gdavison opened this issue Jan 9, 2023 · 3 comments
Labels
technical-debt Addresses areas of the codebase that need refactoring or redesign.

Comments

@gdavison
Copy link
Contributor

gdavison commented Jan 9, 2023

Description

The nested block alias should be implemented as a TypeList with MaxItems: 1 instead of a TypeSet

References

No response

Would you like to implement a fix?

None
@gdavison gdavison added the needs-triage Waiting for first response or review from a maintainer. label Jan 9, 2023
@gdavison gdavison added this to the v5.0.0 milestone Jan 9, 2023
@github-actions github-actions bot removed the needs-triage Waiting for first response or review from a maintainer. label Jan 9, 2023
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@gdavison gdavison added technical-debt Addresses areas of the codebase that need refactoring or redesign. breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. labels Jan 9, 2023
@lovrek93 lovrek93 mentioned this issue Jan 24, 2023
Closed
@breathingdust breathingdust removed the breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. label Feb 17, 2023
@gdavison
Copy link
Contributor Author

Already done in #28894

@breathingdust breathingdust removed this from the v5.0.0 milestone Feb 21, 2023
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@breathingdust @gdavison