Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3control: Improve policy diffs #28866

Merged
merged 2 commits into from
Jan 12, 2023
Merged

s3control: Improve policy diffs #28866

merged 2 commits into from
Jan 12, 2023

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Jan 12, 2023

Description

Relations

Relates #23288

References

Output from Acceptance Testing

% make testacc TESTS="TestAccS3ControlAccessPoint_|TestAccS3ControlAccessPointPolicy_|TestAccS3ControlBucketPolicy_|TestAccS3ControlMultiRegionAccessPointPolicy_|TestAccS3ControlObjectLambdaAccessPointPolicy_" PKG=s3control
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20 -run='TestAccS3ControlAccessPoint_|TestAccS3ControlAccessPointPolicy_|TestAccS3ControlBucketPolicy_|TestAccS3ControlMultiRegionAccessPointPolicy_|TestAccS3ControlObjectLambdaAccessPointPolicy_'  -timeout 180m
=== RUN   TestAccS3ControlAccessPointPolicy_basic
=== PAUSE TestAccS3ControlAccessPointPolicy_basic
=== RUN   TestAccS3ControlAccessPointPolicy_disappears
=== PAUSE TestAccS3ControlAccessPointPolicy_disappears
=== RUN   TestAccS3ControlAccessPointPolicy_disappears_AccessPoint
=== PAUSE TestAccS3ControlAccessPointPolicy_disappears_AccessPoint
=== RUN   TestAccS3ControlAccessPointPolicy_update
=== PAUSE TestAccS3ControlAccessPointPolicy_update
=== RUN   TestAccS3ControlAccessPoint_basic
=== PAUSE TestAccS3ControlAccessPoint_basic
=== RUN   TestAccS3ControlAccessPoint_disappears
=== PAUSE TestAccS3ControlAccessPoint_disappears
=== RUN   TestAccS3ControlAccessPoint_Bucket_arn
=== PAUSE TestAccS3ControlAccessPoint_Bucket_arn
=== RUN   TestAccS3ControlAccessPoint_policy
=== PAUSE TestAccS3ControlAccessPoint_policy
=== RUN   TestAccS3ControlAccessPoint_publicAccessBlock
=== PAUSE TestAccS3ControlAccessPoint_publicAccessBlock
=== RUN   TestAccS3ControlAccessPoint_vpc
=== PAUSE TestAccS3ControlAccessPoint_vpc
=== RUN   TestAccS3ControlBucketPolicy_basic
=== PAUSE TestAccS3ControlBucketPolicy_basic
=== RUN   TestAccS3ControlBucketPolicy_disappears
=== PAUSE TestAccS3ControlBucketPolicy_disappears
=== RUN   TestAccS3ControlBucketPolicy_policy
=== PAUSE TestAccS3ControlBucketPolicy_policy
=== RUN   TestAccS3ControlMultiRegionAccessPointPolicy_basic
=== PAUSE TestAccS3ControlMultiRegionAccessPointPolicy_basic
=== RUN   TestAccS3ControlMultiRegionAccessPointPolicy_disappears_MultiRegionAccessPoint
=== PAUSE TestAccS3ControlMultiRegionAccessPointPolicy_disappears_MultiRegionAccessPoint
=== RUN   TestAccS3ControlMultiRegionAccessPointPolicy_details_policy
=== PAUSE TestAccS3ControlMultiRegionAccessPointPolicy_details_policy
=== RUN   TestAccS3ControlMultiRegionAccessPointPolicy_details_name
=== PAUSE TestAccS3ControlMultiRegionAccessPointPolicy_details_name
=== RUN   TestAccS3ControlObjectLambdaAccessPointPolicy_basic
=== PAUSE TestAccS3ControlObjectLambdaAccessPointPolicy_basic
=== RUN   TestAccS3ControlObjectLambdaAccessPointPolicy_disappears
=== PAUSE TestAccS3ControlObjectLambdaAccessPointPolicy_disappears
=== RUN   TestAccS3ControlObjectLambdaAccessPointPolicy_Disappears_accessPoint
=== PAUSE TestAccS3ControlObjectLambdaAccessPointPolicy_Disappears_accessPoint
=== RUN   TestAccS3ControlObjectLambdaAccessPointPolicy_update
=== PAUSE TestAccS3ControlObjectLambdaAccessPointPolicy_update
=== CONT  TestAccS3ControlAccessPointPolicy_basic
=== CONT  TestAccS3ControlBucketPolicy_disappears
=== CONT  TestAccS3ControlAccessPoint_Bucket_arn
=== CONT  TestAccS3ControlAccessPoint_basic
=== CONT  TestAccS3ControlMultiRegionAccessPointPolicy_details_name
=== CONT  TestAccS3ControlObjectLambdaAccessPointPolicy_Disappears_accessPoint
=== CONT  TestAccS3ControlBucketPolicy_basic
=== CONT  TestAccS3ControlAccessPoint_policy
=== CONT  TestAccS3ControlMultiRegionAccessPointPolicy_disappears_MultiRegionAccessPoint
=== CONT  TestAccS3ControlAccessPoint_disappears
=== CONT  TestAccS3ControlAccessPointPolicy_disappears_AccessPoint
=== CONT  TestAccS3ControlAccessPointPolicy_disappears
=== CONT  TestAccS3ControlObjectLambdaAccessPointPolicy_disappears
=== CONT  TestAccS3ControlAccessPoint_vpc
=== CONT  TestAccS3ControlAccessPoint_publicAccessBlock
=== CONT  TestAccS3ControlObjectLambdaAccessPointPolicy_basic
=== CONT  TestAccS3ControlAccessPointPolicy_update
=== CONT  TestAccS3ControlObjectLambdaAccessPointPolicy_update
=== CONT  TestAccS3ControlMultiRegionAccessPointPolicy_details_policy
=== CONT  TestAccS3ControlMultiRegionAccessPointPolicy_basic
=== CONT  TestAccS3ControlAccessPoint_Bucket_arn
    acctest.go:1368: skipping since no Outposts found
--- SKIP: TestAccS3ControlAccessPoint_Bucket_arn (1.16s)
=== CONT  TestAccS3ControlBucketPolicy_policy
=== CONT  TestAccS3ControlBucketPolicy_disappears
    acctest.go:1368: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketPolicy_disappears (1.31s)
=== CONT  TestAccS3ControlBucketPolicy_basic
    acctest.go:1368: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketPolicy_basic (1.31s)
=== CONT  TestAccS3ControlBucketPolicy_policy
    acctest.go:1368: skipping since no Outposts found
--- SKIP: TestAccS3ControlBucketPolicy_policy (0.24s)
--- PASS: TestAccS3ControlAccessPoint_disappears (40.84s)
--- PASS: TestAccS3ControlAccessPointPolicy_disappears_AccessPoint (41.59s)
--- PASS: TestAccS3ControlAccessPointPolicy_disappears (42.32s)
--- PASS: TestAccS3ControlAccessPointPolicy_basic (45.23s)
--- PASS: TestAccS3ControlAccessPoint_basic (47.33s)
--- PASS: TestAccS3ControlAccessPoint_vpc (60.10s)
--- PASS: TestAccS3ControlAccessPoint_publicAccessBlock (61.09s)
--- PASS: TestAccS3ControlAccessPointPolicy_update (64.76s)
--- PASS: TestAccS3ControlObjectLambdaAccessPointPolicy_basic (66.80s)
--- PASS: TestAccS3ControlObjectLambdaAccessPointPolicy_disappears (68.89s)
--- PASS: TestAccS3ControlObjectLambdaAccessPointPolicy_Disappears_accessPoint (73.48s)
--- PASS: TestAccS3ControlAccessPoint_policy (86.20s)
--- PASS: TestAccS3ControlObjectLambdaAccessPointPolicy_update (101.49s)
--- PASS: TestAccS3ControlMultiRegionAccessPointPolicy_disappears_MultiRegionAccessPoint (352.97s)
--- PASS: TestAccS3ControlMultiRegionAccessPointPolicy_basic (361.43s)
--- PASS: TestAccS3ControlMultiRegionAccessPointPolicy_details_policy (408.13s)
--- PASS: TestAccS3ControlMultiRegionAccessPointPolicy_details_name (670.62s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	672.613s

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/s3control Issues and PRs that pertain to the s3control service. size/S Managed by automation to categorize the size of a PR. and removed service/s3control Issues and PRs that pertain to the s3control service. labels Jan 12, 2023
@github-actions github-actions bot added service/s3control Issues and PRs that pertain to the s3control service. size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. service/s3control Issues and PRs that pertain to the s3control service. labels Jan 12, 2023
@YakDriver YakDriver merged commit 6b60004 into main Jan 12, 2023
@YakDriver YakDriver deleted the b-s3control-policy-diffs branch January 12, 2023 21:20
@github-actions github-actions bot added this to the v4.50.0 milestone Jan 12, 2023
github-actions bot pushed a commit that referenced this pull request Jan 12, 2023
@github-actions
Copy link

This functionality has been released in v4.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant