elbv2/listener_certificate: Display errors on read

[YakDriver]

Description

• aws_lb_listener_certificate - Fix logic error where all errors during read would end up in remove from state branch rather than giving error. This causes problems when there are actual errors like not having the correct permissions. This is never visible except in log.
• aws_iam_server_certificate - Delete was returning an error no matter what, in many cases, rather than checking to see if there were an error to return nil.

Relations

Closes #8751

References

Output from Acceptance Testing

% make testacc TESTS=TestAccELBV2ListenerCertificate_ PKG=elbv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run='TestAccELBV2ListenerCertificate_'  -timeout 180m
=== RUN   TestAccELBV2ListenerCertificate_basic
=== PAUSE TestAccELBV2ListenerCertificate_basic
=== RUN   TestAccELBV2ListenerCertificate_CertificateARN_underscores
=== PAUSE TestAccELBV2ListenerCertificate_CertificateARN_underscores
=== RUN   TestAccELBV2ListenerCertificate_multiple
=== PAUSE TestAccELBV2ListenerCertificate_multiple
=== RUN   TestAccELBV2ListenerCertificate_disappears
=== PAUSE TestAccELBV2ListenerCertificate_disappears
=== CONT  TestAccELBV2ListenerCertificate_basic
=== CONT  TestAccELBV2ListenerCertificate_multiple
=== CONT  TestAccELBV2ListenerCertificate_CertificateARN_underscores
=== CONT  TestAccELBV2ListenerCertificate_disappears
--- PASS: TestAccELBV2ListenerCertificate_disappears (148.26s)
--- PASS: TestAccELBV2ListenerCertificate_basic (150.81s)
--- PASS: TestAccELBV2ListenerCertificate_CertificateARN_underscores (161.03s)
--- PASS: TestAccELBV2ListenerCertificate_multiple (248.19s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	250.086s
% make testacc TESTS=TestAccIAMServerCertificate_ PKG=iam
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMServerCertificate_'  -timeout 180m
=== RUN   TestAccIAMServerCertificate_basic
=== PAUSE TestAccIAMServerCertificate_basic
=== RUN   TestAccIAMServerCertificate_tags
=== PAUSE TestAccIAMServerCertificate_tags
=== RUN   TestAccIAMServerCertificate_Name_prefix
=== PAUSE TestAccIAMServerCertificate_Name_prefix
=== RUN   TestAccIAMServerCertificate_disappears
=== PAUSE TestAccIAMServerCertificate_disappears
=== RUN   TestAccIAMServerCertificate_file
=== PAUSE TestAccIAMServerCertificate_file
=== RUN   TestAccIAMServerCertificate_path
=== PAUSE TestAccIAMServerCertificate_path
=== CONT  TestAccIAMServerCertificate_basic
=== CONT  TestAccIAMServerCertificate_disappears
=== CONT  TestAccIAMServerCertificate_path
=== CONT  TestAccIAMServerCertificate_file
=== CONT  TestAccIAMServerCertificate_Name_prefix
=== CONT  TestAccIAMServerCertificate_tags
--- PASS: TestAccIAMServerCertificate_disappears (14.98s)
--- PASS: TestAccIAMServerCertificate_Name_prefix (17.56s)
--- PASS: TestAccIAMServerCertificate_path (19.49s)
--- PASS: TestAccIAMServerCertificate_basic (19.92s)
--- PASS: TestAccIAMServerCertificate_file (28.73s)
--- PASS: TestAccIAMServerCertificate_tags (38.88s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	41.494s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

This functionality has been released in v4.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.