Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: App Mesh Virtual Gateway Route missing target port #29063

Closed
benmurden opened this issue Jan 24, 2023 · 3 comments · Fixed by #29064
Closed

[Enhancement]: App Mesh Virtual Gateway Route missing target port #29063

benmurden opened this issue Jan 24, 2023 · 3 comments · Fixed by #29064
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/appmesh Issues and PRs that pertain to the appmesh service.
Milestone

Comments

@benmurden
Copy link
Contributor

Description

A PR was merged recently that added the ability to have multiple listeners on Virtual Nodes, Routers, and Gateways in App Mesh, which is great, but it missed out target ports on Gateway Routes. Virtual Gateway Routes must define a target port when the targeted virtual service has multiple listeners.

Affected Resource(s) and/or Data Source(s)

  • aws_appmesh_gateway_route

Potential Terraform Configuration

resource "aws_appmesh_gateway_route" "test" {
  name                 = "test-mesh"
  mesh_name            = aws_appmesh_mesh.test.name
  virtual_gateway_name = aws_appmesh_virtual_gateway.test.name

  spec {
    http_route {
      action {
        target {
          virtual_service {
            virtual_service_name = aws_appmesh_virtual_service.multi_test.name
          }
          port = 8081
        }
      }

      match {
        prefix = "/users"
      }
    }
  }
}

References

https://docs.aws.amazon.com/app-mesh/latest/userguide/gateway-routes.html

Virtual service provider port is required when the provider (router or node) of the selected virtual service has multiple listeners.

https://github.com/aws/aws-app-mesh-examples/blob/main/walkthroughs/howto-multiple-listeners/mesh/color-gateway-route.json
Example spec

https://docs.aws.amazon.com/app-mesh/latest/APIReference/API_CreateGatewayRoute.html

Would you like to implement a fix?

Yes

@benmurden benmurden added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Jan 24, 2023
@github-actions github-actions bot added the service/appmesh Issues and PRs that pertain to the appmesh service. label Jan 24, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jan 24, 2023
@github-actions github-actions bot added this to the v4.61.0 milestone Mar 27, 2023
@github-actions
Copy link

This functionality has been released in v4.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/appmesh Issues and PRs that pertain to the appmesh service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants