Add SecretsManager support for DB2 LUW

[j2clerck]

Description

This PR adds support for SecretsManager when setting up an aws_dms_endpoint source with DB2 engine. Currently if specifying the DB2 engine and SecretsManager, terraform will fail complaining about password being a mandatory field.

Relations

Closes #0000

References

Output from Acceptance Testing

make testacc TESTS=TestAccDMSEndpoint_db2_secretID PKG=dms                                        24s 16:53:00
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSEndpoint_db2_secretID'  -timeout 180m
=== RUN   TestAccDMSEndpoint_db2_secretID
=== PAUSE TestAccDMSEndpoint_db2_secretID
=== CONT  TestAccDMSEndpoint_db2_secretID
--- PASS: TestAccDMSEndpoint_db2_secretID (132.04s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        132.130s

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[AdamTylerLynch]

I would like to see a bit more AccTests run:
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSEndpoint_db2' -timeout 180m

[j2clerck]

❯ TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSEndpoint_db2'  -timeout 180m
=== RUN   TestAccDMSEndpoint_db2_basic
=== PAUSE TestAccDMSEndpoint_db2_basic
=== RUN   TestAccDMSEndpoint_db2_secretID
=== PAUSE TestAccDMSEndpoint_db2_secretID
=== CONT  TestAccDMSEndpoint_db2_basic
=== CONT  TestAccDMSEndpoint_db2_secretID
--- PASS: TestAccDMSEndpoint_db2_secretID (126.93s)
--- PASS: TestAccDMSEndpoint_db2_basic (135.60s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	138.839s

[AdamTylerLynch]

LGTM 🚀

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDMSEndpoint_basic\|TestAccDMSEndpoint_db2' PKG=dms ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 3  -run=TestAccDMSEndpoint_basic\|TestAccDMSEndpoint_db2 -timeout 180m
=== RUN   TestAccDMSEndpoint_basic
=== PAUSE TestAccDMSEndpoint_basic
=== RUN   TestAccDMSEndpoint_db2_basic
=== PAUSE TestAccDMSEndpoint_db2_basic
=== RUN   TestAccDMSEndpoint_db2_secretID
=== PAUSE TestAccDMSEndpoint_db2_secretID
=== CONT  TestAccDMSEndpoint_basic
=== CONT  TestAccDMSEndpoint_db2_secretID
=== CONT  TestAccDMSEndpoint_db2_basic
--- PASS: TestAccDMSEndpoint_db2_secretID (38.59s)
--- PASS: TestAccDMSEndpoint_db2_basic (48.52s)
--- PASS: TestAccDMSEndpoint_basic (48.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	53.943s

[ewbankkit]

@j2clerck Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.