-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new use_new_mapping_type for aws_dms_endpoint #29470
Add new use_new_mapping_type for aws_dms_endpoint #29470
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccDMSEndpoint_OpenSearch_' PKG=dms ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 2 -run=TestAccDMSEndpoint_OpenSearch_ -timeout 360m
=== RUN TestAccDMSEndpoint_OpenSearch_basic
=== PAUSE TestAccDMSEndpoint_OpenSearch_basic
=== RUN TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes
=== PAUSE TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes
=== RUN TestAccDMSEndpoint_OpenSearch_errorRetryDuration
=== PAUSE TestAccDMSEndpoint_OpenSearch_errorRetryDuration
=== RUN TestAccDMSEndpoint_OpenSearch_UseNewMappingType
=== PAUSE TestAccDMSEndpoint_OpenSearch_UseNewMappingType
=== RUN TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage
=== PAUSE TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage
=== CONT TestAccDMSEndpoint_OpenSearch_basic
=== CONT TestAccDMSEndpoint_OpenSearch_UseNewMappingType
--- PASS: TestAccDMSEndpoint_OpenSearch_basic (44.47s)
=== CONT TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage
--- PASS: TestAccDMSEndpoint_OpenSearch_UseNewMappingType (44.55s)
=== CONT TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes
--- PASS: TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage (43.37s)
=== CONT TestAccDMSEndpoint_OpenSearch_errorRetryDuration
--- PASS: TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes (53.57s)
--- PASS: TestAccDMSEndpoint_OpenSearch_errorRetryDuration (30.78s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/dms 124.390s
@lvthillo Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.31.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Add new
use_new_mapping_type
to aws_dms_endpointRelations
Closes #29375
References
Output from Acceptance Testing