Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new use_new_mapping_type for aws_dms_endpoint #29470

Merged

Conversation

lvthillo
Copy link
Contributor

Description

Add new use_new_mapping_type to aws_dms_endpoint

Relations

Closes #29375

References

Output from Acceptance Testing

$  make testacc TESTS=TestAccDMSEndpoint_OpenSearch PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSEndpoint_OpenSearch'  -timeout 180m
=== RUN   TestAccDMSEndpoint_OpenSearch_basic
=== PAUSE TestAccDMSEndpoint_OpenSearch_basic
=== RUN   TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes
=== PAUSE TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes
=== RUN   TestAccDMSEndpoint_OpenSearch_errorRetryDuration
=== PAUSE TestAccDMSEndpoint_OpenSearch_errorRetryDuration
=== RUN   TestAccDMSEndpoint_OpenSearch_UseNewMappingType
=== PAUSE TestAccDMSEndpoint_OpenSearch_UseNewMappingType
=== RUN   TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage
=== PAUSE TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage
=== CONT  TestAccDMSEndpoint_OpenSearch_basic
=== CONT  TestAccDMSEndpoint_OpenSearch_UseNewMappingType
=== CONT  TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage
=== CONT  TestAccDMSEndpoint_OpenSearch_errorRetryDuration
=== CONT  TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes
--- PASS: TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage (137.07s)
--- PASS: TestAccDMSEndpoint_OpenSearch_errorRetryDuration (138.12s)
--- PASS: TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes (146.04s)
--- PASS: TestAccDMSEndpoint_OpenSearch_UseNewMappingType (146.16s)
--- PASS: TestAccDMSEndpoint_OpenSearch_basic (146.17s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        151.558s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/dms Issues and PRs that pertain to the dms service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 17, 2023
@breathingdust breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 6, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDMSEndpoint_OpenSearch_' PKG=dms ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 2  -run=TestAccDMSEndpoint_OpenSearch_ -timeout 360m
=== RUN   TestAccDMSEndpoint_OpenSearch_basic
=== PAUSE TestAccDMSEndpoint_OpenSearch_basic
=== RUN   TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes
=== PAUSE TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes
=== RUN   TestAccDMSEndpoint_OpenSearch_errorRetryDuration
=== PAUSE TestAccDMSEndpoint_OpenSearch_errorRetryDuration
=== RUN   TestAccDMSEndpoint_OpenSearch_UseNewMappingType
=== PAUSE TestAccDMSEndpoint_OpenSearch_UseNewMappingType
=== RUN   TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage
=== PAUSE TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage
=== CONT  TestAccDMSEndpoint_OpenSearch_basic
=== CONT  TestAccDMSEndpoint_OpenSearch_UseNewMappingType
--- PASS: TestAccDMSEndpoint_OpenSearch_basic (44.47s)
=== CONT  TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage
--- PASS: TestAccDMSEndpoint_OpenSearch_UseNewMappingType (44.55s)
=== CONT  TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes
--- PASS: TestAccDMSEndpoint_OpenSearch_fullLoadErrorPercentage (43.37s)
=== CONT  TestAccDMSEndpoint_OpenSearch_errorRetryDuration
--- PASS: TestAccDMSEndpoint_OpenSearch_extraConnectionAttributes (53.57s)
--- PASS: TestAccDMSEndpoint_OpenSearch_errorRetryDuration (30.78s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	124.390s

@ewbankkit
Copy link
Contributor

@lvthillo Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 3dcdcd3 into hashicorp:main Dec 13, 2023
43 checks passed
@github-actions github-actions bot added this to the v5.31.0 milestone Dec 13, 2023
Copy link

This functionality has been released in v5.31.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/dms Issues and PRs that pertain to the dms service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: opensearch setting missing new attribute UseNewMappingType
4 participants