Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_load_balancer_listener_policy: add triggers argument #29482

Merged
merged 7 commits into from
Feb 21, 2023

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Feb 17, 2023

Description

Relations

Closes #13628

References

Output from Acceptance Testing

$ make testacc PKG=elb TESTS="TestAccELBSSLNegotiationPolicy_|TestAccELBListenerPolicy_"

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elb/... -v -count 1 -parallel 20 -run='TestAccELBSSLNegotiationPolicy_|TestAccELBListenerPolicy_'  -timeout 180m
--- PASS: TestAccELBListenerPolicy_basic (19.67s)
--- PASS: TestAccELBListenerPolicy_disappears (20.03s)
--- PASS: TestAccELBSSLNegotiationPolicy_basic (66.53s)
--- PASS: TestAccELBSSLNegotiationPolicy_update (69.65s)
--- PASS: TestAccELBSSLNegotiationPolicy_disappears (78.85s)
--- PASS: TestAccELBListenerPolicy_update (83.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elb	86.537s
...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/elb Issues and PRs that pertain to the elb service. size/XS Managed by automation to categorize the size of a PR. size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/XS Managed by automation to categorize the size of a PR. labels Feb 17, 2023
@johnsonaj johnsonaj added bug Addresses a defect in current functionality. enhancement Requests to existing resources that expand the functionality or scope. and removed bug Addresses a defect in current functionality. labels Feb 17, 2023
@johnsonaj johnsonaj marked this pull request as ready for review February 17, 2023 21:43
@johnsonaj johnsonaj force-pushed the b-aws_loadbalancer_listener_policy branch from 2d4a392 to 21f9529 Compare February 21, 2023 15:10
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

$ make testacc PKG=elb TESTS="TestAccELBSSLNegotiationPolicy_|TestAccELBListenerPolicy_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elb/... -v -count 1 -parallel 20 -run='TestAccELBSSLNegotiationPolicy_|TestAccELBListenerPolicy_'  -timeout 180m
--- PASS: TestAccELBListenerPolicy_basic (20.42s)
--- PASS: TestAccELBSSLNegotiationPolicy_disappears (59.30s)
--- PASS: TestAccELBSSLNegotiationPolicy_basic (68.17s)
--- PASS: TestAccELBListenerPolicy_update (70.69s)
--- PASS: TestAccELBListenerPolicy_disappears (82.16s)
--- PASS: TestAccELBSSLNegotiationPolicy_update (105.42s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elb        108.901s

@johnsonaj johnsonaj merged commit 93fcd85 into main Feb 21, 2023
@johnsonaj johnsonaj deleted the b-aws_loadbalancer_listener_policy branch February 21, 2023 18:24
@github-actions github-actions bot added this to the v4.56.0 milestone Feb 21, 2023
github-actions bot pushed a commit that referenced this pull request Feb 21, 2023
@github-actions
Copy link

This functionality has been released in v4.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/elb Issues and PRs that pertain to the elb service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ELB SSL cert update resets SSL ciphers causing silent configuration drift
2 participants