Don't do anything for Framework `tags_all` plan modification on Delete #29550

ewbankkit · 2023-02-21T13:41:26Z

Description

Skip the Plugin Framework tags_all plan modification logic on resource Delete.
Since hashicorp/terraform-plugin-mux#133 / #29313 Terraform CLI v1.3+ has been running plan modifiers on resource Delete for Framework resources.

Relations

Closes #29541.

References

https://developer.hashicorp.com/terraform/plugin/framework/resources/plan-modification#resource-destroy-plan-diagnostics

Output from Acceptance Testing

We can use #29484 for testing - Framework-implemented resources with default_tags tests.
Using Terraform CLI v1.3.9.

Without fix

% make testacc TESTARGS='-run=TestAccVPCSecurityGroupEgressRule_\|TestAccVPCSecurityGroupIngressRule_' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccVPCSecurityGroupEgressRule_\|TestAccVPCSecurityGroupIngressRule_ -timeout 180m
=== RUN   TestAccVPCSecurityGroupEgressRule_basic
=== PAUSE TestAccVPCSecurityGroupEgressRule_basic
=== RUN   TestAccVPCSecurityGroupEgressRule_disappears
=== PAUSE TestAccVPCSecurityGroupEgressRule_disappears
=== RUN   TestAccVPCSecurityGroupIngressRule_basic
=== PAUSE TestAccVPCSecurityGroupIngressRule_basic
=== RUN   TestAccVPCSecurityGroupIngressRule_disappears
=== PAUSE TestAccVPCSecurityGroupIngressRule_disappears
=== RUN   TestAccVPCSecurityGroupIngressRule_tags
=== PAUSE TestAccVPCSecurityGroupIngressRule_tags
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTags_providerOnly
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTags_providerOnly
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToProviderOnly
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToResourceOnly
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_overlappingTag
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_duplicateTag
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_duplicateTag
=== RUN   TestAccVPCSecurityGroupIngressRule_updateTagsKnownAtApply
=== PAUSE TestAccVPCSecurityGroupIngressRule_updateTagsKnownAtApply
=== RUN   TestAccVPCSecurityGroupIngressRule_defaultAndIgnoreTags
=== PAUSE TestAccVPCSecurityGroupIngressRule_defaultAndIgnoreTags
=== RUN   TestAccVPCSecurityGroupIngressRule_ignoreTags
=== PAUSE TestAccVPCSecurityGroupIngressRule_ignoreTags
=== RUN   TestAccVPCSecurityGroupIngressRule_cidrIPv4
=== PAUSE TestAccVPCSecurityGroupIngressRule_cidrIPv4
=== RUN   TestAccVPCSecurityGroupIngressRule_cidrIPv6
=== PAUSE TestAccVPCSecurityGroupIngressRule_cidrIPv6
=== RUN   TestAccVPCSecurityGroupIngressRule_description
=== PAUSE TestAccVPCSecurityGroupIngressRule_description
=== RUN   TestAccVPCSecurityGroupIngressRule_prefixListID
=== PAUSE TestAccVPCSecurityGroupIngressRule_prefixListID
=== RUN   TestAccVPCSecurityGroupIngressRule_referencedSecurityGroupID
=== PAUSE TestAccVPCSecurityGroupIngressRule_referencedSecurityGroupID
=== RUN   TestAccVPCSecurityGroupIngressRule_ReferencedSecurityGroupID_peerVPC
=== PAUSE TestAccVPCSecurityGroupIngressRule_ReferencedSecurityGroupID_peerVPC
=== RUN   TestAccVPCSecurityGroupIngressRule_updateSourceType
=== PAUSE TestAccVPCSecurityGroupIngressRule_updateSourceType
=== CONT  TestAccVPCSecurityGroupEgressRule_basic
=== CONT  TestAccVPCSecurityGroupIngressRule_updateTagsKnownAtApply
=== CONT  TestAccVPCSecurityGroupIngressRule_description
=== CONT  TestAccVPCSecurityGroupEgressRule_basic
    testing_new.go:82: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: Unexpected Planned Resource State on Destroy
        
          with aws_vpc_security_group_egress_rule.test,
          on terraform_plugin_test.tf line 19, in resource "aws_vpc_security_group_egress_rule" "test":
          19: resource "aws_vpc_security_group_egress_rule" "test" {
        
        The Terraform Provider unexpectedly returned resource state data when the
        resource was planned for destruction. This is always an issue in the
        Terraform Provider and should be reported to the provider developers.
        
        Ensure all resource plan modifiers do not attempt to change resource plan
        data from being a null value if the request plan is a null value.
--- FAIL: TestAccVPCSecurityGroupEgressRule_basic (26.57s)
=== CONT  TestAccVPCSecurityGroupIngressRule_ReferencedSecurityGroupID_peerVPC
    acctest.go:703: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccVPCSecurityGroupIngressRule_ReferencedSecurityGroupID_peerVPC (0.00s)
=== CONT  TestAccVPCSecurityGroupIngressRule_updateSourceType
=== CONT  TestAccVPCSecurityGroupIngressRule_description
    testing_new.go:82: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: Unexpected Planned Resource State on Destroy
        
          with aws_vpc_security_group_ingress_rule.test,
          on terraform_plugin_test.tf line 19, in resource "aws_vpc_security_group_ingress_rule" "test":
          19: resource "aws_vpc_security_group_ingress_rule" "test" {
        
        The Terraform Provider unexpectedly returned resource state data when the
        resource was planned for destruction. This is always an issue in the
        Terraform Provider and should be reported to the provider developers.
        
        Ensure all resource plan modifiers do not attempt to change resource plan
        data from being a null value if the request plan is a null value.
--- FAIL: TestAccVPCSecurityGroupIngressRule_description (43.58s)
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToProviderOnly
=== CONT  TestAccVPCSecurityGroupIngressRule_updateTagsKnownAtApply
    testing_new.go:82: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: Unexpected Planned Resource State on Destroy
        
          with aws_vpc_security_group_ingress_rule.test,
          on terraform_plugin_test.tf line 20, in resource "aws_vpc_security_group_ingress_rule" "test":
          20: resource "aws_vpc_security_group_ingress_rule" "test" {
        
        The Terraform Provider unexpectedly returned resource state data when the
        resource was planned for destruction. This is always an issue in the
        Terraform Provider and should be reported to the provider developers.
        
        Ensure all resource plan modifiers do not attempt to change resource plan
        data from being a null value if the request plan is a null value.
--- FAIL: TestAccVPCSecurityGroupIngressRule_updateTagsKnownAtApply (50.14s)
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_duplicateTag
--- PASS: TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_duplicateTag (1.29s)
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_overlappingTag
=== CONT  TestAccVPCSecurityGroupIngressRule_updateSourceType
    testing_new.go:82: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: Unexpected Planned Resource State on Destroy
        
          with aws_vpc_security_group_ingress_rule.test,
          on terraform_plugin_test.tf line 19, in resource "aws_vpc_security_group_ingress_rule" "test":
          19: resource "aws_vpc_security_group_ingress_rule" "test" {
        
        The Terraform Provider unexpectedly returned resource state data when the
        resource was planned for destruction. This is always an issue in the
        Terraform Provider and should be reported to the provider developers.
        
        Ensure all resource plan modifiers do not attempt to change resource plan
        data from being a null value if the request plan is a null value.
--- FAIL: TestAccVPCSecurityGroupIngressRule_updateSourceType (39.02s)
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_nonOverlappingTag
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToProviderOnly
    testing_new.go:82: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: Unexpected Planned Resource State on Destroy
        
          with aws_vpc_security_group_ingress_rule.test,
          on terraform_plugin_test.tf line 40, in resource "aws_vpc_security_group_ingress_rule" "test":
          40: resource "aws_vpc_security_group_ingress_rule" "test" {
        
        The Terraform Provider unexpectedly returned resource state data when the
        resource was planned for destruction. This is always an issue in the
        Terraform Provider and should be reported to the provider developers.
        
        Ensure all resource plan modifiers do not attempt to change resource plan
        data from being a null value if the request plan is a null value.
--- FAIL: TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToProviderOnly (37.30s)
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToResourceOnly
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_overlappingTag
    testing_new.go:82: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: Unexpected Planned Resource State on Destroy
        
          with aws_vpc_security_group_ingress_rule.test,
          on terraform_plugin_test.tf line 40, in resource "aws_vpc_security_group_ingress_rule" "test":
          40: resource "aws_vpc_security_group_ingress_rule" "test" {
        
        The Terraform Provider unexpectedly returned resource state data when the
        resource was planned for destruction. This is always an issue in the
        Terraform Provider and should be reported to the provider developers.
        
        Ensure all resource plan modifiers do not attempt to change resource plan
        data from being a null value if the request plan is a null value.
--- FAIL: TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_overlappingTag (49.01s)
=== CONT  TestAccVPCSecurityGroupIngressRule_disappears
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_nonOverlappingTag
    testing_new.go:82: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: Unexpected Planned Resource State on Destroy
        
          with aws_vpc_security_group_ingress_rule.test,
          on terraform_plugin_test.tf line 40, in resource "aws_vpc_security_group_ingress_rule" "test":
          40: resource "aws_vpc_security_group_ingress_rule" "test" {
        
        The Terraform Provider unexpectedly returned resource state data when the
        resource was planned for destruction. This is always an issue in the
        Terraform Provider and should be reported to the provider developers.
        
        Ensure all resource plan modifiers do not attempt to change resource plan
        data from being a null value if the request plan is a null value.
--- FAIL: TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_nonOverlappingTag (47.99s)
=== CONT  TestAccVPCSecurityGroupIngressRule_referencedSecurityGroupID
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToResourceOnly
    testing_new.go:82: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: Unexpected Planned Resource State on Destroy
        
          with aws_vpc_security_group_ingress_rule.test,
          on terraform_plugin_test.tf line 19, in resource "aws_vpc_security_group_ingress_rule" "test":
          19: resource "aws_vpc_security_group_ingress_rule" "test" {
        
        The Terraform Provider unexpectedly returned resource state data when the
        resource was planned for destruction. This is always an issue in the
        Terraform Provider and should be reported to the provider developers.
        
        Ensure all resource plan modifiers do not attempt to change resource plan
        data from being a null value if the request plan is a null value.
--- FAIL: TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToResourceOnly (39.73s)
=== CONT  TestAccVPCSecurityGroupIngressRule_prefixListID
--- PASS: TestAccVPCSecurityGroupIngressRule_disappears (24.51s)
=== CONT  TestAccVPCSecurityGroupIngressRule_tags
=== CONT  TestAccVPCSecurityGroupIngressRule_referencedSecurityGroupID
    testing_new.go:82: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: Unexpected Planned Resource State on Destroy
        
          with aws_vpc_security_group_ingress_rule.test,
          on terraform_plugin_test.tf line 28, in resource "aws_vpc_security_group_ingress_rule" "test":
          28: resource "aws_vpc_security_group_ingress_rule" "test" {
        
        The Terraform Provider unexpectedly returned resource state data when the
        resource was planned for destruction. This is always an issue in the
        Terraform Provider and should be reported to the provider developers.
        
        Ensure all resource plan modifiers do not attempt to change resource plan
        data from being a null value if the request plan is a null value.
--- FAIL: TestAccVPCSecurityGroupIngressRule_referencedSecurityGroupID (42.26s)
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTags_providerOnly
=== CONT  TestAccVPCSecurityGroupIngressRule_prefixListID
    testing_new.go:82: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: Unexpected Planned Resource State on Destroy
        
          with aws_vpc_security_group_ingress_rule.test,
          on terraform_plugin_test.tf line 39, in resource "aws_vpc_security_group_ingress_rule" "test":
          39: resource "aws_vpc_security_group_ingress_rule" "test" {
        
        The Terraform Provider unexpectedly returned resource state data when the
        resource was planned for destruction. This is always an issue in the
        Terraform Provider and should be reported to the provider developers.
        
        Ensure all resource plan modifiers do not attempt to change resource plan
        data from being a null value if the request plan is a null value.
--- FAIL: TestAccVPCSecurityGroupIngressRule_prefixListID (44.58s)
=== CONT  TestAccVPCSecurityGroupIngressRule_cidrIPv4
=== CONT  TestAccVPCSecurityGroupIngressRule_tags
    testing_new.go:82: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: Unexpected Planned Resource State on Destroy
        
          with aws_vpc_security_group_ingress_rule.test,
          on terraform_plugin_test.tf line 19, in resource "aws_vpc_security_group_ingress_rule" "test":
          19: resource "aws_vpc_security_group_ingress_rule" "test" {
        
        The Terraform Provider unexpectedly returned resource state data when the
        resource was planned for destruction. This is always an issue in the
        Terraform Provider and should be reported to the provider developers.
        
        Ensure all resource plan modifiers do not attempt to change resource plan
        data from being a null value if the request plan is a null value.
--- FAIL: TestAccVPCSecurityGroupIngressRule_tags (55.35s)
=== CONT  TestAccVPCSecurityGroupIngressRule_cidrIPv6
=== CONT  TestAccVPCSecurityGroupIngressRule_cidrIPv4
    testing_new.go:82: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: Unexpected Planned Resource State on Destroy
        
          with aws_vpc_security_group_ingress_rule.test,
          on terraform_plugin_test.tf line 19, in resource "aws_vpc_security_group_ingress_rule" "test":
          19: resource "aws_vpc_security_group_ingress_rule" "test" {
        
        The Terraform Provider unexpectedly returned resource state data when the
        resource was planned for destruction. This is always an issue in the
        Terraform Provider and should be reported to the provider developers.
        
        Ensure all resource plan modifiers do not attempt to change resource plan
        data from being a null value if the request plan is a null value.
--- FAIL: TestAccVPCSecurityGroupIngressRule_cidrIPv4 (38.91s)
=== CONT  TestAccVPCSecurityGroupIngressRule_ignoreTags
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTags_providerOnly
    testing_new.go:82: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: Unexpected Planned Resource State on Destroy
        
          with aws_vpc_security_group_ingress_rule.test,
          on terraform_plugin_test.tf line 40, in resource "aws_vpc_security_group_ingress_rule" "test":
          40: resource "aws_vpc_security_group_ingress_rule" "test" {
        
        The Terraform Provider unexpectedly returned resource state data when the
        resource was planned for destruction. This is always an issue in the
        Terraform Provider and should be reported to the provider developers.
        
        Ensure all resource plan modifiers do not attempt to change resource plan
        data from being a null value if the request plan is a null value.
--- FAIL: TestAccVPCSecurityGroupIngressRule_DefaultTags_providerOnly (49.71s)
=== CONT  TestAccVPCSecurityGroupEgressRule_disappears
=== CONT  TestAccVPCSecurityGroupIngressRule_cidrIPv6
    testing_new.go:82: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: Unexpected Planned Resource State on Destroy
        
          with aws_vpc_security_group_ingress_rule.test,
          on terraform_plugin_test.tf line 19, in resource "aws_vpc_security_group_ingress_rule" "test":
          19: resource "aws_vpc_security_group_ingress_rule" "test" {
        
        The Terraform Provider unexpectedly returned resource state data when the
        resource was planned for destruction. This is always an issue in the
        Terraform Provider and should be reported to the provider developers.
        
        Ensure all resource plan modifiers do not attempt to change resource plan
        data from being a null value if the request plan is a null value.
--- FAIL: TestAccVPCSecurityGroupIngressRule_cidrIPv6 (39.02s)
=== CONT  TestAccVPCSecurityGroupIngressRule_basic
--- PASS: TestAccVPCSecurityGroupEgressRule_disappears (23.44s)
=== CONT  TestAccVPCSecurityGroupIngressRule_defaultAndIgnoreTags
=== CONT  TestAccVPCSecurityGroupIngressRule_basic
    testing_new.go:82: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: Unexpected Planned Resource State on Destroy
        
          with aws_vpc_security_group_ingress_rule.test,
          on terraform_plugin_test.tf line 19, in resource "aws_vpc_security_group_ingress_rule" "test":
          19: resource "aws_vpc_security_group_ingress_rule" "test" {
        
        The Terraform Provider unexpectedly returned resource state data when the
        resource was planned for destruction. This is always an issue in the
        Terraform Provider and should be reported to the provider developers.
        
        Ensure all resource plan modifiers do not attempt to change resource plan
        data from being a null value if the request plan is a null value.
--- FAIL: TestAccVPCSecurityGroupIngressRule_basic (22.88s)
=== CONT  TestAccVPCSecurityGroupIngressRule_ignoreTags
    testing_new.go:82: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: Unexpected Planned Resource State on Destroy
        
          with aws_vpc_security_group_ingress_rule.test,
          on terraform_plugin_test.tf line 25, in resource "aws_vpc_security_group_ingress_rule" "test":
          25: resource "aws_vpc_security_group_ingress_rule" "test" {
        
        The Terraform Provider unexpectedly returned resource state data when the
        resource was planned for destruction. This is always an issue in the
        Terraform Provider and should be reported to the provider developers.
        
        Ensure all resource plan modifiers do not attempt to change resource plan
        data from being a null value if the request plan is a null value.
--- FAIL: TestAccVPCSecurityGroupIngressRule_ignoreTags (42.58s)
=== CONT  TestAccVPCSecurityGroupIngressRule_defaultAndIgnoreTags
    testing_new.go:82: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: Unexpected Planned Resource State on Destroy
        
          with aws_vpc_security_group_ingress_rule.test,
          on terraform_plugin_test.tf line 30, in resource "aws_vpc_security_group_ingress_rule" "test":
          30: resource "aws_vpc_security_group_ingress_rule" "test" {
        
        The Terraform Provider unexpectedly returned resource state data when the
        resource was planned for destruction. This is always an issue in the
        Terraform Provider and should be reported to the provider developers.
        
        Ensure all resource plan modifiers do not attempt to change resource plan
        data from being a null value if the request plan is a null value.
--- FAIL: TestAccVPCSecurityGroupIngressRule_defaultAndIgnoreTags (41.14s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	275.438s
FAIL
make: *** [testacc] Error 1

With fix

% make testacc TESTARGS='-run=TestAccVPCSecurityGroupEgressRule_\|TestAccVPCSecurityGroupIngressRule_' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccVPCSecurityGroupEgressRule_\|TestAccVPCSecurityGroupIngressRule_ -timeout 180m
=== RUN   TestAccVPCSecurityGroupEgressRule_basic
=== PAUSE TestAccVPCSecurityGroupEgressRule_basic
=== RUN   TestAccVPCSecurityGroupEgressRule_disappears
=== PAUSE TestAccVPCSecurityGroupEgressRule_disappears
=== RUN   TestAccVPCSecurityGroupIngressRule_basic
=== PAUSE TestAccVPCSecurityGroupIngressRule_basic
=== RUN   TestAccVPCSecurityGroupIngressRule_disappears
=== PAUSE TestAccVPCSecurityGroupIngressRule_disappears
=== RUN   TestAccVPCSecurityGroupIngressRule_tags
=== PAUSE TestAccVPCSecurityGroupIngressRule_tags
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTags_providerOnly
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTags_providerOnly
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToProviderOnly
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToResourceOnly
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_overlappingTag
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_duplicateTag
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_duplicateTag
=== RUN   TestAccVPCSecurityGroupIngressRule_updateTagsKnownAtApply
=== PAUSE TestAccVPCSecurityGroupIngressRule_updateTagsKnownAtApply
=== RUN   TestAccVPCSecurityGroupIngressRule_defaultAndIgnoreTags
=== PAUSE TestAccVPCSecurityGroupIngressRule_defaultAndIgnoreTags
=== RUN   TestAccVPCSecurityGroupIngressRule_ignoreTags
=== PAUSE TestAccVPCSecurityGroupIngressRule_ignoreTags
=== RUN   TestAccVPCSecurityGroupIngressRule_cidrIPv4
=== PAUSE TestAccVPCSecurityGroupIngressRule_cidrIPv4
=== RUN   TestAccVPCSecurityGroupIngressRule_cidrIPv6
=== PAUSE TestAccVPCSecurityGroupIngressRule_cidrIPv6
=== RUN   TestAccVPCSecurityGroupIngressRule_description
=== PAUSE TestAccVPCSecurityGroupIngressRule_description
=== RUN   TestAccVPCSecurityGroupIngressRule_prefixListID
=== PAUSE TestAccVPCSecurityGroupIngressRule_prefixListID
=== RUN   TestAccVPCSecurityGroupIngressRule_referencedSecurityGroupID
=== PAUSE TestAccVPCSecurityGroupIngressRule_referencedSecurityGroupID
=== RUN   TestAccVPCSecurityGroupIngressRule_ReferencedSecurityGroupID_peerVPC
=== PAUSE TestAccVPCSecurityGroupIngressRule_ReferencedSecurityGroupID_peerVPC
=== RUN   TestAccVPCSecurityGroupIngressRule_updateSourceType
=== PAUSE TestAccVPCSecurityGroupIngressRule_updateSourceType
=== CONT  TestAccVPCSecurityGroupEgressRule_basic
=== CONT  TestAccVPCSecurityGroupIngressRule_updateTagsKnownAtApply
=== CONT  TestAccVPCSecurityGroupIngressRule_description
--- PASS: TestAccVPCSecurityGroupEgressRule_basic (31.83s)
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToProviderOnly
--- PASS: TestAccVPCSecurityGroupIngressRule_description (48.51s)
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_overlappingTag
--- PASS: TestAccVPCSecurityGroupIngressRule_updateTagsKnownAtApply (57.73s)
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_duplicateTag
--- PASS: TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_duplicateTag (1.45s)
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_nonOverlappingTag
--- PASS: TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToProviderOnly (42.28s)
=== CONT  TestAccVPCSecurityGroupIngressRule_ReferencedSecurityGroupID_peerVPC
    acctest.go:703: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccVPCSecurityGroupIngressRule_ReferencedSecurityGroupID_peerVPC (0.00s)
=== CONT  TestAccVPCSecurityGroupIngressRule_updateSourceType
--- PASS: TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_overlappingTag (54.62s)
=== CONT  TestAccVPCSecurityGroupIngressRule_referencedSecurityGroupID
--- PASS: TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_nonOverlappingTag (53.23s)
=== CONT  TestAccVPCSecurityGroupIngressRule_prefixListID
--- PASS: TestAccVPCSecurityGroupIngressRule_updateSourceType (46.01s)
=== CONT  TestAccVPCSecurityGroupIngressRule_cidrIPv6
--- PASS: TestAccVPCSecurityGroupIngressRule_referencedSecurityGroupID (47.16s)
=== CONT  TestAccVPCSecurityGroupIngressRule_cidrIPv4
--- PASS: TestAccVPCSecurityGroupIngressRule_cidrIPv6 (43.92s)
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToResourceOnly
--- PASS: TestAccVPCSecurityGroupIngressRule_prefixListID (53.93s)
=== CONT  TestAccVPCSecurityGroupIngressRule_ignoreTags
--- PASS: TestAccVPCSecurityGroupIngressRule_cidrIPv4 (46.83s)
=== CONT  TestAccVPCSecurityGroupIngressRule_disappears
--- PASS: TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToResourceOnly (47.02s)
=== CONT  TestAccVPCSecurityGroupIngressRule_basic
--- PASS: TestAccVPCSecurityGroupIngressRule_ignoreTags (53.49s)
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTags_providerOnly
--- PASS: TestAccVPCSecurityGroupIngressRule_disappears (26.15s)
=== CONT  TestAccVPCSecurityGroupIngressRule_defaultAndIgnoreTags
--- PASS: TestAccVPCSecurityGroupIngressRule_basic (29.24s)
=== CONT  TestAccVPCSecurityGroupIngressRule_tags
--- PASS: TestAccVPCSecurityGroupIngressRule_defaultAndIgnoreTags (48.80s)
=== CONT  TestAccVPCSecurityGroupEgressRule_disappears
--- PASS: TestAccVPCSecurityGroupIngressRule_DefaultTags_providerOnly (53.66s)
--- PASS: TestAccVPCSecurityGroupEgressRule_disappears (23.69s)
--- PASS: TestAccVPCSecurityGroupIngressRule_tags (58.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	305.646s

github-actions · 2023-02-21T13:41:41Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

jar-b

LGTM 🎉

github-actions · 2023-02-24T19:57:08Z

This functionality has been released in v4.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2023-03-27T02:12:49Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

Don't do anything for Framework 'tags_all' plan modification on Delete.

b1d2de4

github-actions bot added the size/XS Managed by automation to categorize the size of a PR. label Feb 21, 2023

Add CHANGELOG entry.

fd30e8b

jar-b approved these changes Feb 21, 2023

View reviewed changes

ewbankkit merged commit 928306b into main Feb 21, 2023

ewbankkit deleted the b-SetTagsAll-DeletePlan branch February 21, 2023 15:42

github-actions bot added this to the v4.56.0 milestone Feb 21, 2023

github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't do anything for Framework `tags_all` plan modification on Delete #29550

Don't do anything for Framework `tags_all` plan modification on Delete #29550

ewbankkit commented Feb 21, 2023 •

edited

Loading

github-actions bot commented Feb 21, 2023

jar-b left a comment

github-actions bot commented Feb 24, 2023

github-actions bot commented Mar 27, 2023

Don't do anything for Framework tags_all plan modification on Delete #29550

Don't do anything for Framework tags_all plan modification on Delete #29550

Conversation

ewbankkit commented Feb 21, 2023 • edited Loading

Description

Relations

References

Output from Acceptance Testing

Without fix

With fix

github-actions bot commented Feb 21, 2023

Community Note

jar-b left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 24, 2023

github-actions bot commented Mar 27, 2023

Don't do anything for Framework `tags_all` plan modification on Delete #29550

Don't do anything for Framework `tags_all` plan modification on Delete #29550

ewbankkit commented Feb 21, 2023 •

edited

Loading