Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Source: EC2 Transit Gateway Attachments (plural) #29644

Merged
merged 8 commits into from
Mar 31, 2023
Merged

Data Source: EC2 Transit Gateway Attachments (plural) #29644

merged 8 commits into from
Mar 31, 2023

Conversation

lukas-hetzenecker
Copy link
Contributor

@lukas-hetzenecker lukas-hetzenecker commented Feb 24, 2023 •
edited
Loading

Description

This Pull request Implements a new data source: aws_ec2_transit_gateway_attachments which returns (plural) informations about EC2 Transit Gateway Attachments

Relations

Closes #25745

Output from Acceptance Testing

$ make testacc TESTS=TestAccTransitGatewayAttachmentsDataSource PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccTransitGatewayAttachmentsDataSource'  -timeout 180m
=== RUN   TestAccTransitGatewayAttachmentsDataSource_Filter
--- PASS: TestAccTransitGatewayAttachmentsDataSource_Filter (334.12s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	337.365s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/transitgateway Issues and PRs that pertain to the transitgateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. service/transitgateway Issues and PRs that pertain to the transitgateway service. labels Feb 24, 2023
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/transitgateway Issues and PRs that pertain to the transitgateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 24, 2023
@lukas-hetzenecker lukas-hetzenecker marked this pull request as ready for review February 24, 2023 19:55
@ewbankkit ewbankkit added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 31, 2023
@github-actions github-actions bot added generators Relates to code generators. and removed provider Pertains to the provider itself, rather than any interaction with AWS. labels Mar 31, 2023
ewbankkit
ewbankkit approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccTransitGatewayDataSource_serial/^Attachments$$' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccTransitGatewayDataSource_serial/^Attachments$ -timeout 180m
=== RUN   TestAccTransitGatewayDataSource_serial
=== PAUSE TestAccTransitGatewayDataSource_serial
=== CONT  TestAccTransitGatewayDataSource_serial
=== RUN   TestAccTransitGatewayDataSource_serial/Attachments
=== RUN   TestAccTransitGatewayDataSource_serial/Attachments/Filter
--- PASS: TestAccTransitGatewayDataSource_serial (316.79s)
    --- PASS: TestAccTransitGatewayDataSource_serial/Attachments (316.79s)
        --- PASS: TestAccTransitGatewayDataSource_serial/Attachments/Filter (316.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	322.167s

@ewbankkit
Copy link
Contributor

@lukas-hetzenecker Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 42a4da9 into hashicorp:main Mar 31, 2023
@github-actions github-actions bot added this to the v4.62.0 milestone Mar 31, 2023
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

This functionality has been released in v4.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. service/transitgateway Issues and PRs that pertain to the transitgateway service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.62.0
Development

Successfully merging this pull request may close these issues.

New Datasource: aws_ec2_transit_gateway_attachments (plural)
2 participants
@lukas-hetzenecker @ewbankkit