Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From aws_dms_endpoint, remove s3_settings #29726

Open
YakDriver opened this issue Feb 28, 2023 · 1 comment
Open

From aws_dms_endpoint, remove s3_settings #29726

YakDriver opened this issue Feb 28, 2023 · 1 comment
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. service/dms Issues and PRs that pertain to the dms service.
Milestone

Comments

@YakDriver
Copy link
Member

YakDriver commented Feb 28, 2023

Attempting to support all endpoints together with all extra_connection_attributes specific to all the different endpoints is not a sustainable approach. It has resulted in many problems over the years. Now that aws_dms_s3_endpoint is available, aws_dms_endpoint.*.s3_settings should eventually be removed.

Affected Resource(s)

  • aws_dms_endpoint

References

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@YakDriver YakDriver added this to the v5.0.0 milestone Feb 28, 2023
@YakDriver YakDriver added breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. service/dms Issues and PRs that pertain to the dms service. labels Feb 28, 2023
@johnsonaj johnsonaj modified the milestones: v5.0.0, v6.0.0 May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. service/dms Issues and PRs that pertain to the dms service.
Projects
None yet
Development

No branches or pull requests

2 participants