Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource and Data source: aws_ssmincidents_replicationset #29769

Merged
merged 10 commits into from
Mar 28, 2023
Merged

New Resource and Data source: aws_ssmincidents_replicationset #29769

merged 10 commits into from
Mar 28, 2023

Conversation

pschun
Copy link
Contributor

@pschun pschun commented Mar 3, 2023 •
edited
Loading

Description

Support AWS Incident Manager ReplicationSet Resource and Data.

References

https://docs.aws.amazon.com/incident-manager/latest/APIReference/API_CreateReplicationSet.html

Output from Acceptance Testing

$ make testacc TESTS=TestAccSSMIncidentsReplicationSet_serial PKG=ssmincidents
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssmincidents/... -v -count 1 -parallel 20 -run='TestAccSSMIncidentsReplicationSet_serial'  -timeout 180m
=== RUN   TestAccSSMIncidentsReplicationSet_serial
=== PAUSE TestAccSSMIncidentsReplicationSet_serial
=== CONT  TestAccSSMIncidentsReplicationSet_serial
=== RUN   TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Resource_Tests
=== RUN   TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Resource_Tests/updateDefaultKey
=== RUN   TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Resource_Tests/updateCMK
=== RUN   TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Resource_Tests/updateTags
=== RUN   TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Resource_Tests/updateEmptyTags
=== RUN   TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Resource_Tests/disappears
=== RUN   TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Resource_Tests/basic
=== RUN   TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Data_Source_Tests
=== RUN   TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Data_Source_Tests/basic
--- PASS: TestAccSSMIncidentsReplicationSet_serial (6995.61s)
    --- PASS: TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Resource_Tests (6664.77s)
        --- PASS: TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Resource_Tests/updateDefaultKey (1799.38s)
        --- PASS: TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Resource_Tests/updateCMK (1743.03s)
        --- PASS: TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Resource_Tests/updateTags (348.90s)
        --- PASS: TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Resource_Tests/updateEmptyTags (363.91s)
        --- PASS: TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Resource_Tests/disappears (1110.45s)
        --- PASS: TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Resource_Tests/basic (1299.09s)
    --- PASS: TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Data_Source_Tests (330.84s)
        --- PASS: TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Data_Source_Tests/basic (330.84s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ssmincidents       7000.443s
...

@pschun pschun force-pushed the f-ssmincidents-replicationset branch from d9d60f3 to a1f7fe8 Compare March 3, 2023 00:46
@pschun pschun changed the title F ssmincidents replicationset add resource: aws_ssmincidents_replicationset Mar 3, 2023
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/ssmincidents Issues and PRs that pertain to the ssmincidents service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 3, 2023
@pschun pschun closed this Mar 3, 2023
@pschun pschun reopened this Mar 3, 2023
@pschun pschun changed the title add resource: aws_ssmincidents_replicationset [DRAFT]add resource: aws_ssmincidents_replicationset Mar 3, 2023
@pschun pschun changed the title [DRAFT]add resource: aws_ssmincidents_replicationset add resource: aws_ssmincidents_replicationset Mar 3, 2023
@pschun pschun changed the title add resource: aws_ssmincidents_replicationset add resource and data source: aws_ssmincidents_replicationset Mar 3, 2023
@pschun pschun force-pushed the f-ssmincidents-replicationset branch from 5523d88 to a1dd29e Compare March 6, 2023 23:20
@pschun
Copy link
Contributor Author

pschun commented Mar 10, 2023

related issue: #22687

@pschun pschun changed the title add resource and data source: aws_ssmincidents_replicationset New Resource and Data source: aws_ssmincidents_replicationset Mar 14, 2023
@pschun pschun force-pushed the f-ssmincidents-replicationset branch from dc0b151 to 5d4d6f0 Compare March 15, 2023 00:23
@pschun pschun force-pushed the f-ssmincidents-replicationset branch from 5d4d6f0 to 3f1d968 Compare March 15, 2023 00:25
@ewbankkit ewbankkit added the partner Contribution from a partner. label Mar 28, 2023
@ewbankkit ewbankkit self-assigned this Mar 28, 2023
ewbankkit
ewbankkit approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSSMIncidentsReplicationSet_serial' PKG=ssmincidents
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssmincidents/... -v -count 1 -parallel 20  -run=TestAccSSMIncidentsReplicationSet_serial -timeout 180m
=== RUN   TestAccSSMIncidentsReplicationSet_serial
=== PAUSE TestAccSSMIncidentsReplicationSet_serial
=== CONT  TestAccSSMIncidentsReplicationSet_serial
=== RUN   TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Data_Source_Tests
=== RUN   TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Data_Source_Tests/basic
=== RUN   TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Resource_Tests
=== RUN   TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Resource_Tests/updateDefaultKey
=== RUN   TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Resource_Tests/updateCMK
=== RUN   TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Resource_Tests/updateTags
=== RUN   TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Resource_Tests/updateEmptyTags
=== RUN   TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Resource_Tests/disappears
=== RUN   TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Resource_Tests/basic
--- PASS: TestAccSSMIncidentsReplicationSet_serial (7021.50s)
    --- PASS: TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Data_Source_Tests (321.87s)
        --- PASS: TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Data_Source_Tests/basic (321.87s)
    --- PASS: TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Resource_Tests (6699.62s)
        --- PASS: TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Resource_Tests/updateDefaultKey (1806.52s)
        --- PASS: TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Resource_Tests/updateCMK (1882.17s)
        --- PASS: TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Resource_Tests/updateTags (339.83s)
        --- PASS: TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Resource_Tests/updateEmptyTags (344.54s)
        --- PASS: TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Resource_Tests/disappears (1100.50s)
        --- PASS: TestAccSSMIncidentsReplicationSet_serial/Replication_Set_Resource_Tests/basic (1226.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssmincidents	7027.174s

@ewbankkit
Copy link
Contributor

@pschun Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 61b0c8f into hashicorp:main Mar 28, 2023
@github-actions github-actions bot added this to the v4.61.0 milestone Mar 28, 2023
@pschun pschun deleted the f-ssmincidents-replicationset branch March 28, 2023 23:22
@github-actions
Copy link

This functionality has been released in v4.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 1, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/ssmincidents Issues and PRs that pertain to the ssmincidents service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.61.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pschun @ewbankkit